Bug 132110 - Wizard service broken
Summary: Wizard service broken
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Extensions (show other bugs)
Version:
(earliest affected)
6.4.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.6.0 target:7.5.2
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Wizard
  Show dependency treegraph
 
Reported: 2020-04-15 02:34 UTC by prrvchr
Modified: 2023-07-26 11:37 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description prrvchr 2020-04-15 02:34:24 UTC
Hi,

I just tested last version 6.4.2.2...
And now I have two extensions with wizards that no longer open...

https://github.com/prrvchr/OAuth2OOo/blob/master/OAuth2OOo.oxt
https://github.com/prrvchr/smtpMailerOOo/blob/master/smtpMailerOOo.oxt

Can we know what has been changed in the Wizard service...

Thanks
Comment 1 Julien Nabet 2020-04-15 07:39:08 UTC Comment hidden (obsolete)
Comment 2 Julien Nabet 2020-04-15 08:29:48 UTC Comment hidden (obsolete)
Comment 3 Julien Nabet 2020-04-15 09:09:56 UTC Comment hidden (obsolete)
Comment 4 Julien Nabet 2020-04-15 09:15:09 UTC
Ok I could install both extensions even if I noticed these logs on console:

For OAuth2OOo.oxt
warn:io.connector:15872:15941:io/source/connector/connector.cxx:97: Connector : couldn't connect to pipe af2aa4b4cea08373a418bd7ae4d74dcc162b11d52de42ba7bb9877b98c62d2(10)

> accepting pipe,name=af2aa4b4cea08373a418bd7ae4d74dcc162b11d52de42ba7bb9877b98c62d2...connection established.warn:io.connector:15872:15941:io/source/connector/connector.cxx:97: Connector : couldn't connect to pipe f43f964870e26b7626a6e57ab92c795ce0b32dede3bb3bfb820c4b66a67a184(10)

> accepting pipe,name=f43f964870e26b7626a6e57ab92c795ce0b32dede3bb3bfb820c4b66a67a184...connection established.warn:configmgr:15872:15941:configmgr/source/xcuparser.cxx:646: unknown property "Id" in "file:///home/julien/lo/libreoffice/instdir/program/../program/../user/uno_packages/cache/registry/com.sun.star.comp.deployment.configuration.PackageRegistryBackend/lu146xe7.tmp/OptionsDialog.xcu"


smtpMailerOOo.oxt
warn:io.connector:15872:15941:io/source/connector/connector.cxx:97: Connector : couldn't connect to pipe 62f466fc7e1c7e215fce8429565de7e1bb6c5f8887a6b73ad5acfda4f686cf(10)

> accepting pipe,name=62f466fc7e1c7e215fce8429565de7e1bb6c5f8887a6b73ad5acfda4f686cf...connection established.warn:configmgr:15872:15941:configmgr/source/xcuparser.cxx:646: unknown property "Id" in "file:///home/julien/lo/libreoffice/instdir/program/../program/../user/uno_packages/cache/registry/com.sun.star.comp.deployment.configuration.PackageRegistryBackend/lu146xed.tmp/OptionsDialog.xcu"
warn:io.connector:15872:15941:io/source/connector/connector.cxx:97: Connector : couldn't connect to pipe 9422eda05fbe6e5b6a363830c48d9be13c6e42b7fa7365e76f57de8f174bef3(10)

> accepting pipe,name=9422eda05fbe6e5b6a363830c48d9be13c6e42b7fa7365e76f57de8f174bef3...connection established.warn:io.connector:15872:15941:io/source/connector/connector.cxx:97: Connector : couldn't connect to pipe 50fbe2b6872bf39f1ac1faab66b56baa7852ed9fba493c284a4eecb3998773d(10)

> accepting pipe,name=50fbe2b6872bf39f1ac1faab66b56baa7852ed9fba493c284a4eecb3998773d...connection established
Comment 5 Julien Nabet 2020-04-15 09:18:17 UTC
I saw both new entries in Tools/Options/Internet

In Tools/Addons, I see smtpMailerOOo but I got this error:
Python exception: <class 'RuntimeError'>: Type [] string is unknown, traceback follows
  File "/home/julien/lo/libreoffice/instdir/user/uno_packages/cache/uno_packages/lu146xe6.tmp_/OAuth2OOo.oxt/pythonpath/unolib/unolib.py", line 46, in getPropertySetInfo
    properties = self._getPropertySetInfo()
  File "/home/julien/lo/libreoffice/instdir/user/uno_packages/cache/uno_packages/lu146xeb.tmp_/smtpMailerOOo.oxt/pythonpath/smtpmailer/wizardhandler.py", line 383, in _getPropertySetInfo
    properties['DataSources'] = getProperty('DataSources', '[] string', transient)
  File "/home/julien/lo/libreoffice/instdir/user/uno_packages/cache/uno_packages/lu146xe6.tmp_/OAuth2OOo.oxt/pythonpath/unolib/unotools.py", line 53, in getProperty
    property.Type = uno.getTypeByName(type)
  File "/home/julien/lo/libreoffice/instdir/program/uno.py", line 73, in getTypeByName
    return pyuno.getTypeByName(typeName)


Python exception: <class 'RuntimeError'>: Type [] string is unknown, traceback follows
  File "/home/julien/lo/libreoffice/instdir/user/uno_packages/cache/uno_packages/lu146xe6.tmp_/OAuth2OOo.oxt/pythonpath/unolib/unolib.py", line 46, in getPropertySetInfo
    properties = self._getPropertySetInfo()
  File "/home/julien/lo/libreoffice/instdir/user/uno_packages/cache/uno_packages/lu146xeb.tmp_/smtpMailerOOo.oxt/pythonpath/smtpmailer/wizardhandler.py", line 383, in _getPropertySetInfo
    properties['DataSources'] = getProperty('DataSources', '[] string', transient)
  File "/home/julien/lo/libreoffice/instdir/user/uno_packages/cache/uno_packages/lu146xe6.tmp_/OAuth2OOo.oxt/pythonpath/unolib/unotools.py", line 53, in getProperty
    property.Type = uno.getTypeByName(type)
  File "/home/julien/lo/libreoffice/instdir/program/uno.py", line 73, in getTypeByName
    return pyuno.getTypeByName(typeName)


wizardpage.__init__() 1
warn:stoc:16405:16405:stoc/source/inspect/introspection.cxx:1612: object of type "com.sun.star.uno.XReference" lacks XTypeProvider
warn:stoc:16405:16405:stoc/source/inspect/introspection.cxx:1612: object of type "com.sun.star.uno.XReference" lacks XTypeProvider
Traceback (most recent call last):
  File "/home/julien/lo/libreoffice/instdir/user/uno_packages/cache/uno_packages/lu146xeb.tmp_/smtpMailerOOo.oxt/pythonpath/smtpmailer/wizardpage.py", line 66, in __init__
    self._refreshPage2()
  File "/home/julien/lo/libreoffice/instdir/user/uno_packages/cache/uno_packages/lu146xeb.tmp_/smtpMailerOOo.oxt/pythonpath/smtpmailer/wizardpage.py", line 191, in _refreshPage2
    self._handler.refreshTables(self.Window.getControl('ListBox1'))
  File "/home/julien/lo/libreoffice/instdir/user/uno_packages/cache/uno_packages/lu146xeb.tmp_/smtpMailerOOo.oxt/pythonpath/smtpmailer/wizardhandler.py", line 259, in refreshTables
    table = self._query.UpdateTableName
AttributeError: 'NoneType' object has no attribute 'UpdateTableName'
Python exception: <class 'RuntimeError'>: Type [] string is unknown, traceback follows
  File "/home/julien/lo/libreoffice/instdir/user/uno_packages/cache/uno_packages/lu146xe6.tmp_/OAuth2OOo.oxt/pythonpath/unolib/unolib.py", line 46, in getPropertySetInfo
    properties = self._getPropertySetInfo()
  File "/home/julien/lo/libreoffice/instdir/user/uno_packages/cache/uno_packages/lu146xeb.tmp_/smtpMailerOOo.oxt/pythonpath/smtpmailer/wizardhandler.py", line 383, in _getPropertySetInfo
    properties['DataSources'] = getProperty('DataSources', '[] string', transient)
  File "/home/julien/lo/libreoffice/instdir/user/uno_packages/cache/uno_packages/lu146xe6.tmp_/OAuth2OOo.oxt/pythonpath/unolib/unotools.py", line 53, in getProperty
    property.Type = uno.getTypeByName(type)
  File "/home/julien/lo/libreoffice/instdir/program/uno.py", line 73, in getTypeByName
    return pyuno.getTypeByName(typeName)

Let's put this to NEW then.
I can dig a bit but wonder if it could be due to Python3/2 compatibility.
Comment 6 Julien Nabet 2020-04-15 09:23:04 UTC
Would it be possible you indicate with which max LO version it worked?
Comment 7 Julien Nabet 2020-04-15 09:42:20 UTC
Stephan: taking a look at this error:
Python exception: <class 'RuntimeError'>: Type [] string is unknown, traceback follows
  File "/home/julien/lo/libreoffice/instdir/user/uno_packages/cache/uno_packages/lu146xe6.tmp_/OAuth2OOo.oxt/pythonpath/unolib/unolib.py", line 46, in getPropertySetInfo
    properties = self._getPropertySetInfo()
  File "/home/julien/lo/libreoffice/instdir/user/uno_packages/cache/uno_packages/lu146xeb.tmp_/smtpMailerOOo.oxt/pythonpath/smtpmailer/wizardhandler.py", line 383, in _getPropertySetInfo
    properties['DataSources'] = getProperty('DataSources', '[] string', transient)
  File "/home/julien/lo/libreoffice/instdir/user/uno_packages/cache/uno_packages/lu146xe6.tmp_/OAuth2OOo.oxt/pythonpath/unolib/unotools.py", line 53, in getProperty
    property.Type = uno.getTypeByName(type)
  File "/home/julien/lo/libreoffice/instdir/program/uno.py", line 73, in getTypeByName
    return pyuno.getTypeByName(typeName)

I thought we could use this patch:
diff --git a/cppu/source/typelib/typelib.cxx b/cppu/source/typelib/typelib.cxx
index 92a7e6ca5120..b9f008365bcf 100644
--- a/cppu/source/typelib/typelib.cxx
+++ b/cppu/source/typelib/typelib.cxx
@@ -1906,6 +1906,7 @@ extern "C" void SAL_CALL typelib_typedescription_getByName(
         if (2 < name.getLength() && '[' == name[ 0 ])
         {
             OUString element_name( name.copy( 2 ) );
+            element_name = element_name.trim();
             typelib_TypeDescription * element_td = nullptr;
             typelib_typedescription_getByName( &element_td, element_name.pData );
             if (nullptr != element_td)

What do you think?

Is it ok or should the extension use "[]string" instead of "[] string"
in this block
    378     def _getPropertySetInfo(self):
    379         properties = {}
    380         readonly = uno.getConstantByName('com.sun.star.beans.PropertyAttribute.READONLY')
    381         transient = uno.getConstantByName('com.sun.star.beans.PropertyAttribute.TRANSIENT')
    382         properties['Connection'] = getProperty('Connection', 'com.sun.star.sdbc.XConnection', transient)
    383         properties['DataSources'] = getProperty('DataSources', '[] string', transient)
    384         properties['TableNames'] = getProperty('TableNames', '[] string', transient)
    385         properties['ColumnNames'] = getProperty('ColumnNames', '[] string', transient)
    386         return properties
?

prrvchr: even after workarounding this pb, I got a new Python error, see console logs:
wizardpage.__init__() 1
warn:stoc:17328:17328:stoc/source/inspect/introspection.cxx:1612: object of type "com.sun.star.uno.XReference" lacks XTypeProvider
warn:stoc:17328:17328:stoc/source/inspect/introspection.cxx:1612: object of type "com.sun.star.uno.XReference" lacks XTypeProvider
Traceback (most recent call last):
  File "/home/julien/lo/libreoffice/instdir/user/uno_packages/cache/uno_packages/lu146xeb.tmp_/smtpMailerOOo.oxt/pythonpath/smtpmailer/wizardpage.py", line 66, in __init__
    self._refreshPage2()
  File "/home/julien/lo/libreoffice/instdir/user/uno_packages/cache/uno_packages/lu146xeb.tmp_/smtpMailerOOo.oxt/pythonpath/smtpmailer/wizardpage.py", line 191, in _refreshPage2
    self._handler.refreshTables(self.Window.getControl('ListBox1'))
  File "/home/julien/lo/libreoffice/instdir/user/uno_packages/cache/uno_packages/lu146xeb.tmp_/smtpMailerOOo.oxt/pythonpath/smtpmailer/wizardhandler.py", line 259, in refreshTables
    table = self._query.UpdateTableName
AttributeError: 'NoneType' object has no attribute 'UpdateTableName'
Comment 8 Stephan Bergmann 2020-04-15 10:01:10 UTC
(In reply to Julien Nabet from comment #7)
> Stephan: taking a look at this error:
> Python exception: <class 'RuntimeError'>: Type [] string is unknown,
> traceback follows
>   File
> "/home/julien/lo/libreoffice/instdir/user/uno_packages/cache/uno_packages/
> lu146xe6.tmp_/OAuth2OOo.oxt/pythonpath/unolib/unolib.py", line 46, in
> getPropertySetInfo
>     properties = self._getPropertySetInfo()
>   File
> "/home/julien/lo/libreoffice/instdir/user/uno_packages/cache/uno_packages/
> lu146xeb.tmp_/smtpMailerOOo.oxt/pythonpath/smtpmailer/wizardhandler.py",
> line 383, in _getPropertySetInfo
>     properties['DataSources'] = getProperty('DataSources', '[] string',
> transient)
>   File
> "/home/julien/lo/libreoffice/instdir/user/uno_packages/cache/uno_packages/
> lu146xe6.tmp_/OAuth2OOo.oxt/pythonpath/unolib/unotools.py", line 53, in
> getProperty
>     property.Type = uno.getTypeByName(type)
>   File "/home/julien/lo/libreoffice/instdir/program/uno.py", line 73, in
> getTypeByName
>     return pyuno.getTypeByName(typeName)
> 
> I thought we could use this patch:
> diff --git a/cppu/source/typelib/typelib.cxx
> b/cppu/source/typelib/typelib.cxx
> index 92a7e6ca5120..b9f008365bcf 100644
> --- a/cppu/source/typelib/typelib.cxx
> +++ b/cppu/source/typelib/typelib.cxx
> @@ -1906,6 +1906,7 @@ extern "C" void SAL_CALL
> typelib_typedescription_getByName(
>          if (2 < name.getLength() && '[' == name[ 0 ])
>          {
>              OUString element_name( name.copy( 2 ) );
> +            element_name = element_name.trim();
>              typelib_TypeDescription * element_td = nullptr;
>              typelib_typedescription_getByName( &element_td,
> element_name.pData );
>              if (nullptr != element_td)
> 
> What do you think?

No, such errors should always be fixed on the calling side.  There is a precise grammar for names of UNO type system entities (see <http://www.openoffice.org/udk/common/man/typesystem.html>), and we shouldn't second-guess what calling code actually meant.
Comment 9 prrvchr 2020-04-15 10:03:23 UTC
Hi Julien,

I did the update last night to confirm that the bug 125618 is still present on the latest version.

If I look my package history I find:
libreoffice-common (1:6.3.4-0ubuntu0.18.04.1~lo2) to 1:6.4.2-0ubuntu0.18.04.3

The previous version should be 6.3.4.x and everything was working properly.

Do you have a particular setting to launch LibreOffice, so that it displays as many logs on console?

Thanks
Comment 10 Julien Nabet 2020-04-15 10:09:48 UTC
(In reply to Stephan Bergmann from comment #8)
> ...
> No, such errors should always be fixed on the calling side.  There is a
> precise grammar for names of UNO type system entities (see
> <http://www.openoffice.org/udk/common/man/typesystem.html>), and we
> shouldn't second-guess what calling code actually meant.
Ok then, thank you Stephan for your quick feedback.

prrvchr: so first thing is to change "[] string" to "[]string"
Comment 11 Julien Nabet 2020-04-15 10:13:09 UTC
(In reply to prrvchr from comment #9)
> Hi Julien,
> 
> I did the update last night to confirm that the bug 125618 is still present
> on the latest version.
> 
> If I look my package history I find:
> libreoffice-common (1:6.3.4-0ubuntu0.18.04.1~lo2) to 1:6.4.2-0ubuntu0.18.04.3
> .
> The previous version should be 6.3.4.x and everything was working properly.
Ok so there's something between 6.3.4 and 6.4.2.
However, I wonder how come "[] string" could be ok before...

> Do you have a particular setting to launch LibreOffice, so that it displays
> as many logs on console?

I build LO master sources locally with enable-dbgutil to have max logs.
Comment 12 prrvchr 2020-04-15 10:46:55 UTC
Ok I changed [] string to []string
But what I see is that the handlers are no longer called when a control is initialized (selection modified)
Comment 13 prrvchr 2020-04-15 11:07:43 UTC
Well i'm not also sure about the handler, but the wizard advances on its own, we fall on the last page at the opening ...
Comment 14 prrvchr 2020-04-15 13:25:29 UTC
Ok the handler executes correctly, but the WizardController executes createPage() on all the pages present in the ActivePath without checking by canAdvance() if the wizard can advance...
I also have a serious display problem regarding the size of the Wizard...
Comment 15 Julien Nabet 2020-04-15 13:41:49 UTC
In pythonpath/smtpmailer/dbqueries.py,
I noticed a typo:
# Get DataBase Version Query
    elif name == 'getVerion':
        query = 'Select DISTINCT DATABASE_VERSION() as "HSQL Version" From INFORMATION_SCHEMA.SYSTEM_TABLES'

Shouldn't it be "getVersion" ?
Comment 16 prrvchr 2020-04-15 15:01:11 UTC
hi Julien,

Thanks for the typo, but I think this query is not used any more.
Now I get the version via connection.getMetaData() which has the advantage of being independent of the database version unlike this query.

I just went back to version 6.3.5.2 and I can confirm that the Wizard works well...
Comment 17 Julien Nabet 2020-04-15 15:14:44 UTC
(In reply to prrvchr from comment #16)
> hi Julien,
> 
> Thanks for the typo, but I think this query is not used any more.
> Now I get the version via connection.getMetaData() which has the advantage
> of being independent of the database version unlike this query.
> 
> I just went back to version 6.3.5.2 and I can confirm that the Wizard works
> well...

In this case, just remove it.

Could you provide last steps you tried where it failed?

In //, you may be interested in retrieving LO sources and build LO.
It allows to control precisely the options.
In autogen.input I would include these:
--enable-python=fully-internal
(to be sure it's full compatible with Python used by LO)
and
--enable-dbgutil
(for having max debug info).
Of course, it'll take lots of space (About 30/35Gb) + dependencies.

You may also try daily builds, https://dev-builds.libreoffice.org/daily/master/  but you can't add some extra traces in LO and you still got to manage dependencies.



For the rest, I can't tell.
If I were you, I'd retrieve LO sources and would build LO following:
Comment 18 prrvchr 2020-04-15 15:45:42 UTC
I wish I could build LO, but I think my laptop is too old (512MB Ram, small DD), maybe soon ...

I think I will stay under 6.3.5.2 and wait for the replacement for 6.4.2.2
Comment 19 prrvchr 2020-04-26 14:59:03 UTC
I just did tests under 6.4.3.2, I have the same problems, namely the Wizard which no longer works.
This problem seems to be related to the 6.4.X branch since I no longer have a functional Wizard since this version.
I find this more than worrying ...
Comment 20 Julien Nabet 2020-04-26 15:37:57 UTC
(In reply to prrvchr from comment #19)
> I just did tests under 6.4.3.2, I have the same problems, namely the Wizard
> which no longer works.
> This problem seems to be related to the 6.4.X branch since I no longer have
> a functional Wizard since this version.
> I find this more than worrying ...

A bit early to tell this.

Have you got new oxt with "[]string" + typo fix for "getVersion"?
Still waiting for "last steps you tried where it failed" indicated in my previous comment.
Finally, did you build LO sources?
Comment 21 prrvchr 2020-04-27 07:26:26 UTC
(In reply to Julien Nabet from comment #20)

> Have you got new oxt with "[]string" + typo fix for "getVersion"?

it's done as said in my comment #12

> Still waiting for "last steps you tried where it failed" indicated in my previous comment.

Wizard does not display pages correctly
The Wizard advances alone
The Wizard browser (left part) is only partially visible

> Finally, did you build LO sources?

I would love to, but I can't ...
Comment 22 prrvchr 2020-04-28 14:18:54 UTC
> This problem seems to be related to the 6.4.X branch
> since I no longer have a functional Wizard since this version.

Changes have been made to the wizard with version 6.4.X (new look of the wizard browser) and I think we should review these changes, because it is from these changes that it no longer works
Comment 23 prrvchr 2020-04-30 18:37:48 UTC
(In reply to Julien Nabet from comment #20)

> Still waiting for "last steps you tried where it failed" indicated in my previous comment.

I just had time to redo tests under 6.4.3.2. here is what it stands out:

- When launching the Wizard by XWizard.execute() all pages are created (XWizardController.createPage() is called for all pages of the path)!!! Normally the pages are created as you navigate the wizard and if possible (XWizardPage.canAdvance() and XWizardController.canAdvance() are true)

- If we manage to load the page, it appears as if it was disabled (all controls are grayed out ...) and it is not possible to activate it (XWizard.enablePage() has no effect)

- In addition, the size of the pages is no longer taken into account, the Wizard being displayed with a fixed size.

Voila, I hope this will allow us to move forward...
I will have to reinstall 6.3.x if I want to be able to continue...
Comment 24 prrvchr 2020-05-12 13:26:39 UTC
Hi,
I just did tests with version 7.0.0.0.alpha1, we have the same problem as under 6.4.x, the Wizard service is broken...
Comment 25 Julien Nabet 2020-05-12 13:38:33 UTC Comment hidden (noise)
Comment 26 prrvchr 2020-05-12 16:45:24 UTC Comment hidden (off-topic)
Comment 27 prrvchr 2020-07-30 15:25:44 UTC
Hi,

This problem is solved for me: I rewrote the Wizard service as an interface:

https://github.com/prrvchr/OAuth2OOo/blob/master/python/wizard.py

I even corrected the bugs 132661 and 132666.

On the other hand, I am surprised at your ineffectiveness in resolving a regression that appeared with version 6.4.x and which will surely still be present with version 7.x

From now on, I won't waste time reporting bugs ...

Can't help more here => uncc myself
Comment 28 QA Administrators 2022-07-31 03:28:11 UTC Comment hidden (obsolete)
Comment 29 Stéphane Guillou (stragu) 2023-02-17 21:24:36 UTC
This can be tested by installing a version of the OAuth2OOo extension prior to the custom wizard was added to it: https://github.com/prrvchr/OAuth2OOo/releases/tag/v0.0.4
Then going to Tools > Options > Internet > OAuth2 protocol > OAuth2 wizard.

Repro:

Version: 6.4.7.2
Build ID: 639b8ac485750d5696d7590a72ef1b496725cfb5
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3; 
Locale: en-AU (en_AU.UTF-8); UI-Language: en-US
Calc: threaded

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: b52117c0be97c45824d2897657084f8ac7e9bf42
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

No repro:

Version: 6.3.6.2
Build ID: 2196df99b074d8a661f4036fca8fa0cbfa33a497
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3; 
Locale: en-AU (en_AU.UTF-8); UI-Language: en-US
Calc: threaded
Comment 30 Stéphane Guillou (stragu) 2023-02-17 21:45:32 UTC
Bibisected with linux-64-6.4 repo to first bad commit 425f162ab1ecf661392aead48995fb58583e4b85 which points to core commit:

commit 910b8b04325e0103941b6c6d152e4ee5f0388fc2
author	Caolán McNamara <caolanm@redhat.com>	Sun Sep 15 17:42:39 2019 +0100
committer	Caolán McNamara <caolanm@redhat.com>	Fri Sep 20 21:24:06 2019 +0200
tree 6e6422b6482f85c67b32b3f304db220eb78fadf7
parent ca7c24dafe7aba7c2d71994d2561f1ae3d59257e

make WizardShell use RoadmapWizardMachine

Change-Id: Id7e1e163f17cd4866c37bbd6cad73b8c721f4dae
Reviewed-on: https://gerrit.libreoffice.org/78969

Caolán, what are your thoughts?
Comment 31 Commit Notification 2023-02-20 21:02:01 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/cdf7b51229f2353376fb4e9de309fb9ee5580b3a

tdf#132110 page ids might not be state ids

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 32 Commit Notification 2023-02-21 11:44:39 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/e7dd0fa490c671267a4419a6c2ef8a1367114209

tdf#132110 page ids might not be state ids

It will be available in 7.5.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 33 Commit Notification 2023-02-21 11:55:42 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/9c978e4c75e342b2345ff4fcbd1b5751627d8baf

Related: tdf#132110 use the container child size as default size

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 34 Caolán McNamara 2023-02-21 11:59:17 UTC
That fixes the steps of the wizard and the size of the wizard. Seems to be ok in trunk now, backports to 7-5 in gerrit. Won't backport to earlier.
Comment 35 Commit Notification 2023-02-21 13:28:56 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b428a97d88b08fadd63039482c09c17a5fbac3be

Related: tdf#152508 and tdf#132110 use initial child size as size request

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 36 Commit Notification 2023-03-09 12:43:03 UTC
Ilhan Yesil committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/f933248c042e6fa8ed29daf19fd8bba47a5cc3d6

Related: tdf#132110 use the container child size as default size

It will be available in 7.5.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 37 prrvchr 2023-07-26 11:37:05 UTC
I don't want to discourage you, but for me the Wizard is still unusable.

I produced a test case see issue 132666: https://bugs.documentfoundation.org/show_bug.cgi?id=132666