Bug 132125 - Pasting text into comments does not work
Summary: Pasting text into comments does not work
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice Online
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.1.0
Keywords:
: 133400 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-04-15 15:19 UTC by audiophil
Modified: 2020-08-17 15:04 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description audiophil 2020-04-15 15:19:17 UTC
If I paste text into comments the text gets pasted into the document instead.

As the same happens when pasting into the hyperlink popup it seems to be related to Bug 117050.
Comment 1 Aron Budea 2020-04-22 16:58:58 UTC
Indeed, I can confirm the bug, and it affects Writer, Calc and Impress as well.

(In reply to audiophil from comment #0)
> As the same happens when pasting into the hyperlink popup it seems to be
> related to Bug 117050.
Note that I found no issue when pasting into the hyperlink dialog.
Comment 2 Max M. 2020-04-25 08:33:28 UTC
This seems like a bug that was fixed for the hyperlink dialog previously (see: https://bugs.documentfoundation.org/show_bug.cgi?id=117050), but with the difference that copying out of comments' text fields seems to work.
Comment 3 Commit Notification 2020-05-01 12:11:33 UTC
Aron Budea committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/online/commit/9baea8eb9b32e7554a5c81af10eb5e354b6da1d8

tdf#132125: Pasting into comment pastes into document instead
Comment 4 Aron Budea 2020-05-01 12:16:17 UTC
This is now fixed, the bug and the fix was similar to what's mentioned in bug 117050 comment 13.

The fix will also come as part of the next update of Collabora Online/CODE.
Comment 5 Commit Notification 2020-05-04 23:10:49 UTC
Aron Budea committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/online/commit/d85426df88231b2dba012a645cb1ec7cee3efffc

Revert "tdf#132125: Pasting into comment pastes...
Comment 6 Aron Budea 2020-05-04 23:12:26 UTC
Actually, the fix has to be refined still.
Comment 7 Aron Budea 2020-06-01 04:32:37 UTC
*** Bug 133400 has been marked as a duplicate of this bug. ***
Comment 8 Commit Notification 2020-07-27 22:35:45 UTC
Pranam Lashkari committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/online/commit/eb36adcdf8e77691afc20bf9a01870499671f350

tdf#132125: leaflet: Pasting text into comments pastes into the document instead
Comment 9 Commit Notification 2020-07-27 22:39:56 UTC
Pranam Lashkari committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/online/commit/87d9769187a2f39ee1044199e8c195c6e38ee4a4

tdf#132125 leaflet: setting annotations active and inactive on focus
Comment 10 Aron Budea 2020-08-17 15:04:31 UTC
This should be fine now, thanks to Pranam Lashkari for fixing this!