Bug 132179 - Improve accessibility for the About dialog
Summary: Improve accessibility for the About dialog
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.0.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Heiko Tietze
URL:
Whiteboard: target:7.0.0
Keywords:
Depends on:
Blocks: About-Dialog
  Show dependency tree / graph
 
Reported: 2020-04-17 09:53 UTC by Heiko Tietze
Modified: 2020-05-04 08:26 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Heiko Tietze 2020-04-17 09:53:24 UTC 
Tabbing into the static text lacks on visual indication (bug 127148) but is bad UX anyway. So we should introduce a button to copy the version info.
Comment 1 Commit Notification 2020-04-20 12:28:10 UTC 
Heiko Tietze committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/d2323f3df20e77a1b1245783fac077b49456732d

Resolves tdf#132179 - Improve accessibility for the About dialog

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 2 Julien Nabet 2020-04-20 15:06:16 UTC 
What does this button do?
On pc Debian x86-64 with master sources updated today, I clicked on the button then I pasted on gedit thinking it was copying version info in clipboard, it's not the case.
Comment 3 Heiko Tietze 2020-04-20 16:14:58 UTC 
(In reply to Julien Nabet from comment #2)
> What does this button do?

It does for me. Can you please double-check.
Comment 4 Mike Kaganski 2020-04-20 16:16:28 UTC 
(In reply to Heiko Tietze from comment #3)
> (In reply to Julien Nabet from comment #2)
> > What does this button do?
> 
> It does for me. Can you please double-check.

And for me. This is copied with the button:
Version: 7.0.0.0.alpha0+ (x64)
Build ID: 1e906559ac0d10dae59a368d4c185bd6d5088a07
CPU threads: 12; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win; 
Locale: en-US (ru_RU); UI-Language: en-US
Calc: CL
Comment 5 Julien Nabet 2020-04-20 16:34:27 UTC 
Indeed!
I had tested middle click but I should have use Ctrl-V which works.

Just for the record when opening about dialog, I see this on console:

warn:svgio:80776:80776:svgio/source/svgreader/svgdocumenthandler.cxx:408: Unknown Base SvgToken <metadata> (!)
warn:svgio:80776:80776:svgio/source/svgreader/svgdocumenthandler.cxx:408: Unknown Base SvgToken <rdf:RDF> (!)
warn:svgio:80776:80776:svgio/source/svgreader/svgdocumenthandler.cxx:408: Unknown Base SvgToken <cc:Work> (!)
warn:svgio:80776:80776:svgio/source/svgreader/svgdocumenthandler.cxx:408: Unknown Base SvgToken <dc:format> (!)
warn:svgio:80776:80776:svgio/source/svgreader/svgdocumenthandler.cxx:408: Unknown Base SvgToken <dc:type> (!)
warn:svgio:80776:80776:svgio/source/svgreader/svgdocumenthandler.cxx:408: Unknown Base SvgToken <dc:title> (!)
warn:svgio:80776:80776:svgio/source/svgreader/svgdocumenthandler.cxx:408: Unknown Base SvgToken <sodipodi:namedview> (!)
warn:svgio:80776:80776:svgio/source/svgreader/svgdocumenthandler.cxx:408: Unknown Base SvgToken <filter> (!)
warn:svgio:80776:80776:svgio/source/svgreader/svgdocumenthandler.cxx:408: Unknown Base SvgToken <feGaussianBlur> (!)
warn:svgio:80776:80776:svgio/source/svgreader/svgdocumenthandler.cxx:408: Unknown Base SvgToken <filter> (!)
warn:svgio:80776:80776:svgio/source/svgreader/svgdocumenthandler.cxx:408: Unknown Base SvgToken <feGaussianBlur> (!)
warn:svgio:80776:80776:svgio/source/svgreader/svgdocumenthandler.cxx:408: Unknown Base SvgToken <filter> (!)
warn:svgio:80776:80776:svgio/source/svgreader/svgdocumenthandler.cxx:408: Unknown Base SvgToken <feGaussianBlur> (!)
warn:svgio:80776:80776:svgio/source/svgreader/svgdocumenthandler.cxx:408: Unknown Base SvgToken <filter> (!)
warn:svgio:80776:80776:svgio/source/svgreader/svgdocumenthandler.cxx:408: Unknown Base SvgToken <feGaussianBlur> (!)
warn:svgio:80776:80776:svgio/source/svgreader/svgdocumenthandler.cxx:408: Unknown Base SvgToken <sodipodi:namedview> (!)
warn:svgio:80776:80776:svgio/source/svgreader/svgdocumenthandler.cxx:408: Unknown Base SvgToken <metadata> (!)
warn:svgio:80776:80776:svgio/source/svgreader/svgdocumenthandler.cxx:408: Unknown Base SvgToken <rdf:RDF> (!)
warn:svgio:80776:80776:svgio/source/svgreader/svgdocumenthandler.cxx:408: Unknown Base SvgToken <cc:Work> (!)
warn:svgio:80776:80776:svgio/source/svgreader/svgdocumenthandler.cxx:408: Unknown Base SvgToken <dc:format> (!)
warn:svgio:80776:80776:svgio/source/svgreader/svgdocumenthandler.cxx:408: Unknown Base SvgToken <dc:type> (!)
warn:svgio:80776:80776:svgio/source/svgreader/svgdocumenthandler.cxx:408: Unknown Base SvgToken <dc:title> (!)
warn:svgio:80776:80776:svgio/source/svgreader/svgdocumenthandler.cxx:408: Unknown Base SvgToken <dc:creator> (!)
warn:svgio:80776:80776:svgio/source/svgreader/svgdocumenthandler.cxx:408: Unknown Base SvgToken <cc:Agent> (!)
warn:svgio:80776:80776:svgio/source/svgreader/svgdocumenthandler.cxx:408: Unknown Base SvgToken <dc:title> (!)
warn:svgio:80776:80776:svgio/source/svgreader/svgdocumenthandler.cxx:408: Unknown Base SvgToken <dc:publisher> (!)
warn:svgio:80776:80776:svgio/source/svgreader/svgdocumenthandler.cxx:408: Unknown Base SvgToken <cc:Agent> (!)
warn:svgio:80776:80776:svgio/source/svgreader/svgdocumenthandler.cxx:408: Unknown Base SvgToken <dc:title> (!)
warn:svgio:80776:80776:svgio/source/svgreader/svgdocumenthandler.cxx:408: Unknown Base SvgToken <dc:description> (!)
warn:svgio:80776:80776:svgio/source/svgreader/svgdocumenthandler.cxx:408: Unknown Base SvgToken <cc:license> (!)
warn:svgio:80776:80776:svgio/source/svgreader/svgdocumenthandler.cxx:408: Unknown Base SvgToken <cc:License> (!)
warn:svgio:80776:80776:svgio/source/svgreader/svgdocumenthandler.cxx:408: Unknown Base SvgToken <cc:permits> (!)
warn:svgio:80776:80776:svgio/source/svgreader/svgdocumenthandler.cxx:408: Unknown Base SvgToken <cc:permits> (!)
warn:svgio:80776:80776:svgio/source/svgreader/svgdocumenthandler.cxx:408: Unknown Base SvgToken <cc:requires> (!)
warn:svgio:80776:80776:svgio/source/svgreader/svgdocumenthandler.cxx:408: Unknown Base SvgToken <cc:requires> (!)
warn:svgio:80776:80776:svgio/source/svgreader/svgdocumenthandler.cxx:408: Unknown Base SvgToken <cc:permits> (!)

but that's another story.
Comment 6 Heiko Tietze 2020-04-20 16:43:04 UTC 
(In reply to Julien Nabet from comment #5)
> warn:svgio:80776:80776:svgio/source/svgreader/svgdocumenthandler.cxx:408:

Could manually remove some lines (run the SVG through svgio) but on the long term it's up to the SVG processor.
Comment 7 Heiko Tietze 2020-05-04 08:26:32 UTC 
(In reply to Julien Nabet from comment #5)
> Just for the record when opening about dialog, I see this on console:
> 
> warn:svgio:80776:80776:svgio/source/svgreader/svgdocumenthandler.cxx:408:
> Unknown Base SvgToken <metadata> (!)

Solved with bug 132513.