Bug 132352 - "Show all updates" tickbox in extension manager not working as expected
Summary: "Show all updates" tickbox in extension manager not working as expected
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Extensions (show other bugs)
Version:
(earliest affected)
6.4.3.2 release
Hardware: x86-64 (AMD64) Linux (All)
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: Extension-Manager
  Show dependency treegraph
 
Reported: 2020-04-23 12:52 UTC by Callegar
Modified: 2022-09-11 03:42 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Callegar 2020-04-23 12:52:13 UTC
Description:
In the extension manager, pressing the check for updates button provides an "extension update" window listing the extensions that can be updated.

Here there is also a "Show all updates" tick box whose role is not really clear (pressing help in the extension update window does not bring up anything relevant to the window items, incidentally).

In any case, ticking the tick box causes the available extension updates panel to deliver erratic content, which is most certainly not the intended action. For instance, right now I get:

TeXMaths 0.48.2 

without the tick and 

TeXMaths 0.48.2
Zotero Libreoffice Integration

with the tick, but there is really no Zotero Libreoffice Integration update available. Furthermore, clicking Zotero Libreoffice Integration ends up with the following text being displayed in the description panel:

An error occurred:
Document is empty
Line: 1
Column: 1

This behavior is certainly evident in LibO 6.4.3.2, but in my memory has really been happening forever.

If the "Show all updates" tickbox is a left over from OpenOffice or very old versions of Libreoffice and is not meant to be used anymore as I suspect, please consider removing it.

Steps to Reproduce:
- Tools -> Extension Manager
- Press Check For Updates
- Tick show all updates button in the Avalilable Extension Updates window.
- Check that there is really an update for all the extensions being listed.
- Click on an extension for which an update is actually not available.

Actual Results:
With the Show all updates tick, extensions are listed for which there are really no updates. If you click on one of them, you get an error text in the description panel.

Expected Results:
Hard to say, because the role of the "Show all updates" tick box is really not documented.

Surely, there should be no extension listed for which there is really no update and most important the action should not trigger errors in the description panel.


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.4.3.2
Build ID: 747b5d0ebf89f41c860ec2a39efd7cb15b54f2d8
CPU threads: 8; OS: Linux 5.3; UI render: default; VCL: kf5; 
Locale: it-IT (en_US.UTF-8); UI-Language: en-US
Calc: threaded
Comment 1 Jean-Baptiste Faure 2020-04-26 16:40:28 UTC
"Show all updates" tick box is explained in the result panel :
No installable updates are available. To see ignored or disabled updates, mark the check box 'Show all updates'.

Ignored or disabled updates give me errors. I guess it is why they are disabled.

I do not see any bug here.

Best regards. JBF
Comment 2 Callegar 2020-04-26 16:56:20 UTC
In my case the entries being shown are neither ignored nor disabled updates.
The packages that get listed had already been updated to their newest release and nowhere in the development sites of these packages other releases (that could have been disabled or set to be ignored) are mentioned.

Hence, at best these may be entries related to spurious updates to LibO extension database, i.e. the database used by LibO to deliver its extension update notices.

If this is the case, the thing seems to be related to a highly internal technical detail, and I do not see why it gets exposed to the average user. If this information is useful to extension developers, I suggest providing a macro for them to call.

Thus, unless it has some more interesting purpose, I suggest that the tickbox could be removed. Unless I am missing something, it is just an unnecessary and confusing item in the UI.
Comment 3 Buovjaga 2020-08-31 17:56:24 UTC
(In reply to sergio.callegari from comment #2)
> In my case the entries being shown are neither ignored nor disabled updates.
> The packages that get listed had already been updated to their newest
> release and nowhere in the development sites of these packages other
> releases (that could have been disabled or set to be ignored) are mentioned.
> 
> Hence, at best these may be entries related to spurious updates to LibO
> extension database, i.e. the database used by LibO to deliver its extension
> update notices.
> 
> If this is the case, the thing seems to be related to a highly internal
> technical detail, and I do not see why it gets exposed to the average user.
> If this information is useful to extension developers, I suggest providing a
> macro for them to call.
> 
> Thus, unless it has some more interesting purpose, I suggest that the
> tickbox could be removed. Unless I am missing something, it is just an
> unnecessary and confusing item in the UI.

Let's ping UX team
Comment 4 Heiko Tietze 2020-09-01 10:55:09 UTC
You can disable extensions and keep it installed but not active. Those disabled extensions are not updated by default, for what reason ever. The same is true for extensions with kind=DISABLED_UPDATE, which seems to be set when dependencies are not met.
If we consider to remove the "Show All" checkbox we should also talk about the enable/disable feature. Quite much changes for just a small irritation. Do we show the all updates or only the limited list, meaning checkbox on or off? In case something is not listed where you are sure it has an update available would confuse you likewise the opposite. Renaming the checkbox to "Show non-applicable updates"?
Comment 5 Cor Nouws 2020-09-08 20:14:59 UTC
(In reply to Heiko Tietze from comment #4)
> ..... Renaming the checkbox to
> "Show non-applicable updates"?
Sounds like a good puzzle.

Apart from that: may well be that the option is used in larger (enterprise) deployments? So unless we are really sure, I would not touch. Indeed, as you say, for a minor annoyance..
Comment 6 Callegar 2020-09-09 08:14:50 UTC
As the original reporter of the bug:

my issue is not with the presence of the "show all updates" button that makes sense and that I would not touch. My issue is what happens /after/ you press that button.

In my case, the system invariably:

1. shows a list of extensions (typically Zotero and TeXmaths) that are /not/ disabled on my system
2. manual checks reveal that these extensions /are/ at the latest release, so there cannot be anything to update about them
3. for these extensions the description field rather than providing a description shows an error message. This is typically something like "An error occurred: Document is empty Line: 1 Column: 1"

Hence, my bug report, that goes with this questions:

- Why the "show all updates" show extensions that are not disabled and not update-able being already at the latest release? Shouldn't it show something just in case there are extensions that are disabled or otherwise not set for automatic updates?

- Why is there no description in the description field? Should one not recognize the extension by name, how is the description field useful in helping him/her? Being that the extension is actually installed and that the description is shown in the extension list pane, why cannot it be retrieved at this point?

- Why the error "document is empty"?

My guess is that when LibO interrogates the extension database at LibO something goes wrong for some reason. Either LibO misinterprets some records or the database contains some wrong or stale records. This causes LibO to see in the database some extension releases for which it cannot properly read data. Because of these, LibO chooses to consider these as "releases to ignore"... and these get shown in the "show all updates" panel.

It is this last part that should not happen. If LibO fails to understand some records that should be fixed or if the upstream extension database has incorrect entries of records those should be fixed. Otherwise, the behavior is just rather confusing.

What I expect from "show all extensions" is to show:

- If there are updates to extensions that I have manually disabled (maybe precisely because they have issue, but I have an interest in checking if updated versions exist that may fix the issue);

- If for some extensions there are updates that have been marked by the developer as to be ignored for automatic updates (e.g. because of a beta or pre-release status).
Comment 7 Heiko Tietze 2020-09-10 13:00:02 UTC
I don't see the point of showing extensions that can't be updated in the list. Neither a switch to show them. But since Sergio has no issue with the UI or the workflow I leave the questions to QA, whether or not it is a bug.
Comment 8 Callegar 2020-09-10 13:47:38 UTC
I think that as long as it is done correctly, the ability to show extensions for which updates are available, but updating is disabled can be useful. I think of two main use cases:

1) I have disabled extension "A" because of a bug, so updates for "A" are not directly shown. However, I want to know if updates are available at all, since they may fix the bug;

2) A nice feature of some software repos is that developers can mark release as "pre-releases". These pre-releases are never selected for updates. However, the possibility is left to the user to see if they exist. (For instance fdroid does so with android software). I do not know if for LibO there is any provision in this sense.
Comment 9 QA Administrators 2022-09-11 03:42:25 UTC
Dear sergio.callegari,

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
 
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug