> Sub TestReplace > n=100000 > s=Space(n) > t=GetSystemTicks > s=Replace(s, " ", "*",1,-1,1) > Msgbox "time=" & (GetSystemTicks-t) > End Sub This code runs about 7 s on my system, and time increases as O(n^2). It must run instantly.
https://gerrit.libreoffice.org/c/core/+/92884
Mike Kaganski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/dd06a8a2caf93707fbf29c7264cf41f8ec9d4c6d tdf#132388: reimplement SbRtl_Replace It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
time=26 in Version: 7.0.0.0.alpha0+ Build ID: 4ba1909f12b49f020195b5e767045340717ce6df CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: x11; Locale: en-US (en_US.UTF-8); UI-Language: en-US Calc: threaded @Mike Kaganski, thanks for fixing this issue!
time=86010 in Version 4.1.0.0.alpha0+ (Build ID: efca6f15609322f62a35619619a6d5fe5c9bd5a)
Should we reopen this one because of Bug 142487? Is there a possibility to add performance checks to LO to prevent regressions like the "normal" macro tests?
(In reply to Andreas Heinisch from comment #5) > Should we reopen this one because of Bug 142487? Is there a possibility to > add performance checks to LO to prevent regressions like the "normal" macro > tests? I suppose a separate report is better, with the two bugs are See Also. The problem is the repeated calls to TextSearch::searchForward, which takes the search string, and internally calls the transliteration for each call. That does multiple allocations, putting the performance to the knees. I suggest to introduce a XTextSearch3 interface that would allow to set the searched string (in addition to search substring) once, and then call search repeatedly, without passing the string. Or maybe instead of adding the interface, cache the processed string in the class, and re-use it when the passed searched string is the same. But that is all for another issue :-)
(In reply to Mike Kaganski from comment #6) Or better put the caching into TransliterationImpl, which would reset the cache on changing its properties (e.g., loading modules), and thus the optimization would be available for all transliteration users automatically.
Mike Kaganski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/a03b7d2a8d0f0fd7e710202bbeecf165f0fcd06a tdf#132388: reimplement fix for tdf#142487 It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Mike Kaganski committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/81a3d9b4bf471158de00d2fbb63fca420da94a38 tdf#132388: add unit test It will be available in 7.4.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Mike Kaganski committed a patch related to this issue. It has been pushed to "libreoffice-7-3": https://git.libreoffice.org/core/commit/8efa3dd53aaf98ed258c9f340800504c9e874b78 tdf#132388: reimplement fix for tdf#142487 It will be available in 7.3.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Mike Kaganski committed a patch related to this issue. It has been pushed to "libreoffice-7-3": https://git.libreoffice.org/core/commit/79c7f4378ec38c0e153032cccb437a665b318045 tdf#132388: add unit test It will be available in 7.3.1. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Mike Kaganski committed a patch related to this issue. It has been pushed to "libreoffice-7-2": https://git.libreoffice.org/core/commit/3fa7c7618500bf5914e19cb3714f301f7bff305a tdf#132388: reimplement fix for tdf#142487 It will be available in 7.2.6. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.