Bug 132479 - "Equal Triangle" should be renamed to "Equilateral Triangle"
Summary: "Equal Triangle" should be renamed to "Equilateral Triangle"
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.0.0.0.alpha0+
Hardware: All All
: medium minor
Assignee: Ming Hua
URL:
Whiteboard: target:7.1.0
Keywords: difficultyBeginner, easyHack, skillDesign, topicDesign
Depends on:
Blocks:
 
Reported: 2020-04-28 02:33 UTC by Ming Hua
Modified: 2020-11-05 05:45 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Ming Hua 2020-04-28 02:33:29 UTC
In file /core/officecfg/registry/data/org/openoffice/Office/UI/Effects.xcu, line 755, among a lot of names of shapes, there is: <value xml:lang="en-US">Equal Triangle</value>
(https://opengrok.libreoffice.org/xref/core/officecfg/registry/data/org/openoffice/Office/UI/Effects.xcu?r=d86cfcaf#755)

As two other translators have pointed out (https://translations.documentfoundation.org/translate/libo_ui-master/officecfgregistrydataorgopenofficeofficeui/zh_Hans/?q=has:comment#comments), "equal triangle" is not the correct term, triangles with all three sides of equal length are called "equilateral triangle" or "regular triangle".
Comment 1 Julien Nabet 2020-04-28 13:44:06 UTC
Regina: I agree with Ming Hua but perhaps the ODF standard or something else could prevent us from fixing this. Any thoughts?

Xisco/Heiko: no UX or UI pb with this?
Comment 2 Heiko Tietze 2020-04-28 16:03:15 UTC
Roman, one for you?
Comment 3 Regina Henschel 2020-04-28 16:14:57 UTC
(In reply to Julien Nabet from comment #1)
> Regina: I agree with Ming Hua but perhaps the ODF standard or something else
> could prevent us from fixing this. Any thoughts?

The text "equal triangle" is a pure UI string for en-US. The associated text in core is "ooo-motionpath-equal-triangle", which you see in line #753. So no problem in using a different string, besides the fact, that changing a UI string will trigger a lot a translation changes.

Besides that, the string "equilateral triangle" would be false in content. The path definition has width 0.25, hight 0.2878. That is scaled (I don't see were) to width and height of about 60mm. Therefore term would be "isosceles triangle". For an "equilateral triangle" you need height=√(0.75)*width.
Comment 4 Ming Hua 2020-04-28 18:24:24 UTC
Thanks for looking into this, Regina.

(In reply to Regina Henschel from comment #3)
> Besides that, the string "equilateral triangle" would be false in content.
> The path definition has width 0.25, hight 0.2878. That is scaled (I don't
> see were) to width and height of about 60mm. Therefore term would be
> "isosceles triangle". For an "equilateral triangle" you need
> height=√(0.75)*width.
But "isosceles triangle" has the problem of representing a large range of triangles with distinctively different shapes.  The isosceles triangle with equal height and width is "triangle that fits inside a square", but I doubt many (if any) languages have a concise term for it.
Comment 5 Heiko Tietze 2020-04-30 13:20:57 UTC
(In reply to Ming Hua from comment #4)
> I doubt many (if any) languages have a concise term for it.

German has well-known terms and I guess it's the same on other languages. However, it sounds overly precise and "regular triangle" could work too.

isosceles => rectangle, equilateral => square/circle
Comment 6 Ming Hua 2020-11-04 18:56:12 UTC
Let's get this string changed before 7.1.

I submitted a patch to Gerrit:
https://gerrit.libreoffice.org/c/core/+/105223

I used "Regular Triangle".  If anyone come up with a better name for this "isosceles triangle with equal height and width" thing, it's always easy to change it again.
Comment 7 Commit Notification 2020-11-05 04:48:41 UTC
Ming Hua committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/83b73e8c885bf74b1f06e405f671dd4768fe1005

Resolves tdf#132479: Rename "equal triangle" to "regular triangle"

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.