Description: In ODBC history, there's been different functions and some have been deprecated ODBC 3.0 has been released in 1995. See https://docs.microsoft.com/fr-fr/SQL/odbc/reference/appendixes/mapping-deprecated-functions?view=sql-server-2017. Some functions are not declared too. Here is a code pointer: https://opengrok.libreoffice.org/xref/core/connectivity/source/drivers/odbc/OFunctions.cxx?r=11785217 Steps to Reproduce: N/A Actual Results: N/A Expected Results: N/A Reproducible: Always User Profile Reset: No Additional Info: N/A
Lionel: I began to try to remove SQLFreeStmt and noticed variable "ODBCVER" extract when grepping ODBCVER: external/unixODBC/inc/odbc/sqlext.h:1758:#if (ODBCVER >= 0x0300) external/unixODBC/inc/odbc/sqlext.h:1766:#endif /* ODBCVER >= 0x0300 */ external/unixODBC/inc/odbc/sqlext.h:1823:#if (ODBCVER >= 0x0300) external/unixODBC/inc/odbc/sqlext.h:1827:#endif /* ODBCVER >= 0x0300 */ external/unixODBC/inc/odbc/sqlext.h:1990:#if (ODBCVER >= 0x0300) external/unixODBC/inc/odbc/sqltypes.h:23: * default to the 3.51 definitions. should define ODBCVER before here if you want an older set of defines external/unixODBC/inc/odbc/sqltypes.h:25:#ifndef ODBCVER external/unixODBC/inc/odbc/sqltypes.h:26:#define ODBCVER 0x0351 See https://opengrok.libreoffice.org/search?project=core&full=ODBCVER&defs=&refs=&path=&hist=&type=&si=full Do you think we may consider that ODBCVER = 0x351 or at least remove everything which consider that ODBCVER < 0x351 ? More generally, do you think we should follow a specific order?
I should have read twice, only SQLFreeStmt with an Option of SQL_DROP is deprecated.
Here are functions not declared or not completely used at least: SQLCancelHandle SQLCopyDesc SQLGetDescField SQLGetDiagField SQLSetDescField SQLSetDescRec SQLSetScrollOptions
This was discussed on mailing list, setting to NEW
Julien Nabet committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/55133fc5fc499f6266f75ad3df77106f12333201 tdf#132499: first stab to remove old stuff from ODBC ver < 3 It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
As indicated in gerrit, it's just a first step.
Julien Nabet committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/0464b86787da269be7b16a6f1f124d774f78fa97 tdf#132499: consider ODBCVER >= 0x0300 and remove tests about it (unixODBC) It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Julien Nabet committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/88982b04ae2c451a5af62f7fc6c9502414590f92 Revert "tdf#132499: consider ODBCVER >= 0x0300 and remove tests about it (unixODBC)" It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Julien Nabet committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/a11425579127502f4ee0972cc9fef09894e64a0d Revert "tdf#132499: first stab to remove old stuff from ODBC ver < 3" It will be available in 7.3.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Following comments in gerrit patches, it should be done upstream. Let's put this one as WONTFIX then.