Bug 132540 - Sidebar toolbar dropdown buttons open an extra small dropdown
Summary: Sidebar toolbar dropdown buttons open an extra small dropdown
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.0.0.0.alpha0+
Hardware: All Linux (All)
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.0.0 target:7.1.0 target:7.0.0.1
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2020-04-30 00:38 UTC by Aron Budea
Modified: 2020-06-16 15:15 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Pre-screenshot with sample window size for repro (80.84 KB, image/png)
2020-04-30 00:38 UTC, Aron Budea
Details
Screencast (78.88 KB, video/mp4)
2020-04-30 12:00 UTC, Aron Budea
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Aron Budea 2020-04-30 00:38:22 UTC
Created attachment 160104 [details]
Pre-screenshot with sample window size for repro

This is easiest to see when reducing the window height so it ends a bit below the Character sidebar deck in Writer (see attached screenshot).
Align the window with near the bottom of the screen, so the color picker on the deck opens upwards.
Click on one of the color pickers on the sidebar.

=> Apart from the normal dropdown (which opens upwards now), there's a small, empty dropdown as well.
The small dropdown is shown when the dropdown opens downwards as well, just mostly obscured.

I can't take a screenshot with a dropdown open, the attached screenshot shows an example of the size at which the dropdown opens upwards.

This is a regression from the following commit. Adding CC: to Caolán McNamara.
https://cgit.freedesktop.org/libreoffice/core/commit/?id=850b8de31c5be5127eac16a4f5cc18c26a582e53
author		Caolán McNamara <caolanm@redhat.com>	2020-04-19 20:36:17 +0100
committer	Caolán McNamara <caolanm@redhat.com>	2020-04-21 11:52:58 +0200

weld sidebar text panel
Comment 1 V Stuart Foote 2020-04-30 02:57:10 UTC
@Aaron, sorry going to need some screen clips (do a full desktop <Shift>+<PrtSc> and crop).

Anyhow on Windows builds 64-bit TB77 2020-04-28 not seeing any issue with the sizing of the dropdown widgets on the Sidebar decks.

Version: 7.0.0.0.alpha0+ (x64)
Build ID: 7459b9ecb54a298f02d19089620149718f8d8d48
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Vulkan; VCL: win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded
Comment 2 Aron Budea 2020-04-30 12:00:19 UTC
Right, I made a mistake by not specifying the OS, this is Linux-specific. It's literally not possible to take a screenshot with the popup open... I can take a screencast, though.
Comment 3 Aron Budea 2020-04-30 12:00:43 UTC
Created attachment 160124 [details]
Screencast
Comment 4 Caolán McNamara 2020-04-30 18:30:19 UTC
The little dropdown is a side effect from a workaround of the problem under X that a GtkPopover would be constrained to their parent toplevel. e.g. https://bugzilla.gnome.org/show_bug.cgi?id=729644 and others.
Comment 5 Commit Notification 2020-05-01 07:29:01 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b3a548a1b3155abad5f134955a6bda8ec133b032

Related: tdf#132540 keep placeholder popover on same side as menu

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Commit Notification 2020-05-01 07:30:39 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/3b44e585c9e9fb949cea5cda9fc19cdb27edbf65

tdf#132540 and tdf#132338 align popover replacement with complete toolitem

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Caolán McNamara 2020-05-01 13:50:32 UTC
I wonder if those together are enough to consider this fixed
Comment 8 Commit Notification 2020-06-09 20:19:36 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/dbf3eba5514f0ed48683e2b58ac56c96b6d48792

Resolves: tdf#132540 theme the unwanted popover into invisibility

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2020-06-09 20:19:46 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/181587f3a3f8d05f1a3c82eaa0a8838db0096358

Resolves: tdf#132540 theme the unwanted popover into invisibility

It will be available in 7.0.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Xisco Faulí 2020-06-16 15:15:50 UTC
Verified in

Version: 7.1.0.0.alpha0+
Build ID: 11d21b3c1f7754b5d13ae9ea88da562ec74366ff
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

@Caolán, thanks for fixing this issue!