Bug 132604 - Assertion when inserting an image in Writer (gtk3)
Summary: Assertion when inserting an image in Writer (gtk3)
Status: CLOSED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.0.0.0.alpha0+
Hardware: x86-64 (AMD64) Linux (All)
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.0.0
Keywords: haveBacktrace
Depends on:
Blocks: Crash-Assert
  Show dependency tree / graph
 
Reported: 2020-05-01 22:10 UTC by Julien Nabet
Modified: 2020-05-02 20:12 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:

Attachments
bt with debug symbols (gtk3) (13.89 KB, text/plain)
2020-05-01 22:11 UTC, Julien Nabet 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Julien Nabet 2020-05-01 22:10:21 UTC 
Description:
On pc Debian x86-64 with master sources + enable-dbgutil + gtk3, I got an assert when inserting an image in Writer.

Steps to Reproduce:
1. Launch Writer
2. Menu Insert/Image
3. Choose Image then click "Open"

Actual Results:
Assertion

Expected Results:
No assertion


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.0.0.0.alpha0+
Build ID: 3b46fa70b2b7f91a9a7c05bf54293e761d7df161
CPU threads: 12; OS: Linux 5.5; UI render: default; VCL: gtk3; 
Locale: fr-FR (fr_FR.UTF-8); UI-Language: en-US
Calc: threaded
Comment 1 Julien Nabet 2020-05-01 22:11:04 UTC 
Created attachment 160205 [details]
bt with debug symbols (gtk3)
Comment 2 Julien Nabet 2020-05-01 22:11:57 UTC 
Caolán: thought you might be interested in this one since it's specific to gtk3.
Comment 3 Aron Budea 2020-05-01 22:56:21 UTC 
Confirmed with LO 7.0.0.0.alpha0+ (60fcd4427231e8c48cd3bf8307e280fd3a13a84f) / Ubuntu.
Comment 4 Caolán McNamara 2020-05-02 16:38:52 UTC 
means the thing toggled should have been a GtkToggleToolButton instead of a GtkToolButton
Comment 5 Commit Notification 2020-05-02 18:16:59 UTC 
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/0db6e58fd4273e2a4f6992fe719f965464dadece

Resolves: tdf#132604 GtkToolButtons that should be GtkToggleToolButtons

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Julien Nabet 2020-05-02 20:12:02 UTC 
With master sources updated after patch, I don't reproduce this.

Thank you Caolán!