Bug 132816 - Slide "master" option buttons are not updated in tabbed ui
Summary: Slide "master" option buttons are not updated in tabbed ui
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
7.0.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.1.0
Keywords:
: 118364 (view as bug list)
Depends on:
Blocks: Sidebar-Master-Slides Notebookbar-Tabbed
  Show dependency treegraph
 
Reported: 2020-05-07 14:08 UTC by Pierre Marty
Modified: 2023-08-18 05:08 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Video demonstration (2.63 MB, video/mp4)
2020-05-07 16:19 UTC, Pierre Marty
Details
Patch 1 (45 bytes, patch)
2020-05-20 13:16 UTC, Pierre Marty
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pierre Marty 2020-05-07 14:08:56 UTC
Description:
When the UI is set to tabbed, in the "Slide" tab, the 2 buttons "Master Background" and "Masters Objects" are stucked in their previous state.

Steps to Reproduce:
1. Set the UI to "tabbed" (i.e. View->User Interface->Tabbed)
2. In the "Slide" tab click on either "Master Background" or "Master Objects" 


Actual Results:
The button visual state didn't change.


Expected Results:
The button visual state has to change.
If it was active, before clicking it, it would have to become inactive and vice versa.


Reproducible: Always


User Profile Reset: Yes



Additional Info:
tested on:

Version: 6.2.0.1 (x64)
Build ID: 0412ee99e862f384c1106d0841a950c4cfaa9df1
Threads CPU : 12; OS : Windows 10.0; UI Render : GL; VCL: win; 
Locale : fr-FR (fr_FR); Langue IHM : fr-FR
Calc: CL

Version: 6.2.7.1 (x64)
Build ID: 23edc44b61b830b7d749943e020e96f5a7df63bf
Threads CPU : 12; OS : Windows 10.0; UI Render : GL; VCL: win; 
Locale : fr-FR (fr_FR); Langue IHM : fr-FR
Calc: CL

Version: 7.0.0.0.alpha1+
Build ID: 58c87f8261abf4f1528a43dc501e956cb9c1d2f2
CPU threads: 12; OS: Linux 4.4; UI render: default; VCL: x11; 
Locale: en-US (C.UTF-8); UI: en-US
Calc: threaded
Comment 1 Pierre Marty 2020-05-07 16:19:29 UTC
Created attachment 160509 [details]
Video demonstration

Here is a video of what is going on

Moreover, I realized while recording that the problem was more generally related to the synchro of its parameters (i.e. Between the "Slide" tab and the "Side pane", the values are different)
Comment 2 Pierre Marty 2020-05-20 13:16:59 UTC
Created attachment 161039 [details]
Patch 1

Here is a patch so that the buttons are automatically updated and synchronized.
(Tabbed UI + Sidebar)
Comment 3 Buovjaga 2020-06-05 09:07:16 UTC
(In reply to Pierre Marty from comment #2)
> Created attachment 161039 [details]
> Patch 1
> 
> Here is a patch so that the buttons are automatically updated and
> synchronized.
> (Tabbed UI + Sidebar)

https://gerrit.libreoffice.org/c/core/+/94574

Thanks for the patch. You can just mention it in a comment :)
Comment 4 Commit Notification 2020-07-22 15:58:43 UTC
Pierre MARTY committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/4bfff26b519e4890de1cf4750f9a5ad75c3bc992

tdf#132816: update slide "master" option buttons in tabbed ui

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Xisco Faulí 2021-02-09 14:25:24 UTC
A polite ping to Pierre Marty :
Is this bug fixed? if so, could you please close it as RESOLVED FIXED ?
Otherwise, Could you please explain what's missing?
Thanks
Comment 6 Pierre Marty 2021-09-01 14:27:01 UTC
Hi,

Please excuse me for that long disappearance...

That bug should have been fixed by the patch here:
https://gerrit.libreoffice.org/c/core/+/94574

I'll double check that and update the request accordingly.

Sincerly,
Comment 7 Pierre Marty 2021-09-01 14:55:11 UTC
The patch does not seem to work...

I will re-inspect that and continue working on it.
Comment 8 Buovjaga 2021-09-01 14:59:18 UTC
*** Bug 118364 has been marked as a duplicate of this bug. ***
Comment 9 Xisco Faulí 2022-05-03 11:47:55 UTC
Dear Pierre Marty,
This bug has been in ASSIGNED status for more than 3 months without any
activity. Resetting it to NEW.
Please assign it back to yourself if you're still working on this.