Bug 132847 - Not all shapes in gallery shown in Detailed View rendered automatically
Summary: Not all shapes in gallery shown in Detailed View rendered automatically
Status: REOPENED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.0.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.6.0 target:7.4.7 target:7.5.3
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Gallery
  Show dependency treegraph
 
Reported: 2020-05-08 15:36 UTC by Telesto
Modified: 2023-03-15 19:50 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot (68.32 KB, image/jpeg)
2020-05-08 15:37 UTC, Telesto
Details
Gallery Detailed View - Arrows section (1.48 MB, video/mp4)
2021-02-26 21:20 UTC, Lucia Rodriguez
Details
Gallery Detailed View - All other sections (7.97 MB, video/mp4)
2021-02-26 21:20 UTC, Lucia Rodriguez
Details
Gallery Detailed View - Safe Mode (3.53 MB, video/mp4)
2021-02-26 21:21 UTC, Lucia Rodriguez
Details
blanks in the middle while scrolling, LO 7.6 alpha0+, gen VCL (51.77 KB, image/png)
2023-03-14 10:27 UTC, Stéphane Guillou (stragu)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-05-08 15:36:24 UTC
Description:
Not all shapes in gallery shown in list mode rendered automatically

Steps to Reproduce:
1. Open Writer
2. Open the Gallery sidebar
3. Click detailed view & scroll.. Empty area's

Actual Results:
Empty areas.. filled after clicking on the item.. 

Expected Results:
Rendered without click


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.0.0.0.alpha0+ (x64)
Build ID: 97a2c1fc5e376c0c00968f17a0392c6d3a5ed565
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win; 
Locale: nl-NL (nl_NL); UI-Language: en-US
Calc: threaded
Comment 1 Telesto 2020-05-08 15:37:46 UTC
Created attachment 160541 [details]
Screenshot
Comment 2 Durgapriyanka 2020-05-20 21:17:12 UTC
Thank you for reporting the bug. I can not reproduce this bug in

Version: 6.4.0.0.alpha1+ (x86)
Build ID: ec7374ff84c71edfbb30d6e4dc5b486b6df7107f
CPU threads: 2; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: default; VCL: win; 
TinderBox: Win-x86@42, Branch:master, Time: 2019-11-10_21:37:30
Locale: en-US (en_US); UI-Language: en-US
Calc: threaded
	

and in

LibreOffice 3.3.0 
OOO330m19 (Build:6)
tag libreoffice-3.3.0.4
Comment 3 Xisco Faulí 2020-06-29 15:43:12 UTC
Hi Telesto,
is this issue still reproducible with a master build ? with and without skia ?
Comment 4 Telesto 2020-06-29 16:15:54 UTC
Yes
Version: 7.1.0.0.alpha0+ (x64)
Build ID: 006c65bbd472cb1d7d44e095714e28190b76be0d
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 5 Buovjaga 2020-08-23 15:02:40 UTC
No problem.

Telesto: I see you were testing with Windows 8.1. I thought it might be relevant, so I additionally tested on a Win 8.1 machine, but could not repro there either.

Does it happen in safe mode as well?

Version: 7.1.0.0.alpha0+ (x64)
Build ID: 8700bace8c0714d853f5df6918ab9c8bb3d81f77
CPU threads: 4; OS: Windows 10.0 Build 19041; UI render: default; VCL: win
Locale: fi-FI (fi_FI); UI: en-US
Calc: threaded
Comment 6 BogdanB 2020-09-13 16:53:19 UTC
No repro in
Version: 7.1.0.0.alpha0+
Build ID: 0f288cf2df790d5cd13511471e0216c46c0564b5
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-US (ro_RO.UTF-8); UI: en-US
Calc: threaded

Telesto, can you try again?...
Comment 7 BogdanB 2021-01-20 17:45:15 UTC
Telesto, please try again this bug.

No repro in
Version: 7.1.0.1.0+
Build ID: e98c4be2c87ba5b3f4aedc31388014b320588d4b
CPU threads: 4; OS: Linux 5.8; UI render: default; VCL: gtk3
Locale: ro-RO (ro_RO.UTF-8); UI: en-US
Calc: threaded
Comment 8 BogdanB 2021-02-11 19:31:47 UTC
Telesto, please retest this bug...
Comment 9 Telesto 2021-02-11 19:34:44 UTC
Still present
Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 3ed9bba283a6a67864c0928186e277240be0d9ba
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 10 Lucia Rodriguez 2021-02-26 21:19:09 UTC
I am able to reproduce the bug reported by Telesto with both versions (the latest 7.1.0.3 and the alpha version 7.2.0.0alpha0+).

Version: 7.1.0.3 (x64) / LibreOffice Community
Build ID: f6099ecf3d29644b5008cc8f48f42f4a40986e4c
CPU threads: 8; OS: Windows 10.0 Build 18363; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 3ed9bba283a6a67864c0928186e277240be0d9ba
CPU threads: 8; OS: Windows 10.0 Build 18363; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: threaded

I used the same steps Telesto did in order to reproduce this. In addition, I also tried clicking each individual Gallery section (Arrows, BPMN, Bullets, Diagrams, Flow chart and Icons). I initially saw the same problem in all of them except for "Diagrams" and "Flow Chart", but then those two failed as well when I reproduced in safe mode. 

I'm adding an attachment with evidence of the bug. I found two ways to work around this:

1. The one mentioned by Telesto; clicking the non-rendering icons.
2. Scrolling to the top of the list and scrolling down again. 

@Bujoava I can reproduce this in safe mode as well (attached video)

I am attaching my screen resolution and display details in case it is relevant to the bug.

Display resolution: 2560x1440x120 hertz, 17'3 Dell laptop
Scale and layout: 150% (I was able to reproduce the bug at 100% as well)
Primary Graphics card: NVIDIA GeForce GTX1070
Secondary Graphics card: Intel(R) Graphics 630
Comment 11 Lucia Rodriguez 2021-02-26 21:20:00 UTC
Created attachment 170092 [details]
Gallery Detailed View - Arrows section
Comment 12 Lucia Rodriguez 2021-02-26 21:20:35 UTC
Created attachment 170093 [details]
Gallery Detailed View - All other sections
Comment 13 Lucia Rodriguez 2021-02-26 21:21:07 UTC
Created attachment 170094 [details]
Gallery Detailed View - Safe Mode
Comment 14 Matt K 2021-04-03 01:22:49 UTC
I can repro this using NVIDIA GeForce GTX 1080 Ti (driver version 465.89) with and without skia.  I can only repro when scrolling very fast though; scrolling slowly does not repro the issue.

Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 5707ec3303f8215af91aac7d7f7cc29bf67b6c99
CPU threads: 12; OS: Windows 10.0 Build 19041; UI render: default; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL
Comment 15 Stéphane Guillou (stragu) 2023-03-09 14:30:57 UTC
Thanks for the visuals, Lucia!

Reproduced in recent master build:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: a179f6c91692076e7e17babf4890638caa398384
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win
Locale: en-GB (en_GB); UI: en-GB
Calc: threaded

Same without Skia with LO 7.0.0.3

I can see it happen with every single category in the Gallery.

Regression, as it does not happen with 6.4.0:

Version: 6.4.0.3 (x64)
Build ID: b0a288ab3d2d4774cb44b62f04d5d28733ac6df8
CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: default; VCL: win; 
Locale: en-GB (en_GB); UI-Language: en-GB
Calc: threaded
Comment 16 Stéphane Guillou (stragu) 2023-03-09 18:38:51 UTC
Also in gen VCL:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: 288c0920a8475f9f2c537212e04aa7649192ad8c
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: x11
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

I could reproduce easily with a quick scroll to the bottom of the Diagrams gallery: a whole section would be just blank.

Bibisected with linux-64-7.0 and gen VCL to first bad commit 90e2286447246869c49f2addecf6b33b64caf552 which points to core commit:

commit fa8c85fa90e9565a357b247a69f930098d11ff84
author	Caolán McNamara <caolanm@redhat.com>	Thu Jan 16 16:38:15 2020 +0000
committer	Caolán McNamara <caolanm@redhat.com>	Tue Jan 21 09:57:58 2020 +0100
tree d14cb6db4faa840ae23b435bbdcd3ff5987c3f44
parent 9394ad31fb9c325001c97702feda317d61f1cbbb
weld gallery panel
Change-Id: I4aebb3f90e9943044d106a507972c39434988f03
Reviewed-on: https://gerrit.libreoffice.org/c/core/+/87003

Caolán, sorry to keep bringing up the old welds! :)
Comment 17 Caolán McNamara 2023-03-10 15:52:58 UTC
These are supposed to be generated on demand the first time they are scrolled into view. Works on a little scroll, doesn't on a large scroll. I think I see why.
Comment 18 Commit Notification 2023-03-11 20:32:07 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/9dec458e40a8b6a180e5c1c6f93fd4277825b9a2

Resolves: tdf#132847 large scrolls that cause page up/down are still "scrolls"

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 19 Caolán McNamara 2023-03-11 20:38:16 UTC
assuming I'm reproducing the right thing, then fixed in trunk now, backports to 7-5 and 7-4 in gerrit
Comment 20 Commit Notification 2023-03-11 22:04:17 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/b414cb574d0641d387a8c6190112746929e88d52

Resolves: tdf#132847 large scrolls that cause page up/down are still "scrolls"

It will be available in 7.4.7.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 21 Commit Notification 2023-03-12 16:05:48 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/48c67edeabecfb998f20a6a4b410817239eadd52

Resolves: tdf#132847 large scrolls that cause page up/down are still "scrolls"

It will be available in 7.5.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 22 Stéphane Guillou (stragu) 2023-03-12 20:54:42 UTC
I can still reproduce the issue in a build that includes 9dec458e40a8b6a180e5c1c6f93fd4277825b9a2:

Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community
Build ID: d887b6a6fa2a572f48498839c5a68791c3196634
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: x11
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

On Windows 10 too.

Now that you mention Page Down, I found it is easier to reproduce by clicking in the first element of the category and then pressing End on the keyboard.
Comment 23 Commit Notification 2023-03-13 10:21:35 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/2071538904ed37397767ebd4a9dc82827f75f374

tdf#132847 emit NotifyScrolled on use of end/home to scroll to end/start

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 24 Caolán McNamara 2023-03-13 10:23:48 UTC
that's the "end" case covered, but I don't know if that's everything or if there is a remaining unhandled case, but lets assume for the moment that it is everything
Comment 25 Commit Notification 2023-03-14 10:13:32 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/246596fb206fd05d8420834730ff87051a155ab3

tdf#132847 emit NotifyScrolled on use of end/home to scroll to end/start

It will be available in 7.4.7.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 26 Stéphane Guillou (stragu) 2023-03-14 10:27:40 UTC
Created attachment 185946 [details]
blanks in the middle while scrolling, LO 7.6 alpha0+, gen VCL

Thanks Caolán, the jump to the bottom is now fixed.

However, I still reproduce the holes while scrolling, sometimes cutting off elements, restored by either clicking items or scrolling some more back and forth.
Just as described by Telesto and seen in Lucia's videos.

Tested with master build up to 97a38dbfa998967c45efaf3303fedfa1a709a2bb.
Comment 27 Stéphane Guillou (stragu) 2023-03-14 10:29:17 UTC
Apologies for another reopen, Caolán!
Comment 28 Caolán McNamara 2023-03-14 10:40:44 UTC
*shrug* then I need exact steps
Comment 29 Commit Notification 2023-03-15 19:50:09 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-5":

https://git.libreoffice.org/core/commit/0573c5d067d866fc00178942d1db397da499670b

tdf#132847 emit NotifyScrolled on use of end/home to scroll to end/start

It will be available in 7.5.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.