Bug 132869 - Define name dialog. Red color for invalid name highlight instead blue
Summary: Define name dialog. Red color for invalid name highlight instead blue
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
7.0.0.0.alpha0+
Hardware: All All
: medium enhancement
Assignee: Andreas Heinisch
URL:
Whiteboard: target:7.2.0
Keywords:
Depends on:
Blocks: Calc-UX
  Show dependency treegraph
 
Reported: 2020-05-09 08:43 UTC by Roman Kuznetsov
Modified: 2021-11-30 13:23 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Define name dialog with blue highlighting (8.97 KB, image/png)
2020-05-09 09:12 UTC, Roman Kuznetsov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Roman Kuznetsov 2020-05-09 08:43:20 UTC
Description:
Define name dialog. Blue color for invalid name highlight instead red.
And I suggest to change it to red.

For example, Condition formatting dialog uses red highlighting for wrong data range in Range field.

Steps to Reproduce:
1. Open Sheet->Named ranged and expressions->Define
2. Enter any name with space in Name field
3. Look at phrase "Invalid name. Use only letters, numbers and underscore." with blue highlighting.

Actual Results:
"Invalid name. Use only letters, numbers and underscore." has blue highlighting.

Expected Results:
"Invalid name. Use only letters, numbers and underscore." has red highlighting.


Reproducible: Always


User Profile Reset: No



Additional Info:
it was always, I checked it down to 5.2.7 version
Comment 1 Roman Kuznetsov 2020-05-09 09:12:15 UTC
Created attachment 160553 [details]
Define name dialog with blue highlighting
Comment 2 Heiko Tietze 2020-05-11 11:04:56 UTC
The blue is not ideal, sure. But even better when we make the input itself responding and show the reason in a tooltip. Prepared a generic solution for bug 129032 at https://gerrit.libreoffice.org/c/core/+/85101
Comment 3 Roman Kuznetsov 2020-08-03 16:46:13 UTC
Unfortunately, I don't have free time to fix it=(
Comment 4 Commit Notification 2021-04-12 06:40:24 UTC
Andreas Heinisch committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/58dcf2a88af215df4e912f0cfcb32908c6a298a0

tdf#132869 - Show the error message in a tooltip

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Stéphane Guillou (stragu) 2021-11-30 13:23:53 UTC
verified as fixed in:

Version: 7.2.0.2 / LibreOffice Community
Build ID: 614be4f5c67816389257027dc5e56c801a547089
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded