Bug 133002 - Animations: with trigger on object click, Shape goes back to its initial state after animation (comment 8)
Summary: Animations: with trigger on object click, Shape goes back to its initial stat...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
(earliest affected)
6.3 all versions
Hardware: All All
: medium normal
Assignee: Not Assigned
Keywords: bibisected, bisected, implementationError
: 151096 151097 159648 (view as bug list)
Depends on:
Blocks: Object-Animations
  Show dependency treegraph
Reported: 2020-05-13 14:01 UTC by Vera Blagoveschenskaya
Modified: 2024-04-12 02:44 UTC (History)
8 users (show)

See Also:
Crash report or crash signature:

scr1 (218.56 KB, image/png)
2020-05-13 14:02 UTC, Vera Blagoveschenskaya
scr2 (222.34 KB, image/png)
2020-05-13 14:02 UTC, Vera Blagoveschenskaya
Game.odp (11.80 KB, application/vnd.oasis.opendocument.presentation)
2020-05-13 14:02 UTC, Vera Blagoveschenskaya

Note You need to log in before you can comment on or make changes to this bug.
Description Vera Blagoveschenskaya 2020-05-13 14:01:14 UTC
Trigger on click, Shape is shown after animation

Steps to Reproduce:
1. Open Game.odp (in the attachment).
2. Shape 1 has trigger Eit on click to it.
3. Set up Hide after animation.
See screenshots.

Actual Results:
Shape 1 is shown after exit animation.

Expected Results:
Shape 1 should disappear at all.

Reproducible: Always

User Profile Reset: No

Additional Info:
Tested with

Build ID: 6a03b2a54143a9bc0c6d4c7f1...
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: kf5; 
Locale: ru-RU (ru_RU.UTF-8); UI: en-US
Calc: threaded
Comment 1 Vera Blagoveschenskaya 2020-05-13 14:02:07 UTC
Created attachment 160756 [details]
Comment 2 Vera Blagoveschenskaya 2020-05-13 14:02:29 UTC
Created attachment 160757 [details]
Comment 3 Vera Blagoveschenskaya 2020-05-13 14:02:50 UTC
Created attachment 160758 [details]
Comment 4 Mike 2020-06-07 16:31:59 UTC

Version: (x64)
Build-ID: 3d775be2011f3886db32dfd395a6a6d1ca2630ff
CPU-Threads: 4; BS: Windows 10.0 Build 18363; UI-Render: Standard; VCL: win; 
Gebietsschema: de-DE (de_DE); UI-Sprache: de-DE
Calc: CL
Comment 5 QA Administrators 2022-06-09 03:32:43 UTC Comment hidden (obsolete)
Comment 6 Kira Tubo 2023-11-03 04:49:44 UTC
Reproduced in: 

Version: (x64)
Build ID: 547edd20e527fb02900f6174973770d26306e2e7
CPU threads: 6; OS: Windows 10.0; UI render: GL; VCL: win; 
Locale: en-US (en_US); UI-Language: en-US
Calc: CL

Version: (X86_64) / LibreOffice Community
Build ID: 676e0527d2f31556eccae314fbb12ce204f02ec7
CPU threads: 6; OS: Windows 10.0 Build 22621; UI render: Skia/Raster; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL threaded

Not reproduced in: 

Version: (x64)
Build ID: 0b9f9bef65bb21ebb6a64aafad448f7f62dc824a
CPU threads: 6; OS: Windows 6.19; UI render: default; 
Locale: en-US (en_US); Calc: CL

Looks like a regression.
Comment 7 raal 2024-02-11 17:14:45 UTC
(In reply to Kira Tubo from comment #6)
> Looks like a regression.

@Kira, thank you retesting and reveal the regression.

This seems to have begun at the below commit in bibisect repository/OS bibisect-linux-64-6.3.
Adding Cc: to Mark Hung ; Could you possibly take a look at this one?
 b22e80f550338670dbe9cef9370ca97bbae3bd6d is the first bad commit
commit b22e80f550338670dbe9cef9370ca97bbae3bd6d
Author: Jenkins Build User <tdf@pollux.tdf>
Date:   Tue Feb 26 05:07:52 2019 +0100

    source 7e18b87566c55b38ca812c28b01ed346d45e94b8

68283: tdf#88969 restart interactive sequence. | https://gerrit.libreoffice.org/c/core/+/68283
Comment 8 Stéphane Guillou (stragu) 2024-02-23 01:52:29 UTC
You don't even need to have "hide after animation" on in the Effect Options to reproduce this. Using an effect from the "Exit" category triggered by object click is enough.
And the opposite problem also exists: if an object uses an Entrance effect, it disappears instead at the end.

Generalising the issue:

Since b22e80f550338670dbe9cef9370ca97bbae3bd6d, an animation that is triggered by clicking another object goes back to its initial state when the animation is finished. This solved bug 88969 and allows repeating such animations without switching slides, but it only works for users who actually want the object to automatically go back to the start state (or for whom it does not matter because the end state is the same as the initial state, i.e. a "cyclic" animation). 

I'd call this an implementation error rather than a regression.

We should either:
- allow repeating the animation without the object always settling to its start state; or
- make the fix for bug 88969 optional (but the dialog doesn't need more complexity in my opinion)

UX/Design team, what do you think?
Comment 9 Stéphane Guillou (stragu) 2024-02-23 01:54:21 UTC
*** Bug 151096 has been marked as a duplicate of this bug. ***
Comment 10 Stéphane Guillou (stragu) 2024-02-23 01:55:03 UTC
*** Bug 151097 has been marked as a duplicate of this bug. ***
Comment 11 Stéphane Guillou (stragu) 2024-02-23 01:56:01 UTC
*** Bug 159648 has been marked as a duplicate of this bug. ***
Comment 12 Heiko Tietze 2024-02-23 08:47:55 UTC
MSO 365 has 'after animation' options but disables it in case of exit animations. It also has another option "[ ] Rewind when done playing", which can be used on exit animations too, ending up in what is defined at the (disabled) after animation option. At this point I stop discussing MSO's issues. ;-)

From the user POV I expect exit animations to 'Hide After Animation' and entry to 'Show After Animation', automatically but optionally. Unfortunately 'hide after animation' does not make the shape disappear but the options 'Dim with color' or 'Hide with next animation' does => bug.