Bug 133037 - Fileopen DOCX: Block arrow shapes rotated
Summary: Fileopen DOCX: Block arrow shapes rotated
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.1.6.2 release
Hardware: All All
: medium minor
Assignee: Dániel Arató (NISZ)
URL:
Whiteboard: target:7.1.0
Keywords: filter:docx, implementationError
Depends on:
Blocks: OOXML-Shapes
  Show dependency treegraph
 
Reported: 2020-05-14 16:13 UTC by Jorge
Modified: 2020-11-11 10:38 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Original Document (478.28 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2020-05-14 16:13 UTC, Jorge
Details
Expected Result (391.31 KB, application/pdf)
2020-05-14 16:14 UTC, Jorge
Details
Minimized test document (23.19 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2020-08-31 13:32 UTC, NISZ LibreOffice Team
Details
The minimized example file in Word and Writer (73.18 KB, image/png)
2020-08-31 13:33 UTC, NISZ LibreOffice Team
Details
The minimized example file in Word and Writer (78.51 KB, image/png)
2020-09-01 13:56 UTC, NISZ LibreOffice Team
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jorge 2020-05-14 16:13:46 UTC
Created attachment 160827 [details]
Original Document

Good morning,

Docx format, between page 3 and page 4:
 - 2 words not displayed
 - arrows in the wrong direction


Thank you. 
Jorge
Comment 1 Jorge 2020-05-14 16:14:35 UTC
Created attachment 160828 [details]
Expected Result
Comment 2 Julien Nabet 2020-05-15 11:31:07 UTC
On pc Debian x86-64 with master sources updated today, I noticed these errors during conversion:
warn:vcl.pdfwriter:25312:25312:vcl/source/gdi/pdfwriter_impl.cxx:7697: invalid conversion
warn:vcl.pdfwriter:25312:25312:vcl/source/gdi/pdfwriter_impl.cxx:7697: invalid conversion
warn:vcl.pdfwriter:25312:25312:vcl/source/gdi/pdfwriter_impl.cxx:7697: invalid conversion
warn:vcl.pdfwriter:25312:25312:vcl/source/gdi/pdfwriter_impl.cxx:7697: invalid conversion
warn:vcl.pdfwriter:25312:25312:vcl/source/gdi/pdfwriter_impl.cxx:7697: invalid conversion
warn:vcl.pdfwriter:25312:25312:vcl/source/gdi/pdfwriter_impl.cxx:7697: invalid conversion

There's a lacking frame in page 4 for "Annexe 1"

Which words precisely?
Comment 3 Julien Nabet 2020-05-15 11:41:03 UTC
BTW, arrows in page 3 are indeed in the wrong direction.
Comment 4 Jorge 2020-05-22 16:39:51 UTC
The problem is not with conversion from docx to pdf file,
pdf file is only to show you how word display docx file properly:

Open doxc file with libreoffice : see page 3 to 4, and compare with pdf.

You will see : 
 - 2 words not displayed
 - arrows in the wrong direction

Thank you. 
Jorge
Comment 5 NISZ LibreOffice Team 2020-08-31 13:32:22 UTC
Created attachment 164921 [details]
Minimized test document
Comment 6 NISZ LibreOffice Team 2020-08-31 13:33:41 UTC
Created attachment 164922 [details]
The minimized example file in Word and Writer

Version: 7.1.0.0.alpha0+ (x64)
Build ID: c10ea0e903ee2aba126087fc81702233b3a509cf
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: en-US (hu_HU); UI: en-US
Calc: CL
Comment 7 NISZ LibreOffice Team 2020-09-01 13:56:54 UTC
Created attachment 164969 [details]
The minimized example file in Word and Writer

So these arrows have Spatial rotation set in Word in depth (Z?) direction: 80 degrees for the left one and 270 degrees for the right one.

In Writer I don't even find a similar option where such values could be set. The 3D-Settings toolbar has no enabled commands when I select these shape objects.
Comment 8 NISZ LibreOffice Team 2020-09-02 08:20:55 UTC
Removing see also bug, that one is about the VML rotation property.
Comment 9 Dániel Arató (NISZ) 2020-10-01 13:11:28 UTC
Where can I find the source code that rotates and renders an XShape?
Comment 10 Commit Notification 2020-10-09 08:13:17 UTC
Daniel Arato (NISZ) committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/a9c5c0d814a266096483572b84c72875ef8efd77

tdf#133037 OOXML shape import: camera rotation along Z

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Timur 2020-10-12 13:11:19 UTC
This looks fixed. Unless you have a reason to keep it open, please set Fixed.
Filesave seems also good to me. 
Please write (for us non-programmers) if there's unit test here included.
Comment 12 Jorge 2020-10-16 19:51:22 UTC
Hello,

Just tested with 7.1.0.0.alpha0+
https://git.libreoffice.org/core/+log/df74aef7159d7155addf78cfc4d139485945d794/?s=59cca1a28df4cdc94450d68cc1e247a8fb5ff6f3

Looks perfect, really thank you for your help !!

I mark the ticket as resolved.


Thank you. 
Jorge
Comment 13 NISZ LibreOffice Team 2020-11-11 10:38:12 UTC
Verified in

Version: 7.1.0.0.alpha1+ (x64)
Build ID: a689cf1672e89cb78fbcfa14c505850927e71f58
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: en-GB
Calc: threaded

Thanks, Dani :-)