Description: MacOS: Some character can't be rendered; square Steps to Reproduce: 1. Open Writer. 2. Sidebar -> Styles -> List styles -> arrow & checkbox are a square Actual Results: Square replacement Expected Results: Symbol Reproducible: Always User Profile Reset: No Additional Info: LibreOffice 7.0 alpha1
COnfirming with Version: 7.0.0.0.alpha1 Build ID: 6a03b2a54143a9bc0c6d4c7f1... CPU threads: 8; OS: Mac OS X 10.15.4; UI render: default; VCL: osx; Locale: fr-FR (fr_FR.UTF-8); UI: en-US Calc: threaded
I see the same problem in Version : 6.4.3.2 Build ID : 747b5d0ebf89f41c860ec2a39efd7cb15b54f2d8 Threads CPU : 8; OS : Mac OS X 10.15.4; UI Render : par défaut; VCL: osx; Locale : fr-FR (fr_FR.UTF-8); Langue IHM : fr-FR Calc: threade
Also confirmed in LO Vanilla Version : 6.4.3.5 Build ID : 4db9852e73d9e9d662fc8a2783bace79addf1805 Threads CPU : 8; OS : Mac OS X 10.15.4; UI Render : par défaut; VCL: osx; Locale : fr-FR (fr_FR.UTF-8); Langue IHM : fr-FR Calc: threaded
Problem not visible in Version: 6.2.8.2 Build ID: f82ddfca21ebc1e222a662a32b25c0c9d20169ee Threads CPU : 8; OS : Mac OS X 10.15.4; UI Render : par défaut; VCL: osx; Locale : fr-FR (fr_FR.UTF-8); Langue IHM : fr-FR Calc: threaded but this version doesn't shown a preview of the list style, so I'm assuming that the problem came about when previews of the list style were introduced into the code ?
Created attachment 186123 [details] Screen shot of missing characters in style list on Mac
The bullet previews in the Styles List Style is missing in the mac64-6.4.bundle. Missing in version: Version: 6.3.0.0.alpha1+ Build ID: c98b1f1cd43b3e109bcaf6324ef2d1f449b34099 to version: Version: 6.4.0.0.beta1+ Build ID: d54bae3471e9b9529f1ac03c811c3370d9f5ed89 So updated the version earliest affected to 6.3.0.4 release.
The mac64-6.1.bundle applications show that the bullet characters were not expected Styles:List Style menu. So it is likely that the change happened in the 6.2 code. Attached find screenshot of the v6.1 apps checked.
Created attachment 186164 [details] No bullet characters in Style list on v6.0
Created attachment 186165 [details] No bullet characters in Style list on v6.1
The UI change to the Style: List Styles was introduced in commit: 25e459c104d3c9f838836e3cfbb51185461874a0 ``` $ git bisect good 25e459c104d3c9f838836e3cfbb51185461874a0 is the first bad commit commit 25e459c104d3c9f838836e3cfbb51185461874a0 Author: gerrit <gerrit@gerrits-Mac-mini.local> Date: Wed May 1 02:43:36 2019 +0200 source 43c44f7c82fdcf7e5e6eccb0a80d5bb0e1e3a86c source 43c44f7c82fdcf7e5e6eccb0a80d5bb0e1e3a86c LibreOffice.app/Contents/Frameworks/libswlo.dylib | Bin 19022688 -> 19022688 bytes LibreOffice.app/Contents/Resources/setuprc | 2 +- LibreOffice.app/Contents/Resources/versionrc | 2 +- 3 files changed, 2 insertions(+), 2 deletions(-) ```
(In reply to bunkem from comment #10) > The UI change to the Style: List Styles was introduced in commit: > 25e459c104d3c9f838836e3cfbb51185461874a0 > > ``` > $ git bisect good 25e459c104d3c9f838836e3cfbb51185461874a0 is the first bad > commit > commit 25e459c104d3c9f838836e3cfbb51185461874a0 > Author: gerrit <gerrit@gerrits-Mac-mini.local> > Date: Wed May 1 02:43:36 2019 +0200 > > source 43c44f7c82fdcf7e5e6eccb0a80d5bb0e1e3a86c > > source 43c44f7c82fdcf7e5e6eccb0a80d5bb0e1e3a86c > > LibreOffice.app/Contents/Frameworks/libswlo.dylib | Bin 19022688 -> > 19022688 bytes > LibreOffice.app/Contents/Resources/setuprc | 2 +- > LibreOffice.app/Contents/Resources/versionrc | 2 +- > 3 files changed, 2 insertions(+), 2 deletions(-) > ``` I suspect this is caused by the use if Private Use Area code points (that OpenSymbol font uses for these bullets) in the above commit. Many systems don’t allow font fallback for PUA code points (because it is meaningless as these are font-specific). But do we really need to use PUA here, don’t we have equivalent non-PUA code points that we use or are these really OpenSymbol-specific symbols? Mike, you reviewed the above commit, do you have some insight here? I checked sw/source/core/doc/DocumentStylePoolManager.cxx and it does not use these PUA code points for these bullets, so I don’t know which is correct.
(In reply to خالد حسني from comment #11) > (In reply to bunkem from comment #10) > > The UI change to the Style: List Styles was introduced in commit: > > 25e459c104d3c9f838836e3cfbb51185461874a0 > > > > ``` > > $ git bisect good 25e459c104d3c9f838836e3cfbb51185461874a0 is the first bad > > commit > > commit 25e459c104d3c9f838836e3cfbb51185461874a0 > > Author: gerrit <gerrit@gerrits-Mac-mini.local> > > Date: Wed May 1 02:43:36 2019 +0200 > > > > source 43c44f7c82fdcf7e5e6eccb0a80d5bb0e1e3a86c > > > > source 43c44f7c82fdcf7e5e6eccb0a80d5bb0e1e3a86c > > > > LibreOffice.app/Contents/Frameworks/libswlo.dylib | Bin 19022688 -> > > 19022688 bytes > > LibreOffice.app/Contents/Resources/setuprc | 2 +- > > LibreOffice.app/Contents/Resources/versionrc | 2 +- > > 3 files changed, 2 insertions(+), 2 deletions(-) > > ``` > > I suspect this is caused by the use if Private Use Area code points (that > OpenSymbol font uses for these bullets) in the above commit. Many systems > don’t allow font fallback for PUA code points (because it is meaningless as > these are font-specific). But do we really need to use PUA here, don’t we > have equivalent non-PUA code points that we use or are these really > OpenSymbol-specific symbols? > > Mike, you reviewed the above commit, do you have some insight here? I > checked sw/source/core/doc/DocumentStylePoolManager.cxx and it does not use > these PUA code points for these bullets, so I don’t know which is correct. See also bug 124471.
Khaled Hosny committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/ced4a9221329b88484f90ab6d00d797f024585bb tdf#133089: Use proper Unicode code points for bullet style names It will be available in 7.6.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
@Khaled, Is there something more needed given the use of the PUA glyphs when opening the Bullet style panel on the 'Unordered' tab? There the UI picks up OpenSymbol PUA 0xe00c glyph for the 'Solid Diamond bullets' and the 0xe00a PUA glyph for the 'Solid large square bullets'[1] Look to need to replace the 0xe00a PUA, maybe with 0x25a0 FILLED BOX But for the 0xe00c PUA, since OpenSymbol does not provide a 0x25c6 BLACK DIAMOND can we map it somehow to that Unicode? Alternatively copy the glyph to that codepoint? =-ref-= [1] https://opengrok.libreoffice.org/xref/core/svx/source/sidebar/nbdtmg.cxx?r=093a7f42&h=83#83
(In reply to V Stuart Foote from comment #14) > @Khaled, > > Is there something more needed given the use of the PUA glyphs when opening > the Bullet style panel on the 'Unordered' tab? > > There the UI picks up OpenSymbol PUA 0xe00c glyph for the 'Solid Diamond > bullets' and the 0xe00a PUA glyph for the 'Solid large square bullets'[1] > > Look to need to replace the 0xe00a PUA, maybe with 0x25a0 FILLED BOX > > But for the 0xe00c PUA, since OpenSymbol does not provide a 0x25c6 BLACK > DIAMOND can we map it somehow to that Unicode? Alternatively copy the glyph > to that codepoint? > > =-ref-= > [1] > https://opengrok.libreoffice.org/xref/core/svx/source/sidebar/nbdtmg. > cxx?r=093a7f42&h=83#83 I don’t see any missing glyph squares in that tab, so probably not.
(In reply to Commit Notification from comment #13) > Khaled Hosny committed a patch related to this issue. > It has been pushed to "master": > > https://git.libreoffice.org/core/commit/ > ced4a9221329b88484f90ab6d00d797f024585bb > > tdf#133089: Use proper Unicode code points for bullet style names > > It will be available in 7.6.0. > > The patch should be included in the daily builds available at > https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More > information about daily builds can be found at: > https://wiki.documentfoundation.org/Testing_Daily_Builds > > Affected users are encouraged to test the fix and report feedback. Good morning. I tried daily build and can confirm that the issue is fixed in this build: Version: 7.6.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 002f941ec20e594e9702c39fab9cf9f4cc392dab CPU threads: 8; OS: Mac OS X 12.6.3; UI render: Skia/Metal; VCL: osx Locale: en-CA (en_CA.UTF-8); UI: en-US Calc: threaded Thank you.