Bug 133103 - Debian package missing depends on openssh-client
Summary: Debian package missing depends on openssh-client
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice Online
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Andras Timar
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-16 20:41 UTC by Anthony DeRobertis
Modified: 2020-06-12 07:11 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Anthony DeRobertis 2020-05-16 20:41:44 UTC
I hope this is the right place to report this bug. I'm using the CODE packages, installed inside a Debian 9 container (hence not having fairly ordinary things like ssh client).

dpkg: error processing package loolwsd (--configure):
 subprocess installed post-installation script returned error exit status 127
Errors were encountered while processing:
 loolwsd
Updating loolwsd systemplate
E: Sub-process /usr/bin/dpkg returned an error code (1)
W: Operation was interrupted before it could finish
root@CODE:~# dpkg --configure -a
Setting up loolwsd (4.2.3-2) ...
dpkg: error processing package loolwsd (--configure):
 subprocess installed post-installation script returned error exit status 127
Errors were encountered while processing:
 loolwsd

Quickly adding "set -x" to /var/lib/dpkg/info/loolwsd.postinst showed it was loolwsd-generate-proof-key failing, which when run directly:

root@CODE:~# loolwsd-generate-proof-key
ssh-keygen command not found. Please install openssh client tools.

Installing openssh-client indeed fixes it, so the package should either Depends: on openssh-client or if it's actually optional (previous versions didn't seem to need it), then the maintainer could have an [ -x … ] test and then it could be a Recommends: or Suggests:
Comment 1 Ming Hua 2020-05-17 03:43:54 UTC
(In reply to Anthony DeRobertis from comment #0)
> I hope this is the right place to report this bug.
Probably not. :-P

Debian bugs should be reported at https://www.debian.org/Bugs/, but it seems Debian doesn't pakcage LOOL so you'll have to report to the maintainer of the unofficial loolwsd package you were trying to install.

[...]
> 
> Installing openssh-client indeed fixes it, so the package should either
> Depends: on openssh-client or if it's actually optional (previous versions
> didn't seem to need it), then the maintainer could have an [ -x … ] test and
> then it could be a Recommends: or Suggests:
Your analysis seems spot on, however there is little LibreOffice people can do about it, unless LO is offering LOOL Debian packages I don't know of.

Where did you get your loolwsd package from?  Collabora?
Comment 2 lool-bugreport 2020-05-17 07:48:25 UTC
Came here to post that i have noticed the same missing dependency.

@Ming Hua

I had posted such issues in the loolwsd packages provided by Collabora (the one
i'm using) here:

https://bugs.documentfoundation.org/show_bug.cgi?id=108753

which were noticed and solved so i guess the bugtracker here is the correct place to report this.

https://www.collaboraoffice.com/code/#participate is also listing this 
bugtracker as the place to report.
Comment 3 Ming Hua 2020-05-17 12:32:43 UTC
(In reply to lool-bugreport from comment #2)
> @Ming Hua
[...]
> https://www.collaboraoffice.com/code/#participate is also listing this 
> bugtracker as the place to report.
Thanks.  I didn't know Collabora was encouraging reporting bugs here.

Setting to NEW then since two users are reporting the same issue.
Comment 4 lool-bugreport 2020-05-28 17:58:37 UTC
Related commit for a fix in the git repo (not released yet):

https://cgit.freedesktop.org/libreoffice/online/commit/?id=2f31fdfa3f72f1bbadb240167f5c9aed6d7c8665
Comment 5 Andras Timar 2020-06-12 07:11:59 UTC
Fixed in CODE 4.2.4 (released yesterday).