Bug 133121 - UI: Allocated width of the drop lists is being adjusted on every font change, but not really needed
Summary: UI: Allocated width of the drop lists is being adjusted on every font change,...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
7.0.0.0.alpha1+
Hardware: All All
: medium trivial
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.0.0
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-17 13:06 UTC by Telesto
Modified: 2020-05-18 20:15 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:
Regression By:


Attachments
Screencast (504.13 KB, video/mp4)
2020-05-17 13:07 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-05-17 13:06:44 UTC
Description:
UI: Dialog shifts a lot moving through fonts

Steps to Reproduce:
1. Open Calc
2. Right click -> Format cells -> Font tab
3. Press Arrow down.. notice dialog moving

Actual Results:
Dancing dialog

Expected Results:
Stable dialog


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.0.0.0.alpha1+ (x64)
Build ID: f9790da286f2d2fa47f1748f8cfa6172c6622ca3
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win; 
Locale: de-CH (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2020-05-17 13:07:21 UTC
Created attachment 160934 [details]
Screencast
Comment 2 V Stuart Foote 2020-05-17 14:26:00 UTC
Dialog is not 'moving', allocated width of the drop lists is being adjusted response to content.
Comment 3 V Stuart Foote 2020-05-17 17:05:59 UTC
Also apparent on the Character dialog's Font tab, in addition to Calc's Cell Formatting dialog.

But only occurs for Style listbox for dialog(s) with just a single default Language selection is made (Tools -> Options -> Language Settings -> Languages).

Dialog changes and drop lists are fixed width when font selection for two or more of the Western/Asian/CTL modes are enabled.

@Caolan, is this an effect of welding the font dialogs, would fixed width always be possible?
Comment 4 Caolán McNamara 2020-05-17 18:42:35 UTC
its probably a factor of the contents of the "style" list content changing between fonts so there's a different amount of "extra space" to be divided up between the widgets
Comment 5 Commit Notification 2020-05-18 20:12:43 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/acc8ff577b2087fa2734b569a9606d9acac09c2e

tdf#133121 limit style list width to that of the entry widget

It will be available in 7.0.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Caolán McNamara 2020-05-18 20:15:19 UTC
that makes the width stable for me