Created attachment 161104 [details] Different icons for colors in Colibre Step to reproduce 1. Create a new Writer file, make sure we choose Colibre icon set 2. Insert an image 3. In the Image toolbar, click the color icons Then a floating bar appear consists of six functions: red, blue, green, brightness, contras, gamma. 4. Click Tools > Customize, go to Toolbar tab and try search Red/Blue/Green what bothers me is the icons for the colors above are not the same as the small version with the other versions. The large and extra large version use white palette that the main color barely can be seen. Please change them Version: 7.0.0.0.alpha1+ Build ID: b1e396d86655a0131498a4691dd8069ea76c3477 CPU threads: 4; OS: Linux 4.20; UI render: default; VCL: kf5; Locale: id-ID (id_ID.UTF-8); UI: en-US TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2020-05-15_04:58:38 Calc: threaded
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/defdbb87a67e2a48ecebf28d71e9b9576ef67c1e Colibre: tdf#133250 inconsisten colors icons It will be available in 7.0.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
https://gerrit.libreoffice.org/c/core/+/94653 Icons assigned to the six values for the VCL Bitmap:Adjust [1][2], Colibre had a mix of icons in use. And in SVX also used the sc_ size [3]. And do the hard coded icon paths need clean up also? [4,5,6] =-ref-= [1] https://opengrok.libreoffice.org/xref/core/vcl/source/gdi/bitmap3.cxx?r=c7e07cc7&h=1000#999 [2] https://opengrok.libreoffice.org/xref/core/include/vcl/bitmap.hxx?r=e3cc7b94#469 [3] https://opengrok.libreoffice.org/xref/core/svx/inc/bitmaps.hlst?r=473e9720#277 [4,5,6] https://opengrok.libreoffice.org/xref/core/svx/uiconfig/ui/sidebargraphic.ui?r=387200f2#200 https://opengrok.libreoffice.org/xref/core/svx/uiconfig/ui/sidebargraphic.ui?r=387200f2#243 https://opengrok.libreoffice.org/xref/core/svx/uiconfig/ui/sidebargraphic.ui?r=387200f2#287
(In reply to V Stuart Foote from comment #2) > > Icons assigned to the six values for the VCL Bitmap:Adjust [1][2], Colibre > had a mix of icons in use. And in SVX also used the sc_ size [3]. s/six/seven luminance, contrast, red, green, blue, gamma, brightness Suspect the NB color sections that use these controls should probably include all 7 (exclude the 3 colors--so icons don't show on the NB).
(In reply to V Stuart Foote from comment #3) > (In reply to V Stuart Foote from comment #2) > > > > Icons assigned to the six values for the VCL Bitmap:Adjust [1][2], Colibre > > had a mix of icons in use. And in SVX also used the sc_ size [3]. > > s/six/seven > > luminance, contrast, red, green, blue, gamma, brightness > > Suspect the NB color sections that use these controls should probably > include all 7 (exclude the 3 colors--so icons don't show on the NB). So what is the problem here? Sorry I do not get it. I just see - Six functions with standard toolbar UI (under Color toolbar):Red, Blue, Green, Brightness, Contrast, Gamma. - Four functions in the Image tab with Tabbed UI: Brightness, Transparency, Contrast, Gamma. - Eight functions in the Sidebar Image Properties with four of them have no icons: Brightness, Contrast, Color mode and Transparency and remaining four with icons: Red, Green, Blue, Gamma
(In reply to Rizal Muttaqin from comment #4) > ... > So what is the problem here? Sorry I do not get it. I just see > > ... More a side bar to the visual glitch here of the bad icon mix. Point is the Bitmap::Adjust functions have some very specific behaviors applying filter transforms and replacing a source graphic (raster or vector). Seems the UI should expose the full set of controls (with a cohesive set of icons) for each of the MUFFIN modes.
Rizal Muttaqin committed a patch related to this issue. It has been pushed to "libreoffice-6-4": https://git.libreoffice.org/core/commit/3ac066a585c781e0cb6e7fa7ae6a3c1107839dce Colibre: tdf#133250 inconsisten colors icons It will be available in 6.4.5. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Corrected with Version: 7.0.0.0.alpha1+ (x64) Build ID: b587de60d4e6aa96238766272d94f1499b22f696 CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Vulkan; VCL: win; Locale: en-US (en_US); UI: en-US Calc: threaded But may still need to cleanup the listed icon paths for the Sidebar, comment 2