Bug 133315 - Calc hangs after undoing the deletion of a number of columns
Summary: Calc hangs after undoing the deletion of a number of columns
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
4.2.0.4 release
Hardware: All Windows (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, perf, regression
: 133114 (view as bug list)
Depends on:
Blocks:
 
Reported: 2020-05-23 16:19 UTC by Telesto
Modified: 2020-10-02 19:20 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file (6.40 MB, application/vnd.oasis.opendocument.spreadsheet)
2020-05-23 16:20 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-05-23 16:19:56 UTC
Description:
Calc hangs after undoing the deletion of a number of columns

Steps to Reproduce:
1. Open the attached file
2. Select column B-H
3. Delete columns
4. CTRL+Z & wait

Actual Results:
Didn't even wait to finish

Expected Results:
4 seconds as before


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.0.0.0.alpha1+ (x64)
Build ID: 9a7c5d38a7a43c75c0f3d2f0c725196e916d0260
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win; 
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2020-05-23 16:20:23 UTC
Created attachment 161194 [details]
Example file
Comment 2 Telesto 2020-05-23 16:21:10 UTC
Bisected to
author	Kohei Yoshida <kohei.yoshida@gmail.com>	2013-07-09 22:56:30 -0400
committer	Kohei Yoshida <kohei.yoshida@gmail.com>	2013-07-11 00:25:34 -0400
commit 4e10b2e26f4ac5e2a5ff28e2e3a1eedbf5f8ca61 (patch)
tree 64d0a67f0ce68bcc6c5276faf9c243b28f9f2832
parent eca428bf03ed71279c985ce6862570f7c8ebacb3 (diff)
Grouping of formula cells during undo.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=4e10b2e26f4ac5e2a5ff28e2e3a1eedbf5f8ca61
Comment 3 b. 2020-05-24 08:38:29 UTC Comment hidden (obsolete)
Comment 4 Telesto 2020-05-24 12:34:40 UTC
(In reply to b. from comment #3)
> norepro with below ver., ~3 seconds, 
> 
> but your bisect result supports my impression that an immature
> implementation of shared formulas is responsible for plenty errors / bugs /
> issues since then, never really fixed but many patches and lots of cast
> around it ... :-(

The general issue is 
* lack of automatic tests on sample (data) files... So copy sample X to new sheet etc
* Test framework on probably Linux machines.. so Windows specific bug are invisible

There probably a good reason for the commit; with good intentions. However improving case A, makes case B worse.. Or uncovers another bug.. 

However without now what the comment attempt to do (for what case in mind).. it's only hard to tell. 


Note:
You did select the columns & used delete columns (there is no issue full column content is selected and deleted)
Comment 5 b. 2020-05-25 01:51:29 UTC
sorry, my fault, didn't check with win ... 

lin no repro, win full! repro, 

6.2.8.2: had to kill the task, 

7.0.0.0.a1+: long time, 

Version: 7.0.0.0.alpha1+ (x64)
Build ID: b587de60d4e6aa96238766272d94f1499b22f696
CPU threads: 8; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: default; VCL: win; 
Locale: de-DE (de_DE); UI: en-US
Calc:
Comment 6 Telesto 2020-05-27 21:53:46 UTC
*** Bug 133114 has been marked as a duplicate of this bug. ***
Comment 7 m_a_riosv 2020-10-02 17:41:51 UTC
Works fine for me, a few of seconds.
Version: 7.1.0.0.alpha0+ (x64)
Build ID: dec9a123867dcd0fea4683beeb3b4b6659f926f3
CPU threads: 4; OS: Windows 10.0 Build 20180; UI render: Skia/Vulkan; VCL: win
Locale: es-ES (es_ES); UI: es-ES
Calc: threaded

So please retest, in any why critical.
Comment 8 Telesto 2020-10-02 19:20:23 UTC
(In reply to m.a.riosv from comment #7)
> Works fine for me, a few of seconds.
> Version: 7.1.0.0.alpha0+ (x64)
> Build ID: dec9a123867dcd0fea4683beeb3b4b6659f926f3
> CPU threads: 4; OS: Windows 10.0 Build 20180; UI render: Skia/Vulkan; VCL:
> win
> Locale: es-ES (es_ES); UI: es-ES
> Calc: threaded
> 
> So please retest, in any why critical.

It's fine for me too
Version: 7.1.0.0.alpha0+ (x64)
Build ID: 7f16cabf00daa30e9284d2fb2494bd341352c25e
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: nl-NL
Calc: CL

FWIW: I didn't touch the priority.. and the one who did isn't in the CC list