Bug 133368 - Links to Extensions site need to be updated in core after recent site update
Summary: Links to Extensions site need to be updated in core after recent site update
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: LibreOffice (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Stéphane Guillou (stragu)
URL:
Whiteboard: target:7.3.0
Keywords: difficultyBeginner, easyHack, skillDesign, topicUI
Depends on:
Blocks:
 
Reported: 2020-05-25 10:50 UTC by Mike Kaganski
Modified: 2021-07-08 04:55 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Kaganski 2020-05-25 10:50:16 UTC
Ref: https://ask.libreoffice.org/en/question/246238

Since recent Extensions site update, some links from LO to that site don't work (result in "Page not found", like in Tools->Language->Mode Dictionaries Online), or lead to main site instead of some category (as in Tips of the Day dialog's https://extensions.libreoffice.org/extensions?getCategories=Dictionary).

The links likely need update. The list of those in code:

https://opengrok.libreoffice.org/search?project=core&full=%22extensions.libreoffice.org%22

The related redmine task (that is to provide redirection for old-style URLs to allow older LO versions to continue pointing to correct places):

https://redmine.documentfoundation.org/issues/3205

Note that even if the redmine task is accepted and implemented, this bug likely still needs fixing - at least to not include different kinds of links to the same pages, like https://extensions.libreoffice.org/extensions?getCategories=Dictionary vs https://extensions.libreoffice.org/dictionaries/ .
Comment 1 Christian Lohmaier 2020-05-25 11:01:55 UTC
I'll create links/redirects on the new extensions site, but arguably the links in LibreOffice code should not only be unified, but also be changed to be hub.libreoffice.org ones.
Comment 2 Sebastiaan Veld 2020-07-06 10:42:47 UTC
I assume my issue is related to this bug: 

Starting LO 7.0.0.1 in the Start Center, then click the Extension button at the bottom of the screen this redirects to "https://extensions.libreoffice.org/nl" which does not exist and shows a "Page not found" error in the browser. I if I change the URL to "https://extensions.libreoffice.org/" I get to see the Extensions page.

Version: 7.0.0.1 (x64)
Build ID: 04ba7e3f1e51af6c5d653e543a620e36719083fd
CPU-threads: 4; Besturingssysteem: Windows 10.0 Build 18363; UI-render: Skia/Vulkaan; VCL: win
Locale: nl-NL (nl_NL); GI: nl-NL
Calc: threaded
Comment 3 Stéphane Guillou (stragu) 2021-07-03 01:05:13 UTC Comment hidden (off-topic)
Comment 4 Stéphane Guillou (stragu) 2021-07-03 11:17:51 UTC Comment hidden (off-topic)
Comment 5 Heiko Tietze 2021-07-05 07:07:32 UTC
One code pointer in c0, the "Extensions" button's reference is defined in postprocess/CustomTarget_registry.mk at STARTCENTER_ADDFEATURE_URL (and STARTCENTER_TEMPLREP_URL, which seems we can remove).

Check the other hub references in Common.xcu how to implement this one.

The hub is requested in rdm#3530.
Comment 6 Stéphane Guillou (stragu) 2021-07-06 15:05:30 UTC
Heiko, are you saying that, ideally, it _shouldn't_ be defined in CustomTarget_registry.mk, but _should_ be defined in Common.xcu instead?

About the Redmine ticket: Christian said that for now, the two existing redirects are enough: https://gerrit.libreoffice.org/c/core/+/118340/4#message-b2c7db6df60ddc40c4480508d380d253812f5fdc

So this commit should be enough to close this ticket for now, right? https://gerrit.libreoffice.org/c/core/+/118340
Comment 7 Heiko Tietze 2021-07-06 16:13:00 UTC
(In reply to stragu from comment #6)
> https://gerrit.libreoffice.org/c/core/+/118340

Commented there
Comment 8 Commit Notification 2021-07-07 10:46:00 UTC
Stéphane Guillou committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/c4b5cdd54d9eb70c6ae56d4148674fc07469f79d

tdf#133368: update extensions website URLs and use https

It will be available in 7.3.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Stéphane Guillou (stragu) 2021-07-08 04:55:40 UTC
Marking this as fixed by the mentioned commit.
If further refinements are needed, and depending on when/if this Redmine task get fixed, we can open new, more specific easy hacks.

https://redmine.documentfoundation.org/issues/3530