Bug 133384 - UI: The attribute dialog in the search and replace dialog can be opened multiple times
Summary: UI: The attribute dialog in the search and replace dialog can be opened multi...
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.0.0.0.alpha1+
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.1.0 target:7.0.0.1
Keywords:
Depends on:
Blocks:
 
Reported: 2020-05-25 18:04 UTC by Telesto
Modified: 2020-06-15 20:44 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-05-25 18:04:33 UTC
Description:
UI: The attribute dialog in the search and replace dialog can be opened multiple times

Steps to Reproduce:
1. Open Writer
2. CTRL+H
3. Press Attribute button
4. Move the dialog a little (if needed)
5. Press again again again

Actual Results:
Opens a new dialog every time

Expected Results:
Only a single dialog


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.0.0.0.alpha1+ (x64)
Build ID: b587de60d4e6aa96238766272d94f1499b22f696
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win; 
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Xisco Faulí 2020-06-15 15:19:33 UTC
Reproduced in

Version: 7.1.0.0.alpha0+
Build ID: 37d5cccceb9f02d60de326f5b1fc5098dc004739
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: x11
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

@Caolán, I thought you might be interested in this issue
Comment 2 Caolán McNamara 2020-06-15 15:52:35 UTC
modal bit should be set
Comment 3 Commit Notification 2020-06-15 20:06:39 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/087ca4d091ad435f5a7b223dd57f75352b303db2

tdf#133384 attributes dialog should be modal

It will be available in 7.0.0.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2020-06-15 20:06:48 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/24cdfe062c8540b4285c9e24556fcb2ece01a7a4

tdf#133384 attributes dialog should be modal

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.