Bug 133608 - Russian dictionaries UTF-8 conversion
Summary: Russian dictionaries UTF-8 conversion
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Linguistic (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All Linux (All)
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-02 16:16 UTC by sheshukov.ilya
Modified: 2020-06-04 13:37 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Patch (5.65 MB, patch)
2020-06-02 16:17 UTC, sheshukov.ilya
Details

Note You need to log in before you can comment on or make changes to this bug.
Description sheshukov.ilya 2020-06-02 16:16:33 UTC
Description:
This patch converts ru_RU/hyph_ru_RU.dic, ru_RU/ru_RU.aff, ru_RU/ru_RU.dic from KOI8-R to UTF-8.


Steps to Reproduce:
In WebkitGTK-based program (e.g. Foliate) open a Russian document.

Actual Results:
No hyphenation.

Expected Results:
Program uses hyphenation rules from hyph_ru_RU.dic


Reproducible: Always


User Profile Reset: No



Additional Info:
Basically, this is needed because some programs (e.g. flatpaked WebkitGTK which uses this dictionary and everything depending on it) can't use dictionaries and hyphenation rules in KOI8-R. 
Converting those to UTF-8 solves this issue and doesn't seem to break anything else.

Not an LO issue specifically, but it causes issues in a lot of other software.
Comment 1 sheshukov.ilya 2020-06-02 16:17:56 UTC
Created attachment 161533 [details]
Patch

Result of git format-patch
Comment 2 Julien Nabet 2020-06-02 17:18:24 UTC
Andras: thought you might be interested in this one since it concerns dictionaries.
Comment 3 Andras Timar 2020-06-04 09:56:37 UTC
Thanks for this contribution. I tried to apply the patch on master branch:

git am attachment.cgi\?id\=161533
Applying: Converted Russian dictionaries from KOI8-R to UTF-8
error: patch failed: ru_RU/ru_RU.dic:1
error: ru_RU/ru_RU.dic: patch does not apply
Patch failed at 0001 Converted Russian dictionaries from KOI8-R to UTF-8

Could you please publish the command that you used to convert the files, alternatively could you please submit your patch to gerrit? https://wiki.documentfoundation.org/Development/gerrit/SubmitPatch
Comment 4 sheshukov.ilya 2020-06-04 13:12:56 UTC
(In reply to Andras Timar from comment #3)
> Thanks for this contribution. I tried to apply the patch on master branch:
> 
> git am attachment.cgi\?id\=161533
> Applying: Converted Russian dictionaries from KOI8-R to UTF-8
> error: patch failed: ru_RU/ru_RU.dic:1
> error: ru_RU/ru_RU.dic: patch does not apply
> Patch failed at 0001 Converted Russian dictionaries from KOI8-R to UTF-8
> 
> Could you please publish the command that you used to convert the files,
> alternatively could you please submit your patch to gerrit?
> https://wiki.documentfoundation.org/Development/gerrit/SubmitPatch

Ok, submitted it to gerrit https://gerrit.libreoffice.org/c/dictionaries/+/95515
Comment 5 Andras Timar 2020-06-04 13:37:21 UTC
Pushed, thanks.