Bug 133675 - Hyperlink dialog: select "Frame" by clicking the textbox
Summary: Hyperlink dialog: select "Frame" by clicking the textbox
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.0 all versions
Hardware: All All
: medium enhancement
Assignee: Andreas Heinisch
URL:
Whiteboard: target:7.5.0 target:7.4.0.0.beta2
Keywords:
Depends on:
Blocks: Hyperlink-Dialog
  Show dependency treegraph
 
Reported: 2020-06-04 14:04 UTC by bugzilla2
Modified: 2022-12-30 13:09 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description bugzilla2 2020-06-04 14:04:20 UTC
Description:
In the hyperlink dialog in Writer, it is not possible to open the drop-down-list for the "Frame"-type by clicking the textbox. Its only possible by clicking the small triangle next to the textbox.

Steps to Reproduce:
1. Open a new Writer document
2. Click INSERT -> HYPERLINK
3. Click the textbox next to "Frame"

Actual Results:
Nothing happens besides the cursor blinking in that box

Expected Results:
I wish the drop-down-list with the available frame-options would be displayed


Reproducible: Always


User Profile Reset: No



Additional Info:
.
Comment 1 bugzilla2 2020-06-04 14:06:09 UTC
My other hyperlink-dialog-related Bug: 123123
Comment 2 Samuel Mehrbrodt (allotropia) 2020-06-04 14:41:07 UTC
Cannot reproduce with LO 6.4.2.2 on Windows. Can you try with a recent version please?
Comment 3 Samuel Mehrbrodt (allotropia) 2020-06-04 14:43:37 UTC
Ah sorry, I tried the "Form" dropdown instead of the "Frame" combo box.

The reason this does not pop down is, that it's a different widget. It's a combo box with editable content.

@UX: Does it make sense to replace the "Frame" combo box with a dropdown?
Comment 4 Heiko Tietze 2020-06-05 10:14:27 UTC
(In reply to Samuel Mehrbrodt (CIB) from comment #3)
> @UX: Does it make sense to replace the "Frame" combo box with a dropdown?

If the number of items is limited to the predefined the dropdown is the correct widget. And I don't see what a user can enter here. So yes, please make it a dropdown.
Comment 5 bugzilla2 2020-06-05 10:30:21 UTC
Well, a serious webdesigner could need custom frame-targets, but I doubt, that a serious webdesigner uses Writer for HTML-Editing ;)
Comment 6 bugzilla2 2021-02-18 13:14:35 UTC
The box is still a editbox and not a dropdown in 7.0 and 7.1 series
Comment 7 Andreas Heinisch 2022-06-11 09:50:16 UTC
Could the frame also be empty? Or should it have a default target frame?
Comment 8 bugzilla2 2022-06-11 09:56:28 UTC
Thanks for taking that bug :)
The default should be empty.
Comment 9 bugzilla2 2022-06-11 10:00:02 UTC
Btw, "empty" means, that no tag is written at all. So the resulting code should be:

<a href="foo">foo</a>

and NOT

<a href="foo" target="">foo</a>

Not sure if that has something to do with replacing the combo-box though :D
Comment 10 Andreas Heinisch 2022-06-11 10:01:25 UTC
I will check if the target won't be written if the traget is not empty.
Comment 11 Commit Notification 2022-06-13 12:32:25 UTC
Andreas Heinisch committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/e8f97879c4e677107551692fa88b0791f70bd413

tdf#133675 - Hyperlink dialog: change frame widtget from editbox to dropdown

It will be available in 7.5.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Commit Notification 2022-06-14 00:36:55 UTC
Andreas Heinisch committed a patch related to this issue.
It has been pushed to "libreoffice-7-4":

https://git.libreoffice.org/core/commit/f78ce524ad8efce5181a47b63d01b4439a3fd03c

tdf#133675 - Hyperlink dialog: change frame widtget from editbox to dropdown

It will be available in 7.4.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 13 bugzilla2 2022-06-28 11:53:55 UTC
The patch sems to work fine. Tested with current master, the selection of the target is easier now.

I also tested what happens, if you open a html-file that has a custom target -> nothing, no crash, or something :)
Of course it doesn't "display" the custom target, but thats ok. Writer breaks that html file so much, that the target would be the least problem. So no web-developer would like to edit his html-files with Writer, exept some noobs maybe, and they should be fine with the predefined targets anyway.
Comment 14 Stéphane Guillou (stragu) 2022-12-30 13:09:56 UTC
Fix verified in:

Version: 7.4.3.2 / LibreOffice Community
Build ID: 1048a8393ae2eeec98dff31b5c133c5f1d08b890
CPU threads: 8; OS: Linux 5.15; UI render: default; VCL: gtk3
Locale: en-AU (en_AU.UTF-8); UI: en-US
Calc: threaded

Thanks Andreas!