Bug 133713 - Bullets and numbering can not be activated from the dialog, but only with the toolbar button
Summary: Bullets and numbering can not be activated from the dialog, but only with the...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
6.3.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Justin L
URL:
Whiteboard: target:7.4.0 target:7.3.0.0.beta2
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Impress-Bullet-Numbering-Dialog
  Show dependency treegraph
 
Reported: 2020-06-05 20:50 UTC by stephen.bungay42
Modified: 2021-12-23 11:39 UTC (History)
6 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description stephen.bungay42 2020-06-05 20:50:36 UTC
Description:
Can't create a bulleted list in a text box in Libre Draw.


Steps to Reproduce:
1.Create a Libre draw document.
2. Put a text box on the document and type in a list, terminating each item in the list with a carriage return.
3. Select all items in the list, right click to bring up the context menu, select bullets and numbering and apply your choice.

Actual Results:
No bullets or numbers appeared.

Expected Results:
Bullets or numbers (whatever the user selects) should appear at the first of each paragraph, thus creating a bullet-point list.


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 6.4.4.2
Build ID: 3d775be2011f3886db32dfd395a6a6d1ca2630ff
CPU threads: 4; OS: Linux 4.4; UI render: default; VCL: x11; 
Locale: en-CA (en_CA.UTF-8); UI-Language: en-US
Calc: threaded
Comment 1 Abhi 2020-06-22 15:38:11 UTC
Thank you for reporting the bug. I can confirm that the bug is present in both version 6.4.4.2(Build ID: 3d775be2011f3886db32dfd395a6a6d1ca2630ff) and version 7.1.0.0.alpha0(Build ID: 4c4b3218b8595a9809ffade0cfd064f3d9335dff)
Comment 2 Buovjaga 2020-06-25 14:09:53 UTC
This is seen both with the menu Format - Bullets and numbering and right-click context menu - so when applying with the dialog.

Bibisected with Linux 6.3 repo to https://git.libreoffice.org/core/+/1c3f71c1e5a7b3d6935505a4a6f96c8948187910%5E!/
tdf#120905 Remove temporary uno command.

Adding Cc: to Gülşah Köse
Comment 3 Justin L 2021-11-19 13:13:43 UTC
repro 7.3+
-also in impress

[Writer and Calc textboxes does not allow numbering]
Comment 4 Justin L 2021-11-19 15:00:43 UTC Comment hidden (no-value)
Comment 5 Justin L 2021-12-15 12:57:53 UTC
The old way of doing things (FuOutlineBullet) was removed with

commit 5ff162bede44b77cb19e5ff6571b6e34f228d9fb
Author: Gülşah Köse on Mon May 27 23:49:41 2019 +0300
    tdf#120905 Remove old FuOutlineBullet dialog code.
    
    Change-Id: I4bd0986f23414edc857ca890f6437c6029116e72
    Reviewed-on: https://gerrit.libreoffice.org/73070

In that version, an OK result called
      pOLV->EnableBullets();
but there is nothing like that in the new FuBulletsAndPosition.


EnableBullets() itself was removed in 
commit cae829e9c1394851fc88829d5197460929c2792a
Author: Noel Grandin on Tue Jun 11 14:05:02 2019 +0200
    loplugin:unusedmethods
Comment 6 Justin L 2021-12-16 07:19:29 UTC
proposed fix at http://gerrit.libreoffice.org/c/core/+/126904
Comment 7 Commit Notification 2021-12-21 07:31:29 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/12832284318125b8649f6a67e3aa12aa953afdfb

tdf#133713 sd: bullets and numbering should enable it

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2021-12-21 08:55:35 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/d181d828d9a3490cefc3a9b41fbda2d5b07b08c3

tdf#133713 sd: bullets and numbering should enable it

It will be available in 7.3.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2021-12-21 23:27:21 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6dbe55d34ad65627ef37f10dfdb548a717bb8c78

tdf#133713: sd: Add UItest

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 BogdanB 2021-12-23 11:39:31 UTC
Working well. Thanks

Version: 7.3.0.1.0+ (x64) / LibreOffice Community
Build ID: 821e5733ce2149544fb6ff0b3d39923340f93fa7
CPU threads: 4; OS: Windows 10.0 Build 19044; UI render: Skia/Raster; VCL: win
Locale: ro-RO (ro_RO); UI: en-US
Calc: threaded