Bug 134204 - SW UI: inheriting styles not updated (until reload) when fontsize+some other attribute are changed in paragraph style dialog (autostyle related?).
Summary: SW UI: inheriting styles not updated (until reload) when fontsize+some other ...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: notBibisectable
Depends on:
Blocks: Regressions-DrawingLayer-FillStyles
  Show dependency treegraph
 
Reported: 2020-06-21 18:43 UTC by Telesto
Modified: 2023-08-21 23:33 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file (858.99 KB, application/vnd.oasis.opendocument.text)
2020-06-21 18:44 UTC, Telesto
Details
134204_red.odt: example document that doesn't use highlight. (860.34 KB, application/vnd.oasis.opendocument.text)
2021-03-24 07:28 UTC, Justin L
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-06-21 18:43:53 UTC
Description:
Area color not properly removed (properly repainted) after changing style settings

Steps to Reproduce:
1. Open the attached file
2. Sidebar -> Paragraph Styles
3. Modify default paragraph style 
4. Disable area color (in tab)
5. Change fontsize to 10,5

Actual Results:
Headings + Footer have still orange look (save and reload will fix)

Expected Results:
Shouldn't be so


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.1.0.0.alpha0+ (x64)
Build ID: 43c60ce1ac7629a1462e927e6ff937469f58f743
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2020-06-21 18:44:05 UTC
Created attachment 162267 [details]
Example file
Comment 2 Telesto 2020-06-21 18:47:30 UTC
Repro with
Version: 6.0.6.0.0+
Build ID: c30963b8b4bbbe42a24b97aafa161eff9d7ccdd4
CPU threads: 4; OS: Windows 6.3; UI render: default; 
Locale: nl-NL (nl_NL); Calc: CL

and with
4.4.7.2

but not with
Versie 4.0.0.3 (Bouw-id: 7545bee9c2a0782548772a21bc84a9dcc583b89)
Comment 3 BogdanB 2020-06-21 20:10:38 UTC
Confirm it

Version: 6.4.4.2
Build ID: 3d775be2011f3886db32dfd395a6a6d1ca2630ff
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3; 
Locale: ro-RO (ro_RO.UTF-8); UI-Language: en-US
Calc: threaded
Comment 4 Aron Budea 2020-07-05 04:48:06 UTC
Bibisected using repos bibisect-43max and bibisect-44max.

After the following commit, no orange color is shown after opening the file:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=4a0b5e569d070c286daefb0fdfe45c0dd15d241c
author		Armin Le Grand <alg@apache.org>	2014-04-17 16:44:58 +0000
committer	Miklos Vajna <vmiklos@collabora.co.uk>	2014-04-25 13:08:06 +0200

"i#124638 support for DrawingLayre FillStyle for GraphicFrames and ..."

Then after this commit, the background color is back, but the behavior is already buggy:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=7d9bb549d498d6beed2c4050c402d09643febdfa
author		Armin Le Grand <alg@apache.org>	2014-06-02 15:00:50 +0000
committer	Miklos Vajna <vmiklos@collabora.co.uk>	2014-07-01 13:30:09 +0200

"Related: #i124638# Second step of DrawingLayer FillAttributes..."

These commits seem to deal with the affected functionality, but I can't verify that, and it might be an implementation error in that case, too. Marking as notBibisectable.
Comment 5 Justin L 2021-03-24 07:26:29 UTC
The last step of changing the fontsize is CRUCIAL to reproducing this. Just turning off the area colour by itself works fine.

repro 7.2+

Footnotes is meant instead of footer.  The ABC's in the Heading 1 paragraph style, and the footnote content remain with a yellow background. This suggests to me a layout bug.
Comment 6 Justin L 2021-03-24 07:28:49 UTC
Created attachment 170679 [details]
134204_red.odt: example document that doesn't use highlight.

It looks like this is an inherited problem from OOo. Using this example avoids the complications of the changing background.  I saw the same behaviour in bibisect-43all's LO 3.5 - which is as far back as I can test with Ubuntu 16.04.
Comment 7 QA Administrators 2023-03-25 03:24:05 UTC Comment hidden (obsolete, spam)
Comment 8 Justin L 2023-05-18 21:00:44 UTC
repro 7.6+

(In reply to Justin L from comment #6)
> 134204_red.odt: example document that doesn't use highlight.
Steps to reproduce:
1.) open comment 6's attachment 170679 [details]
2.) Go to the default paragraph style dialog, Font Effects tab and change the red font color to something else. Then go to the font tab and change the font size. (the order doesn't matter - can change the font size first)

--> result is that Heading 1 style text and the footnote text don't change.

Doing them one at a time (instead of as a combination) has no problem.
Using italic or bold along with font color has no problem.

It seems to be specific to the font size in combination with one or more other attributes.

I was easily able to reproduce this in a new document with just two paragraphs. One was with a Title paragraph style, and the other was default paragraph style.
Comment 9 Justin L 2023-08-21 23:33:42 UTC
repro 24.2+