Bug 134242 - Dragging an image slow in GDI mode (part 2)
Summary: Dragging an image slow in GDI mode (part 2)
Status: RESOLVED WORKSFORME
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
7.1.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, perf, regression
Depends on:
Blocks: Image-Handling
  Show dependency tree / graph
 
Reported: 2020-06-22 19:32 UTC by Telesto
Modified: 2022-09-16 07:11 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:

Attachments
Bibisect log (2.78 KB, text/plain)
2020-06-22 19:33 UTC, Telesto 		Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-06-22 19:32:26 UTC 
Description:
Dragging an image slow in GDI mode (part 2)

Steps to Reproduce:
1. Open attachment 162322 [details]
2. Drag the image around

Actual Results:
Choppy/slow

Expected Results:
Smooth


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.1.0.0.alpha0+ (x64)
Build ID: 43c60ce1ac7629a1462e927e6ff937469f58f743
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2020-06-22 19:33:47 UTC 
Created attachment 162324 [details]
Bibisect log

Bisected to
author	Mike Kaganski <mike.kaganski@collabora.com>	2020-05-28 20:13:50 +0200
committer	Mike Kaganski <mike.kaganski@collabora.com>	2020-05-29 10:31:40 +0200
commit c644b2b4abe3051c0e0fc91674154c796fd326f6 (patch)
tree 391c0d15daa02bae90325a2d44b9a4cbbba01756
parent f510bdfa98014ca0ae596dcd0dfd487cfc90f3eb (diff)
Use buffer with alpha in VclProcessor2D::RenderUnifiedTransparencePrimitive2D
This allows UnifiedTransparencePrimitive2D to produce truly transparent image,
usable later in the stack - specifically by glow and soft edge effect.

https://cgit.freedesktop.org/libreoffice/core/commit/?id=c644b2b4abe3051c0e0fc91674154c796fd326f6
Comment 2 Buovjaga 2020-11-09 06:15:02 UTC 
Repro

Adding Cc: to Mike Kaganski

Arch Linux 64-bit
Version: 7.1.0.0.alpha1+
Build ID: c9b320c32aceab7e22d381b688e7b44030e01c2d
CPU threads: 8; OS: Linux 5.9; UI render: default; VCL: kf5
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Built on 8 November 2020

Version: 7.1.0.0.alpha1+ (x64)
Build ID: b61bf7c7cfcf97a5ade6d130873af146670bc2ee
CPU threads: 4; OS: Windows 10.0 Build 19041; UI render: default; VCL: win
Locale: fi-FI (fi_FI); UI: en-US
Calc: threaded
Comment 3 Julien Nabet 2022-09-15 19:38:18 UTC 
On pc Debian x86-64 with master sources updated today or with LO Debian package 7.4.1.1 + kf5 rendering, I don't reproduce slowliness.

Could someone give a new try with recent LO version? Knowing that if 7.3.6 is slow, 7.4.1 should be tested since 7.3 branch is almost EOL.
Comment 4 Buovjaga 2022-09-16 07:11:31 UTC 
I compared with Windows bibisect repo 7.1 and the problem is indeed fixed (also on Linux 7.4)!

Version: 7.5.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 922b79a0f5a9151a6870ba395abcac5b54055275
CPU threads: 2; OS: Windows 10.0 Build 19044; UI render: default; VCL: win
Locale: fi-FI (fi_FI); UI: en-US
Calc: threaded Jumbo