Bug 134271 - Undoing the deletion of a row exceptionally slow compared to rejecting deletion of a row
Summary: Undoing the deletion of a row exceptionally slow compared to rejecting deleti...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
4.0.0.3 release
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: perf
Depends on:
Blocks: Undo-Redo Cell-Add-Delete
  Show dependency treegraph
 
Reported: 2020-06-23 19:14 UTC by Telesto
Modified: 2024-03-03 03:15 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Bibisect log (3.83 KB, text/plain)
2020-06-25 14:30 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-06-23 19:14:22 UTC
Description:
Undo of deleting a row exceptional slow compared to (insert/delete/ or reject delete row)

Steps to Reproduce:
1. Open attachment 161647 [details]
2. Copy column A-C
3. Paste it always next the other, so DEF GHI KLM NOP (needed to feel the performance degradation; so create more if you want to wait longer.. less if you want to wait sorter.. 
4. Insert a row -> 3 seconds -> create more columns; not really difference
5. Delete the row -> 7 seconds -> This tends to decrease with more columns
6. Undo the delete of a column -> 10 seconds -> This tends to decrease with more columns
7. Now repeat step 4/5 with tracking changes 
* Inserting 2 seconds (faster?)
* Deleting 5 seconds (faster)
* Manage track changes reject -> 6 seconds

Note replace rows for columns.. and the idea is the same

Actual Results:
delete and undo slow compared to insertion and in comparison with tracking changes  enabled

Expected Results:
Equal to tracking changes enabled..and maybe even optimize tracking changes delete/reject (also showing the 'same' speed decrease trend. Does needs a double the amount of column to be annoying; again some quadratic decrease.. only starting with a lower number?)


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.1.0.0.alpha0+ (x64)
Build ID: aadcd6f90916bd2b9734ae793141d0c77cc5b46c
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

and in
4.0.0.3 (4.2 and 4.4.7.2).. Did check 5.0 - 7.1.
Comment 1 Telesto 2020-06-23 21:34:09 UTC
Interesting .. no delay when inserting/deleting a row in Linux with 4.2 (started with 4.3)
Comment 2 Telesto 2020-06-25 14:30:32 UTC Comment hidden (obsolete)
Comment 3 Telesto 2020-06-25 14:32:46 UTC
Moving 4/5 to a separate bug 134301
Comment 4 Bob Vo 2020-07-22 01:56:33 UTC
*** Bug 134301 has been marked as a duplicate of this bug. ***
Comment 5 Xisco Faulí 2020-07-22 13:33:38 UTC
(In reply to Telesto from comment #0)
> Description:
> Undo of deleting a row exceptional slow compared to (insert/delete/ or
> reject delete row)
> 
> Steps to Reproduce:
> 1. Open attachment 161647 [details]
> 2. Copy column A-C
> 3. Paste it always next the other, so DEF GHI KLM NOP (needed to feel the
> performance degradation; so create more if you want to wait longer.. less if
> you want to wait sorter.. 
> 4. Insert a row -> 3 seconds -> create more columns; not really difference

Insert a row where? top? middle? bottom?
Comment 6 QA Administrators 2021-01-19 04:11:22 UTC Comment hidden (obsolete)
Comment 7 QA Administrators 2021-02-19 04:23:22 UTC Comment hidden (obsolete)
Comment 8 Telesto 2021-02-19 14:35:40 UTC
(In reply to Xisco Faulí from comment #5)
> Insert a row where? top? middle? bottom?

Doesn't matter, some in the middle
Comment 9 Xisco Faulí 2021-02-22 09:38:32 UTC
Hi Telesto,
Could you please try again in a master build after https://cgit.freedesktop.org/libreoffice/core/commit/?id=b9921adae997579915b4600c688719620f9adaf6 ?
Comment 10 Telesto 2021-02-28 10:39:01 UTC
Undo is still slow
Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 385808a2dff7300ec0120fdd5e8acfad8f86e50d
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

I would say bug 134301 got fixed, but not this one
Comment 11 Telesto 2021-02-28 10:43:58 UTC
(In reply to Telesto from comment #10)
> Undo is still slow
> Version: 7.2.0.0.alpha0+ (x64) / LibreOffice Community
> Build ID: 385808a2dff7300ec0120fdd5e8acfad8f86e50d
> CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
> Locale: nl-NL (nl_NL); UI: en-US
> Calc: CL
> 
> I would say bug 134301 got fixed, but not this one

Actually everything still the same as comment 0
Comment 12 Buovjaga 2022-03-03 14:32:58 UTC
Undo took 8 secs
Rejecting took 2,5 secs

I deleted a random row, not the one that I inserted.

Version: 7.4.0.0.alpha0+ (x64) / LibreOffice Community
Build ID: 04f9a8957c04b8c5abaa58140328d2c83381f4ff
CPU threads: 2; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: fi-FI (fi_FI); UI: en-US
Calc: threaded Jumbo
Comment 13 QA Administrators 2024-03-03 03:15:07 UTC
Dear Telesto,

To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year.

There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present.

If you have time, please do the following:

Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/

If the bug is present, please leave a comment that includes the information from Help - About LibreOffice.
 
If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice.

Please DO NOT

Update the version field
Reply via email (please reply directly on the bug tracker)
Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not 
appropriate in this case)


If you want to do more to help you can test to see if your issue is a REGRESSION. To do so:
1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/

2. Test your bug
3. Leave a comment with your results.
4a. If the bug was present with 3.3 - set version to 'inherited from OOo';
4b. If the bug was not present in 3.3 - add 'regression' to keyword


Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa

Thank you for helping us make LibreOffice even better for everyone!

Warm Regards,
QA Team

MassPing-UntouchedBug