Bug 134302 - Memory usage from 221 MB to 350 MB on file open & scroll (GDI)
Summary: Memory usage from 221 MB to 350 MB on file open & scroll (GDI)
Status: RESOLVED NOTABUG
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Draw (show other bugs)
Version:
(earliest affected)
7.0.0.0.beta1+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-06-25 15:00 UTC by Telesto
Modified: 2020-06-26 08:47 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Bibisect log (3.52 KB, text/plain)
2020-06-25 15:02 UTC, Telesto
Details
Example file (8.05 MB, application/vnd.oasis.opendocument.graphics)
2020-06-25 15:10 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-06-25 15:00:54 UTC
Description:
Memory usage from 221 MB to 350 MB on file open & scroll

Steps to Reproduce:
1. Open the attached file while monitoring memory usage in GDI
2. On open 350MB -> Drops back to 285 or maybe even 220 MB
3. Scroll -> up again

Actual Results:
350 mb on file open / scroll. inserting a shape

Expected Results:
Little less. Especially if this affects Skia (with it's own additional buffering). File open is at 440 MB with Skia Raster (pretty OK with Vulkan)


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.1.0.0.alpha0+ (x64)
Build ID: 006c65bbd472cb1d7d44e095714e28190b76be0d
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2020-06-25 15:02:02 UTC
Created attachment 162408 [details]
Bibisect log

Bisected to

author	Armin Le Grand (Collabora) <armin.le.grand@me.com>	2020-02-21 16:58:17 +0100
committer	Armin Le Grand <Armin.Le.Grand@me.com>	2020-02-21 20:16:59 +0100
commit 828504974d70111e4a35b31d579cf42fe660a660 (patch)
tree 4c2f7720b3efaecf55b8fa7b9b3eeccb278160e6
parent 813cde918338bccc4f711230616340cad2c1d4a0 (diff)
tdf#130768 speedup huge pixel graphics Cairo
For more information/documentation please
refer to the bugzilla task

Fixed a crash in CppunitTest_desktop_lib which
led to a missing test of mpGraphics in
OutputDevice::DrawTransformedBitmapEx. Other
public methods test that and one of the goals
of the cange was to use that method more often,
so this may have never been detected before

https://cgit.freedesktop.org/libreoffice/core/commit/?id=828504974d70111e4a35b31d579cf42fe660a660
Comment 2 Telesto 2020-06-25 15:10:23 UTC
@Buovjaga,
At some point there needs some graph how everything is hooked into each other :-).If GDI changes will/could affect Skia etc. Skia Raster has a buffering to compensate for perf issues.. but if there are others in the same code path asking for more - for what ever reason -  it gets cumulative.. not able to evaluate.. of course.. 

Anyhow GDI memory usage increased.. and I'm not seeing any perf improvement on GDI side
Comment 3 Telesto 2020-06-25 15:10:45 UTC
Created attachment 162409 [details]
Example file
Comment 4 Xisco Faulí 2020-06-25 15:51:43 UTC
Could be related, or even a dupe of bug 134241
Comment 5 Buovjaga 2020-06-25 18:18:46 UTC
Scrolling does nothing for me, but I notice it jump back up with zoom. I don't understand what is supposed to be the problem, though.
Comment 6 Telesto 2020-06-25 18:23:35 UTC
(In reply to Buovjaga from comment #5)
> Scrolling does nothing for me, but I notice it jump back up with zoom. I
> don't understand what is supposed to be the problem, though.

1. Open the file with 6.4 and with 6.5 master in GDI mode (ideally Windows)
2. 220 MB with 6.4. With 6.5 350 MB on open. After load it will drop to 285 or 220, when scrolling it goes up again. When inserting a shape up again.. not happening with 6.4
Comment 7 Buovjaga 2020-06-25 18:31:42 UTC
(In reply to Telesto from comment #6)
> (In reply to Buovjaga from comment #5)
> > Scrolling does nothing for me, but I notice it jump back up with zoom. I
> > don't understand what is supposed to be the problem, though.
> 
> 1. Open the file with 6.4 and with 6.5 master in GDI mode (ideally Windows)
> 2. 220 MB with 6.4. With 6.5 350 MB on open. After load it will drop to 285
> or 220, when scrolling it goes up again. When inserting a shape up again..
> not happening with 6.4

1. Why not be content that this is the price to pay for "speedup huge pixel graphics Cairo"?
2. Bug 130768 is still open with hints to future improvements
Comment 8 Buovjaga 2020-06-26 08:47:55 UTC
Closing this after discussion in the dev chat.