Created attachment 162503 [details] Screenshot of "empty" crash dialog How to reproduce: 1. Invoke LibreOffice via the command line specifying a document that makes LibreOffice crash. 2. Observe how the "LibreOffice Document Recovery" dialog appears, even though no document has been nominally opened. 3. In particular note how the "The following files will be recovered" list is empty. I cannot reproduce this directly any longer, since the original issue (of LibreOffice choking on a presentation) has been fixed. In terms of pseudo code, the patch probably should look something like the following: - openDocumentRecoveryDialog(); + if ( globalstate.documentList.size() > 0 ) { + openDocumentRecoveryDialog(); + }
Has nothing to do with Base, the database-component of LO. Have set the component to LibreOffice.
@Heiko, @Caolán, any opinion on this issue ?
Sure, would be nice to suppress the recovery dialog in case of no documents. However, IIRC there is an empty entry in the list, perhaps when the document wasn't explicitly saved.
(In reply to Heiko Tietze from comment #3) > Sure, would be nice to suppress the recovery dialog in case of no documents. > However, IIRC there is an empty entry in the list, perhaps when the document > wasn't explicitly saved. Yes, in my case LibreOffice crashed trying to open a certain document when invoked from the command-line: libreoffice trouble.pptx So indeed nothing was ever saved in that session (nor successfully opened). When then invoking LibreOffice again the next time, the recovery dialog with an empty list of documents appears. That is what I suggest to avoid.
indeed yes, and besides, the recovery doesn't really works
Hello Gerald, Could you please try to reproduce it with the latest version of LibreOffice from https://www.libreoffice.org/download/libreoffice-fresh/ ? I have set the bug's status to 'NEEDINFO'. Please change it back to 'UNCONFIRMED' if the bug is still present in the latest version.
(In reply to Xisco Faulí from comment #6) > Hello Gerald, > Could you please try to reproduce it with the latest version of LibreOffice > from https://www.libreoffice.org/download/libreoffice-fresh/ ? > I have set the bug's status to 'NEEDINFO'. Please change it back to > 'UNCONFIRMED' if the bug is still present in the latest version. So far I could not reproduce which, alas, does not confirm the issue is gone. I just am lacking the prerequisite for step 1 of my original reproducer: "1. Invoke LibreOffice via the command line specifying a document that makes LibreOffice crash." Do you have a document that makes LibreOffice (head) crash upon start-up?
"Thanks" to bug #148735 I can confirm this is still an issue. The dialog in this case does not appear on the next startup, rather LibreOffice is shown in the same invocation, after the crash. Version: 7.4.0.0.alpha0+ / LibreOffice Community Build ID: e4243a140345a4bcd800217115b42667e277c6a3 CPU threads: 8; OS: Linux 5.17; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded
I'm not sure this should "go away". It is the only indication of "why did LibreOffice quit/restart?". Suggest WONTFIX What is happening here is that some kind of error (that doesn't affect the UI) bAllowRecoveryAndSessionManagement, and so is triggering a doPrepareEmergencySave. To avoid the dialog: svx/source/unodraw/recoveryui.cxx impl_doEmergencySave() - short nRet = xDialog->run(); + short nRet = DLG_RET_OK; // no restart request + if (pCore->getURLListAccess().size()) + nRet = xDialog->run(); + return (nRet==DLG_RET_OK_AUTOLUNCH);
(In reply to Justin L from comment #9) > I'm not sure this should "go away". nRet could default to two possibilities: -DLG_RET_OK: LibreOffice will just return to the command prompt, with no indication of why it failed to start. -DLG_RET_OK_AUTOLAUNCH: it will restart to a start center (or perhaps continually restart if the crash is caused by something in the init process.) I don't like either choice. I like the current dialog that informs the user that some kind of nasty error has occurred and waits for an ACK.
(In reply to Justin L from comment #10) > I don't like either choice. I like the current dialog that informs the user > that some kind of nasty error has occurred and waits for an ACK. Could there be a different dialog, maybe just a simple message box, in case there is not a single file to recover? A dialog with a list labeled "The following files will be recovered" which, alas is empty, is confusing for users. (Or the same dialog, just saying "no documents available for recovery"?)
(In reply to Gerald Pfeifer from comment #11) > A dialog with a list labeled "The following files will be recovered" > which, alas is empty, is confusing for users. I don't find it confusing at all. There was a crash, but no files will be recovered. Plus, this apparently only occurs with command-line starts, so approximately nobody will encounter this. WONTFIX.