Bug 134603 - UI Chart Axis title alignment options dependency changed
Summary: UI Chart Axis title alignment options dependency changed
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.2.0.3 release
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.1.0 target:7.0.0.2 target:6.4.6
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2020-07-07 10:19 UTC by NISZ LibreOffice Team
Modified: 2020-07-08 08:40 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot of the problem in Calc 6.2 (bad) and 6.1 (correct) (91.67 KB, image/png)
2020-07-07 10:19 UTC, NISZ LibreOffice Team
Details

Note You need to log in before you can comment on or make changes to this bug.
Description NISZ LibreOffice Team 2020-07-07 10:19:59 UTC
Created attachment 162748 [details]
Screenshot of the problem in Calc 6.2 (bad) and 6.1 (correct)

When setting Chart Axis title alignment, there are two mutually exclusive options: Vertically stacked and rotation by user specified degree value.
In newer versions of the UI disabling Vertically stacked disables the option to set a degree value, while in older versions enabling Vertically stacked disabled the option to set a degree value.

Steps to reproduce:
    1. Open attachment #162204 [details]
    2. Open the properties of the Y axis title “Horizontal long axis title which breaks”
    3. Go to Alignment and check the Vertically stacked box

Actual results:
The spinbox with Degrees gets enabled.

Expected results:
The spinbox with Degrees should be enabled when Vertically stacked is disabled (the default setting).

LibreOffice details:
Version: 7.1.0.0.alpha0+ (x64)
Build ID: 9af38b4504ccda57a0c32eb8bdd03e5a8ca29ddc
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: en-US (hu_HU); UI: en-US
Calc: CL

Also happens in:
Version: 6.2.0.3
Build ID: 98c6a8a1c6c7b144ce3cc729e34964b47ce25d62
CPU threads: 4; OS: Windows 6.3; UI render: GL; VCL: win; 
Locale: en-US (hu_HU); UI-Language: en-US
Calc: threaded

But not in:
Version: 6.1.0.3
Build ID: efb621ed25068d70781dc026f7e9c5187a4decd1
CPU threads: 4; OS: Windows 6.3; UI render: default; 
Locale: en-US (hu_HU); Calc: CL

Bibisected using bibisect-win32-6.2 to:
URL: https://cgit.freedesktop.org/libreoffice/core/commit/?id=9886625d02fee7692ff94e7c5b63dc2f51e31fa1 

author
Caolán McNamara <caolanm@redhat.com> Sat Oct 13 17:49:24 2018 +0100 
committer
Caolán McNamara <caolanm@redhat.com> Sat Oct 13 22:42:27 2018 +0200 

weld SchAlignmentTabPage

Adding CC to: Caolán McNamara
Comment 1 Caolán McNamara 2020-07-07 14:04:58 UTC
so the logic is simply reversed from what it should be then
Comment 2 Commit Notification 2020-07-07 18:56:14 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/0cde19038d7e264d7a184042f10a41574bda11f5

tdf#134603 [en|dis]able logic reversed

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 3 Commit Notification 2020-07-07 22:13:17 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/faa9ed4c2bc043cb2c483db799c2a696b66a5435

tdf#134603 [en|dis]able logic reversed

It will be available in 7.0.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2020-07-07 22:14:38 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-6-4":

https://git.libreoffice.org/core/commit/f1b1be9e3707b2e25557f4f781e3321051018683

tdf#134603 [en|dis]able logic reversed

It will be available in 6.4.6.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.