Bug 134604 - Library is placed in wrong place in the tree view
Summary: Library is placed in wrong place in the tree view
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: BASIC (show other bugs)
Version:
(earliest affected)
7.1.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.1.0
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2020-07-07 10:31 UTC by himajin100000
Modified: 2020-08-12 07:11 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description himajin100000 2020-07-07 10:31:50 UTC
Description:
see steps to reproduce

Steps to Reproduce:
0. Profile reset
1. Run LibreOffice
2. Tools->Macros->Organize Macros->Basic
3. you will see "Basic Macros" dialog. Expand to "My Macros/Standard/Module1" and keep the selection on Module1
4. Click "Organizer" button
5. In the "Modules" Tab, Expand the tree in "Macro From" to "My Macros/Standard/Module1" and keep the selection on Module1
6. Select "Libraries" Tab
7. Click "New Button"
8. With 'Library1' in the inputbox, click OK
9. Click "New Button"
10. With 'Library2' in the inputbox, click OK
11. Close the dialog. you will return to "Basic Macros"
12. Expand "Library1" in "Macro From"


Actual Results:
You will find "Library2" UNDER "Library1"

Expected Results:
"Library1", "Library2", and "Standard" libraries should be siblings in the tree


Reproducible: Always


User Profile Reset: Yes



Additional Info:
not reproducible with 7.0 RC1
--
bibisect-win64-7.1

$ git bisect log
# bad: [75227c95b3bf328358b01ba54183881af474a7bd] source acbe57481e0a10be287aad59201873a0799a94f0
# good: [5dda870d87685eced00ca4ba6d5ceb48aff3c19e] source 574c57090642347980d2395e1e183cc7b5c171ad
git bisect start 'latest' 'oldest'
# bad: [04204113dcef4013b1adadb4055c5bb91fa514c1] source c43e62f26f8d51c2ad97f6c93877ce9d3ae9639e
git bisect bad 04204113dcef4013b1adadb4055c5bb91fa514c1
# bad: [bd688acc0b74c295954ec3fb450194ca706d8755] source cc4b5091e739116a7ec83513fa1cd856f0130330
git bisect bad bd688acc0b74c295954ec3fb450194ca706d8755
# good: [2fef8640c3af2b5e68e2d7a56bf9f0d404fe9186] source 316d68416dfee64d54ecaa4839a4045a4f205c4d
git bisect good 2fef8640c3af2b5e68e2d7a56bf9f0d404fe9186
# good: [42e97a5324bfd7c20f782fde95ea6e526fa0b036] source d6c32cffb5cc81989b4bb4a221a152bbe607bd98
git bisect good 42e97a5324bfd7c20f782fde95ea6e526fa0b036
# good: [65f58625efe7e77de6204c364105ddf187ad3f32] source 6bde509fa08fede40ac8ca0094b9441fe34a28e6
git bisect good 65f58625efe7e77de6204c364105ddf187ad3f32
# bad: [e7f029b7ca96f76183c6cf05a09ecca046d996f9] source b5cb211f80fd87c109633232cf340ac7969c8648
git bisect bad e7f029b7ca96f76183c6cf05a09ecca046d996f9
# good: [74bb1b56d378c7f9618549d479b5160f3228ef19] source ff14068ab4b281ab5114a44a05ff405d7dc93e36
git bisect good 74bb1b56d378c7f9618549d479b5160f3228ef19
# good: [31e313f0c3a6596f3773ca9f19ddd0e29935999f] source 4dcd4cbc2140284d0de5490c845380a38d9bc40d
git bisect good 31e313f0c3a6596f3773ca9f19ddd0e29935999f
# good: [e1f4369069c9db5eed513f51c810258df0a36523] source c6a4407897b62e3262c4864d3a7d0e6dc0d00f1a
git bisect good e1f4369069c9db5eed513f51c810258df0a36523
# first bad commit: [e7f029b7ca96f76183c6cf05a09ecca046d996f9] source b5cb211f80fd87c109633232cf340ac7969c8648
Comment 1 baffclan 2020-07-11 08:26:59 UTC
Reproduce with Win-x86@39/2020-07-06_00.14.21/

Version: 7.1.0.0.alpha0+ (x86)
Build ID: 9af38b4504ccda57a0c32eb8bdd03e5a8ca29ddc
CPU threads: 4; OS: Windows 10.0 Build 18363; UI render: Skia/Raster; VCL: win
Locale: ja-JP (ja_JP); UI: en-US
Calc: threaded

OS: WIndows10Pro(x86)/JA
Comment 2 Xisco Faulí 2020-08-11 10:14:11 UTC
Reproduced in

Version: 7.1.0.0.alpha0+
Build ID: 0de191e1d201d691c2196cf1aef412a98affb66f
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 3 Xisco Faulí 2020-08-11 10:31:23 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=68db2d42c1518fdb777faeff891155f350da538c

author	Caolán McNamara <caolanm@redhat.com>	2020-06-05 10:57:25 +0100
committer	Caolán McNamara <caolanm@redhat.com>	2020-06-05 20:33:28 +0200
commit 68db2d42c1518fdb777faeff891155f350da538c (patch)
tree 5a07696b7e09451541ae1215a96863ac14aadfc9
parent 638f2642769cc73ad6dfa75d33145f03fa408d7f (diff)
have just one way to set expander image

Bisected with: bibisect-linux64-7.1

Adding Cc: to Caolán McNamara
Comment 4 Commit Notification 2020-08-11 14:38:15 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/ba6ab05a2a1ecd557302e238e1890b5e631c28b7

tdf#134604 library created in the wrong tree

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 baffclan 2020-08-12 07:11:44 UTC
Cannot reproduce with Win-x86_64@tb77-TDF/2020-08-12_04.49.44/

Version: 7.1.0.0.alpha0+ (x64)
Build ID: <buildversion>
CPU threads: 12; OS: Windows 10.0 Build 19041; UI render: Skia/Vulkan; VCL: win
Locale: ja-JP (ja_JP); UI: en-US
Calc: CL

-> v.