Bug 135012 - Installer "reboot required" popup nitpicking
Summary: Installer "reboot required" popup nitpicking
Status: RESOLVED NOTABUG
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.4.5.2 release
Hardware: All Windows (All)
: medium trivial
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2020-07-21 11:32 UTC by whogoesmoo
Modified: 2020-07-21 13:18 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
This shouldn't appear. (34.35 KB, image/png)
2020-07-21 11:38 UTC, whogoesmoo
Details
This is good - appears after the installer finishes. (14.48 KB, image/png)
2020-07-21 11:39 UTC, whogoesmoo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description whogoesmoo 2020-07-21 11:32:42 UTC
Description:
See attachment. This report relates to the smaller popup shown, about requiring a reboot.


1. A different message to this effect (reboot required) appears after the installer finishes, so the message dealt with here should probably not appear at all.

If the above is accepted, the below can be ignored.

2. Some seconds after okaying one such window, another one popped up.
Regardless of how many reasons for rebooting are encountered, the user only cares to see one such message.

3. The Cancel button - would pressing it cancel the installation process?
Not clear (nothing in the text refers to it).

4. The OK button - would pressing it cause an immediate reboot?
Not clear (the text is confusing in this regard).

5. The Cancel button should probably not be there, unless it serves a purpose other than aborting the installation process.
There is already such funcationality available in the installer window itself (see the larger windows in the attachment).

Actual Results:
See Description.

Expected Results:
See Description.


Reproducible: Didn't try


User Profile Reset: No



Additional Info:
Installing v6.4.5.2 with 6.3.2.2 already installed.
Comment 1 whogoesmoo 2020-07-21 11:38:26 UTC
Created attachment 163358 [details]
This shouldn't appear.
Comment 2 whogoesmoo 2020-07-21 11:39:16 UTC
Created attachment 163359 [details]
This is good - appears after the installer finishes.
Comment 3 V Stuart Foote 2020-07-21 13:13:11 UTC
No, IIUC they are correct as implemented, and both needed with MS Installer (MSI) packaging tasks. 

The first occurs before any changes have been made--allowing you to abort either the blocking processes or end the installation. The second after the installation/update has occurred and is needed to complete the MSI installer actions.
Comment 4 Mike Kaganski 2020-07-21 13:18:38 UTC
(In reply to V Stuart Foote from comment #3)

Absolutely correct. The first allows user to choose not to perform an installation in case when it will ultimately result in reboot requirement. Like "I want to install, but I can't afford a reboot, and I need to be able to run the software normally". The need for reboot indicates that there's no guarantee that you would be able to use LO normally before the reboot (although *usually* you can); so this is an important decisions to take in some cases, *before* the actual action is performed.