Bug 135044 - EDITING Shape with textbox copied with Ctrl+dragging creates incorrectly placed textbox
Summary: EDITING Shape with textbox copied with Ctrl+dragging creates incorrectly plac...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
4.4.0.3 release
Hardware: All All
: medium normal
Assignee: Attila Bakos (NISZ)
URL:
Whiteboard: target:7.2.0 target:7.1.0.0.beta2
Keywords: implementationError
Depends on:
Blocks: Shape-Textbox
  Show dependency treegraph
 
Reported: 2020-07-22 12:45 UTC by NISZ LibreOffice Team
Modified: 2021-01-11 10:39 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file from Writer with shape+textbox (9.54 KB, application/vnd.oasis.opendocument.text)
2020-07-22 12:45 UTC, NISZ LibreOffice Team
Details
Screenshot of the problem in Writer after creating a new shape with Ctrl+dragging (31.32 KB, image/png)
2020-07-22 12:46 UTC, NISZ LibreOffice Team
Details
How it looks in 7.2 (181.02 KB, image/jpeg)
2020-11-25 12:32 UTC, Attila Bakos (NISZ)
Details
How it looks in 7.2 after fix (160.53 KB, image/jpeg)
2020-12-03 13:24 UTC, Attila Bakos (NISZ)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description NISZ LibreOffice Team 2020-07-22 12:45:14 UTC
Created attachment 163404 [details]
Example file from Writer with shape+textbox

Attached document contains a simple shape with textbox.
When the shape is copied with Ctrl+dragging the textbox of the new shape has an incorrectly placed textbox: it has the horizontal position of the original shape, and the vertical position of the new.

Steps to reproduce:
    1. Open attached file
    2. Select the shape by clicking 
    3. Press Ctrl and drag the shape to make a new copy of it

Actual results:
The new shape has its textbox positioned below the original shape, and not inside. Moving the new shape a bit however corrects the textbox position.

Expected results:
New shape has its textbox inside after Ctrl+dragging.

LibreOffice details:
Version: 7.1.0.0.alpha0+ (x64)
Build ID: b1c83b68bfbf3477fa6a8f4c79c53f6f9ab31f8e
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: CL

Also happens in:
Verzió: 6.0.0.3
Build az.: 64a0f66915f38c6217de274f0aa8e15618924765
CPU szálak: 4; OS: Windows 6.3; Felületmegjelenítés: alapértelmezett; 
Területi beállítások: hu-HU (hu_HU); Calc: CL

Version: 5.0.0.5
Build ID: 1b1a90865e348b492231e1c451437d7a15bb262b
Locale: hu-HU (hu_HU)

Version: 4.4.0.3
Build ID: de093506bcdc5fafd9023ee680b8c60e3e0645d7
Locale: hu_HU

Before that there was no textbox support for shapes.
Comment 1 NISZ LibreOffice Team 2020-07-22 12:46:15 UTC
Created attachment 163405 [details]
Screenshot of the problem in Writer after creating a new shape with Ctrl+dragging
Comment 2 Attila Bakos (NISZ) 2020-11-25 12:32:12 UTC
Created attachment 167561 [details]
How it looks in 7.2

Version: 7.2.0.0.alpha0+ (x64)
Build ID: 7ac81c6a1dc0ccd6ab62793f4787002da73b4d5b
CPU threads: 8; OS: Windows 10.0 Build 19042; UI render: default; VCL: win
Locale: hu-HU (hu_HU); UI: en-US
Calc: CL
Comment 3 Commit Notification 2020-12-03 10:25:43 UTC
Attila Bakos (NISZ) committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/64819ab91555b5afe360cf25aba6431546c4d905

tdf#135044 sw: fix Ctrl + drag textbox copy

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Attila Bakos (NISZ) 2020-12-03 13:24:53 UTC
Created attachment 167792 [details]
How it looks in 7.2 after fix
Comment 5 Commit Notification 2020-12-03 22:33:23 UTC
Attila Bakos (NISZ) committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/dc8b0ef9ddf52aac2e2188925d9273c202086834

tdf#135044 sw: fix Ctrl + drag textbox copy

It will be available in 7.1.0.0.beta2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 NISZ LibreOffice Team 2021-01-11 10:39:16 UTC
Verified in:

Version: 7.2.0.0.alpha0+ (x64)
Build ID: 96bafa464ebdbce3ef04bec9beae5e745bb37794
CPU threads: 4; OS: Windows 10.0 Build 17134; UI render: Skia/Raster; VCL: win
Locale: hu-HU (hu_HU); UI: hu-HU
Calc: threaded

Thanks for fixing!