Download it now!
Bug 135164 - FILESAVE DOCX: Heading get bullets
Summary: FILESAVE DOCX: Heading get bullets
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.0.0.1 rc
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: bibisected, bisected, regression
Depends on:
Blocks: DOCX-Bullet-Number-Outline-Lists
  Show dependency treegraph
 
Reported: 2020-07-26 17:32 UTC by Telesto
Modified: 2020-12-03 18:16 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file (255.99 KB, application/vnd.oasis.opendocument.text)
2020-07-26 17:33 UTC, Telesto
Details
Example file Proper (11.52 MB, application/vnd.oasis.opendocument.text)
2020-07-27 11:24 UTC, Telesto
Details
EXPORTED DOCX (11.51 MB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2020-07-27 11:40 UTC, Telesto
Details
PDF (391.16 KB, application/pdf)
2020-07-27 11:41 UTC, Telesto
Details
Minimized source file (13.94 KB, application/vnd.oasis.opendocument.text)
2020-12-02 15:33 UTC, NISZ LibreOffice Team
Details
The minimized source file saved as docx (6.73 KB, application/vnd.openxmlformats-officedocument.wordprocessingml.document)
2020-12-02 15:35 UTC, NISZ LibreOffice Team
Details
The minimized and the docx verson in Writer master (79.47 KB, image/png)
2020-12-02 15:36 UTC, NISZ LibreOffice Team
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-07-26 17:32:56 UTC
Description:
FILESAVE DOCX: Heading get bullets

Steps to Reproduce:
1. Open the attached file
2. Save as DOCX
3. File reload -> Look at heading

Actual Results:
Numbering changes into bullets 

Expected Results:
Shouldn't happen


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.1.0.0.alpha0+ (x64)
Build ID: <buildversion>
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2020-07-26 17:33:10 UTC
Created attachment 163576 [details]
Example file
Comment 2 Xisco Faulí 2020-07-27 09:54:44 UTC
I can't reproduce it in

Version: 7.1.0.0.alpha0+
Build ID: b68c10a0d0e6f83b6b037da72210033cacb1677b
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 3 Telesto 2020-07-27 11:24:05 UTC
Created attachment 163613 [details]
Example file Proper
Comment 4 Xisco Faulí 2020-07-27 11:29:30 UTC
(In reply to Telesto from comment #3)
> Created attachment 163613 [details]
> Example file Proper

Again, not reproducible in

Version: 7.1.0.0.alpha0+
Build ID: b68c10a0d0e6f83b6b037da72210033cacb1677b
CPU threads: 4; OS: Linux 4.19; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 5 Xisco Faulí 2020-07-27 11:30:09 UTC
> Additional Info:
> Version: 7.1.0.0.alpha0+ (x64)
> Build ID: <buildversion>
> CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
> Locale: nl-NL (nl_NL); UI: en-US
> Calc: CL

Please, add the buildversion
Comment 6 Telesto 2020-07-27 11:33:11 UTC
It's the build from 7/24/2020 -> I'm updating now.. they see if the build id is back..
Comment 7 Telesto 2020-07-27 11:40:58 UTC
Created attachment 163616 [details]
EXPORTED DOCX
Comment 8 Telesto 2020-07-27 11:41:26 UTC
Created attachment 163617 [details]
PDF
Comment 9 Telesto 2020-07-27 11:42:04 UTC
Version: 7.1.0.0.alpha0+ (x64)
Build ID: <buildversion>
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL

Build of today -> someone meddled with Build ID
Comment 10 Abhi 2020-08-24 23:08:04 UTC
Thanks you for reporting this bug. I can not reproduce this bug in:

Version: 7.1.0.0.alpha0+ (x64)
Build ID: 5f665a855ef26fae4dfa2ac427685b60545e8b8
CPU threads: 16; OS: Windows 10.0 Build 18363; UI render: Skia/Vulkan; VCL: win
Locale: en-US (en_US); UI: en-US
Calc: CL
Comment 11 Telesto 2020-08-25 07:06:15 UTC
Not seen in 
Version: 7.0.0.2
Build ID: c01aa64b6c3d89ebe5fe69c28c7adb24eb85249c
CPU threads: 4; OS: Mac OS X 10.12.6; UI render: default; VCL: osx
Locale: nl-NL (nl_NL.UTF-8); UI: en-US
Calc: threaded

Looks like a kind of font issue
Comment 12 NISZ LibreOffice Team 2020-12-02 15:33:41 UTC
Created attachment 167763 [details]
Minimized source file
Comment 13 NISZ LibreOffice Team 2020-12-02 15:35:31 UTC
Created attachment 167764 [details]
The minimized source file saved as docx

Looks like the frame at the bottom of the original document - anchored to a bulleted paragraph - has something to do with this.
Removing the frame before save does not trigger this problem.
Comment 14 NISZ LibreOffice Team 2020-12-02 15:36:18 UTC
Created attachment 167765 [details]
The minimized and the docx verson in Writer master

Version: 7.2.0.0.alpha0+ (x64)
Build ID: 4e63ec27b69fa01ff610c894c9fbf05c377a6179
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: default; VCL: win
Locale: en-US (hu_HU); UI: en-US
Calc: CL
Comment 15 Gabor Kelemen 2020-12-03 06:36:20 UTC
Bibisected with minimized example file on bibisect-linux-64-7.1 to:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=04ca5efc800c6b7a6e98e4278eb8be6ac6737fe9

author	Julien Nabet <serval2412@yahoo.fr>	2020-06-27 09:27:50 +0200
committer	Caolán McNamara <caolanm@redhat.com>	2020-06-27 16:27:13 +0200

cid#1464974: Null pointer dereferences (sw/unosett)

Adding CC to: Julien Nabet

Side note: the original file does not seem to save badly on Linux, only on Windows. But saving the minimized one to docx indeed adds numbering to Heading paragraphs.
Comment 16 Xisco Faulí 2020-12-03 09:11:01 UTC
(In reply to NISZ LibreOffice Team from comment #13)
> Created attachment 167764 [details]
> The minimized source file saved as docx
> 
> Looks like the frame at the bottom of the original document - anchored to a
> bulleted paragraph - has something to do with this.
> Removing the frame before save does not trigger this problem.

Win only?
I can't reproduce it in

Version: 7.2.0.0.alpha0+
Build ID: 480d00625534c356dabd96c503d992f07c99d152
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded
Comment 17 Julien Nabet 2020-12-03 18:16:13 UTC
On pc Debian x86-64 with master sources updated today with gtk3 or gen rendering, I don't reproduce the pb with minimized source file.

I also put a trace at the location indicated by:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=04ca5efc800c6b7a6e98e4278eb8be6ac6737fe9

author	Julien Nabet <serval2412@yahoo.fr>	2020-06-27 09:27:50 +0200
committer	Caolán McNamara <caolanm@redhat.com>	2020-06-27 16:27:13 +0200

cid#1464974: Null pointer dereferences (sw/unosett)

It seems LO doesn't go there.
Also the patch doesn't change functionality, just avoids some null pointer.
diff --git a/sw/source/core/unocore/unosett.cxx b/sw/source/core/unocore/unosett.cxx
index 817938749bf7..81f1a6a2e33a 100644
--- a/sw/source/core/unocore/unosett.cxx
+++ b/sw/source/core/unocore/unosett.cxx
@@ -1771,8 +1771,8 @@ void SwXNumberingRules::SetPropertiesToNumFormat(
         {
             OUString sBulletFontName;
             rProp.Value >>= sBulletFontName;
-            SwDocShell* pLclDocShell = pDoc->GetDocShell();
-            if( !sBulletFontName.isEmpty() && pLclDocShell )
+            SwDocShell* pLclDocShell = nullptr;
+            if( !sBulletFontName.isEmpty() && pDoc && (pLclDocShell = pDoc->GetDocShell()) )


Did I miss something?