Bug 135346 - Print preview: "no data" on big print range for one page
Summary: Print preview: "no data" on big print range for one page
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Printing and PDF export (show other bugs)
Version:
(earliest affected)
6.1 all versions
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.4.0 target:7.3.5
Keywords: bibisected, bisected, regression
Depends on:
Blocks:
 
Reported: 2020-07-31 14:53 UTC by Maxim Britov
Modified: 2022-06-15 17:55 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Sample file (10.18 KB, application/vnd.oasis.opendocument.spreadsheet)
2020-07-31 14:53 UTC, Maxim Britov
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Maxim Britov 2020-07-31 14:53:20 UTC
Created attachment 163815 [details]
Sample file

There is strange document with very big table. We need print it on one page.
But we can't.

1. Print preview show "No data".
2. PDF export alo broken.
   When I export to PDF we have one empty page.
   With "Whole sheet export" we have three page pdf with 1 small page and 2 empty pages.

Tested on LO 6.0 .. 7.0.0.3
LO 6.0.72 works fine, but LO 6.1.0.0alpha - not, with @no data"

Please look
Comment 1 BogdanB 2020-07-31 15:31:44 UTC
I notice the same thing.

I succeded to show the page like this:
Select all, change the font and change the size of the text as you want.

Maybe is something with the font you have in this document
Comment 2 Maxim Britov 2020-07-31 16:23:19 UTC
For workaround for *this* file I decreasing bottom margin.
Comment 3 Xisco Faulí 2020-08-04 12:36:40 UTC
Regression introduced by:

https://cgit.freedesktop.org/libreoffice/core/commit/?id=5217a2a0bf27e496cc429ee45dff7c239b466ae6

author	Tomaž Vajngerl <tomaz.vajngerl@collabora.co.uk>	2017-12-12 22:22:32 +0900
committer	Tomaž Vajngerl <quikee@gmail.com>	2017-12-13 00:54:48 +0100
commit 5217a2a0bf27e496cc429ee45dff7c239b466ae6 (patch)
tree b103a823e8c4bb144ea28c9d15286721088f16b9
parent eb002da913cd1745b039bbc7e519542d7990fb49 (diff)
tdf#114256 add cache criterium when to recalculate page range size

Bisected with: bibisect-linux64-6.1

Adding Cc: to Tomaž Vajngerl
Comment 4 Xisco Faulí 2020-08-04 12:37:30 UTC
@Luboš Luňák, since you fixed bug 121439, I thought you might be interested in this issue
Comment 5 Justin L 2021-11-18 13:30:54 UTC
While it is true that the "no data" shows up with comment 3's patch, the prior commit shows the sheet broken up into 8 pages - and page 1 in that case is empty. So likely the answer to this bug is to be found earlier in 6.1 with
author	Tomaž Vajngerl on 2017-12-04 08:07:24 +0100
commit 5684e53b931eaaac658bc3246ae1c3249e252fdb 
    Calculate print page ranges only when needed, cache in print state

https://gerrit.libreoffice.org/c/core/+/45689

Indeed comment 3's patch was a "fix" for this earlier commit. Also - you can see on the print preview that the content is much smaller than before - it wasn't fitting the page like the data does.
Comment 6 Justin L 2021-11-19 06:22:11 UTC
I got nowhere trying to debug in master which was discouraging, and attempting to revert 5217a2a0bf27e496cc429ee45dff7c239b466ae6 wasn't successful in one hour, so I am giving up.
Comment 7 Commit Notification 2022-06-10 06:12:39 UTC
Tomaž Vajngerl committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/317dc8569723d434fe4175a2b665b84fd15f6f99

tdf#135346 clear page row map to avoid invalid "hidden" flags

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2022-06-10 08:40:22 UTC
Tomaž Vajngerl committed a patch related to this issue.
It has been pushed to "libreoffice-7-3":

https://git.libreoffice.org/core/commit/03e18e8035092d0d95504131e2722722f1edfe0f

tdf#135346 clear page row map to avoid invalid "hidden" flags

It will be available in 7.3.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2022-06-10 10:28:16 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b28de9d32016a904e4ba457a9a6c62098416c729

tdf#135346: vcl_pdfexport: Add unittest

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Justin L 2022-06-15 17:55:01 UTC
confirmed that this has been fixed. Thanks Tomaž.