Bug 135377 - No format pre-selected by default in the format column for fields, variables, user fields
Summary: No format pre-selected by default in the format column for fields, variables,...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: UI (show other bugs)
Version:
(earliest affected)
6.4.0.0.alpha0+
Hardware: All All
: medium minor
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.2.0 target:7.1.1 target:7.0....
Keywords: bibisected, bisected, regression
Depends on:
Blocks: Fields-Dialog
  Show dependency treegraph
 
Reported: 2020-08-02 08:59 UTC by Telesto
Modified: 2022-04-15 20:36 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Screencast (1.24 MB, video/mp4)
2020-08-03 17:55 UTC, Telesto
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-08-02 08:59:52 UTC
Description:
Inserting a new field doesn't seem to work as expected

Steps to Reproduce:
1. Open Writer
2. CTRL+F2 or insert - field -> More field details
3. Variables tab
4. User field Type
5. Type AA and BB for name and value and press green v 

Nothing happens because Format isn't pre-selected (it was in 4.4.7.2)

Actual Results:
Format isn't preselect

Expected Results:
Probably


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.1.0.0.alpha0+ (x64)
Build ID: <buildversion>
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: ru-RU (nl_NL); UI: en-US
Calc: CL

Still ok in
Version: 6.2.0.0.alpha0+
Build ID: 401cba4c20fbc930f034168872642428d7459218
CPU threads: 4; OS: Windows 6.3; UI render: default; 
Locale: nl-NL (nl_NL); Calc: CL
Comment 1 Xisco Faulí 2020-08-03 16:07:17 UTC
You have to click 'Insert' after step 5. And no, it didn't work in the past as you say it was.

Tested with

Version: 4.3.0.0.alpha1+
Build ID: c15927f20d4727c3b8de68497b6949e72f9e6e9e

and

Version 4.1.0.0.alpha0+ (Build ID: efca6f15609322f62a35619619a6d5fe5c9bd5a)
Comment 2 Telesto 2020-08-03 17:55:50 UTC
Created attachment 163908 [details]
Screencast
Comment 3 Telesto 2020-08-03 17:58:51 UTC
See screencast
It did work this way between 4.4.7.2-6.0

Looks a lot like weld change IMHO
Comment 4 Xisco Faulí 2020-08-04 07:33:24 UTC
(In reply to Telesto from comment #3)
> See screencast
> It did work this way between 4.4.7.2-6.0
> 
> Looks a lot like weld change IMHO

Is 4.4 the first or the second? I don't see it working in either version...
Comment 5 Telesto 2020-08-04 08:28:46 UTC
(In reply to Xisco Faulí from comment #4)
> (In reply to Telesto from comment #3)
> > See screencast
> > It did work this way between 4.4.7.2-6.0
> > 
> > Looks a lot like weld change IMHO
> 
> Is 4.4 the first or the second? I don't see it working in either version...

Yes, 4.4.7.2. You can see I added an item  to the Select list in LibO 4.4.7.2 (works also in 6.2) to the list by pressing V, which isn't working in 7.1

This because there is no format pre-selected by default in they format column
Comment 6 Buovjaga 2021-01-18 18:02:32 UTC
Bibisected with linux-64-6.4 to https://git.libreoffice.org/core/commit/0fbcac4caa971bd8824c96fe9ef7d9338cd37cbc
tdf#55436 - Add SYMBOL_CHICAGO numbering scheme (for footnotes)

It seems like an incorrect result, but I did check it twice.
Comment 7 Mike Kaganski 2021-01-18 18:47:40 UTC
(In reply to Buovjaga from comment #6)

bibisect-win64-6.4 gives
https://git.libreoffice.org/core/+/0576911eec4f5fab4d4dd4f0cd46744b9a567899
Comment 8 Buovjaga 2021-01-18 19:11:56 UTC
(In reply to Mike Kaganski from comment #7)
> (In reply to Buovjaga from comment #6)
> 
> bibisect-win64-6.4 gives
> https://git.libreoffice.org/core/+/0576911eec4f5fab4d4dd4f0cd46744b9a567899

Thanks.

Adding Cc: to Caolán McNamara
Comment 9 Commit Notification 2021-01-19 19:53:01 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/f994017159d27faaa6678db9a2a658ace1f871d3

tdf#135377 keep the correct index selected

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Caolán McNamara 2021-01-19 20:16:24 UTC
ok in master, backport to 7-1 and 7-0 in gerrit
Comment 11 Buovjaga 2021-01-20 12:07:34 UTC
Verified with all Linux VCL backends.

Arch Linux 64-bit
Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: 3ff95c8df6be9aa01aef5c663ee2ffa9881193d4
CPU threads: 8; OS: Linux 5.10; UI render: default; VCL: kf5
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Built on 20 January 2021

(In reply to Buovjaga from comment #6)
> Bibisected with linux-64-6.4 to
> https://git.libreoffice.org/core/commit/
> 0fbcac4caa971bd8824c96fe9ef7d9338cd37cbc
> tdf#55436 - Add SYMBOL_CHICAGO numbering scheme (for footnotes)
> 
> It seems like an incorrect result, but I did check it twice.

This confusing result was because I used the kde backend. I should have used the gen backend.
Comment 12 Commit Notification 2021-01-20 18:02:55 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/291d337093dc04916b35052dbad9f13253387a2a

tdf#135377 keep the correct index selected

It will be available in 7.1.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 13 Commit Notification 2021-01-20 18:04:10 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/b99a8a17f91033c9955be8c874012a6762138af4

tdf#135377 keep the correct index selected

It will be available in 7.0.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 14 Commit Notification 2022-04-15 20:36:43 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/b4b3398736d42bf1e3de4b397510576fdc5c3338

tdf#135377: sw: Add UItest

It will be available in 7.4.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.