Description: Although we have already got this support (bug 84002), it's still necessary to add some improves to give better support for this format. FreieFarbe e.V. published the CIELAB HLC Colour Atlas (XL), a free standard for color communication. On the website they provided some ASE palettes, however both of them failed on LibreOffice. https://www.freiefarbe.de/en/thema-farbe/software/ Steps to Reproduce: 1. Download ZIP package from freiefarbe 2. Extract ASE palettes 3. Move to LibreOffice user configuration folder Actual Results: While the ASE palettes installed, all of them failed to produce colors, but show rather blocks in black. Expected Results: - Reproducible: Always User Profile Reset: No Additional Info: -
ASE is not documented officially but it seems it supports several types of colour spaces: - RGB - LAB - CMYK - Grayscale See https://www.cyotek.com/blog/reading-adobe-swatch-exchange-ase-files-using-csharp I gave a try with HLC-Colour-Atlas_EPV_Swatches_v2-3.ase and could reproduce this on pc Debian x86-64 with master sources updated today. But this palette contains "LAB" colour space and this one isn't supported. See https://opengrok.libreoffice.org/xref/core/svx/source/tbxctrls /Palette.cxx?r=33966ab2#161 Chris/Tomaz: any thoughts here?
Yes, we need to add the code to convert from other colorspaces to RGB as we only handle RGB (and grayscale).
(In reply to Tomaz Vajngerl from comment #2) > Yes, we need to add the code to convert from other colorspaces to RGB as we > only handle RGB (and grayscale). yes but I read several links and the only thing that's sure is it needs a 2-steps conversion: - convert LAB to XYZ - convert XYZ to RGB See http://www.brucelindbloom.com/index.html?Equations.html For the rest, formula, coefficients may differ. It also depends on parameters like "white point" and other elements that I don't know. See: - https://en.wikipedia.org/wiki/CIELAB_color_space#RGB_and_CMYK_conversions - http://www.brucelindbloom.com/index.html?Equations.html ... Not easy... Another thing I noticed too, according to https://www.cyotek.com/blog/reading-adobe-swatch-exchange-ase-files-using-csharp, nChunkType should be 2 bytes and nChunkSize 4 bytes. In LO codes, it's the contrary.
Dear Volga, To make sure we're focusing on the bugs that affect our users today, LibreOffice QA is asking bug reporters and confirmers to retest open, confirmed bugs which have not been touched for over a year. There have been thousands of bug fixes and commits since anyone checked on this bug report. During that time, it's possible that the bug has been fixed, or the details of the problem have changed. We'd really appreciate your help in getting confirmation that the bug is still present. If you have time, please do the following: Test to see if the bug is still present with the latest version of LibreOffice from https://www.libreoffice.org/download/ If the bug is present, please leave a comment that includes the information from Help - About LibreOffice. If the bug is NOT present, please set the bug's Status field to RESOLVED-WORKSFORME and leave a comment that includes the information from Help - About LibreOffice. Please DO NOT Update the version field Reply via email (please reply directly on the bug tracker) Set the bug's Status field to RESOLVED - FIXED (this status has a particular meaning that is not appropriate in this case) If you want to do more to help you can test to see if your issue is a REGRESSION. To do so: 1. Download and install oldest version of LibreOffice (usually 3.3 unless your bug pertains to a feature added after 3.3) from https://downloadarchive.documentfoundation.org/libreoffice/old/ 2. Test your bug 3. Leave a comment with your results. 4a. If the bug was present with 3.3 - set version to 'inherited from OOo'; 4b. If the bug was not present in 3.3 - add 'regression' to keyword Feel free to come ask questions or to say hello in our QA chat: https://web.libera.chat/?settings=#libreoffice-qa Thank you for helping us make LibreOffice even better for everyone! Warm Regards, QA Team MassPing-UntouchedBug
(In reply to Tomaz Vajngerl from comment #2) > Yes, we need to add the code to convert from other colorspaces to RGB as we > only handle RGB (and grayscale). I think one solution is implementing color management to make use of ICC color profile to build a bridge between RGB and other color models.
Julien Nabet committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/53730cc3b0a6b0228f680962f79ae6bec9e7fe02 Related tdf#135561: read ase palette with Lab colormodel It will be available in 25.2.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Before cherry-picking the patch on 24.8 branch, it would be great someone confirms that the converted Lab colors to RGB are ok.
Sorry, it doesn't work at all.
Sorry, it doesn't work at all. Maybe I have to waiting for a so long time until I'm able to confirm.
(In reply to Volga from comment #10) > Sorry, it doesn't work at all. Maybe I have to waiting for a so long time > until I'm able to confirm. You mean it's still black for you or do you some colors and you consider them as wrong?
(In reply to Julien Nabet from comment #11) > (In reply to Volga from comment #10) > > Sorry, it doesn't work at all. Maybe I have to waiting for a so long time > > until I'm able to confirm. > > You mean it's still black for you or do you some colors and you consider > them as wrong? Yes
(In reply to Julien Nabet from comment #11) > You mean it's still black for you or do you some colors and you consider > them as wrong? They still looks black. Version: 24.2.6.0.0+ (X86_64) / LibreOffice Community Build ID: 525fe1a2e58a4d6164aa104e893d4f07a5709b27 CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: win Locale: zh-CN (zh_CN); UI: zh-CN Calc: CL threaded https://freiefarbe.de/wp-content/uploads/2022/12/HLC-Colour-Atlas_EPV_A10_v2.03.zip
(In reply to Volga from comment #13) > (In reply to Julien Nabet from comment #11) > > You mean it's still black for you or do you some colors and you consider > > them as wrong? > They still looks black. > > Version: 24.2.6.0.0+ (X86_64) / LibreOffice Community > Build ID: 525fe1a2e58a4d6164aa104e893d4f07a5709b27 > CPU threads: 4; OS: Windows 10.0 Build 19045; UI render: Skia/Raster; VCL: > win > Locale: zh-CN (zh_CN); UI: zh-CN > Calc: CL threaded > > https://freiefarbe.de/wp-content/uploads/2022/12/HLC-Colour-Atlas_EPV_A10_v2. > 03.zip The patch concerns only master branch for the moment, so the future 25.2. So indeed, it won’t work on 24.2.6
It still doesn't work with me. Version: 25.2.0.0.alpha0+ (X86_64) / LibreOffice Community Build ID: 612e4d7731cc2890d6e58e8b712757fccd06ae2d CPU threads: 4; OS: Windows 10 X86_64 (10.0 build 19045); UI render: Skia/Raster; VCL: win Locale: zh-CN (zh_CN); UI: en-US Calc: CL threaded
I won't have access to my Windows laptop so can't help here. Let's remove target, unassign + uncc myself
I believe integrating LittleCMS would help
I retrieved my Windows laptop and could give a try today, I confirm there's only black for each entry of the ASE palette. I retried the ase file on Linux and I don't reproduce this. I tested on Windows if LO entered in the code modified by the patch, it was the case. So no idea, why it fails on Windows. About LittleCMS, I got no idea. I know that license of the lib must be checked before integrating it but don't know how to integrate in LO code. Certainly someone may have some idea here.
(In reply to Julien Nabet from comment #18) > About LittleCMS, I got no idea. > I know that license of the lib must be checked before integrating it but > don't know how to integrate in LO code. > Certainly someone may have some idea here. Here is some information about LittleCMS: https://www.littlecms.com/ Yeah this is the solution I have claimed in comment 6 and 17. Using this library to replace comment 53730cc3b0a6b0228f680962f79ae6bec9e7fe02 would pave the way to support ASE palettes in various color models, and LO could be able to reproduce even more desirable output.