Bug 135590 - Create Envelope: differ some page format properties between sidebar and page style dialog
Summary: Create Envelope: differ some page format properties between sidebar and page ...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
7.0.0.3 release
Hardware: All All
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.2.0 target:7.1.1
Keywords:
Depends on:
Blocks: Page-Style-Dialog
  Show dependency treegraph
 
Reported: 2020-08-10 01:15 UTC by sawakaze
Modified: 2021-01-25 09:18 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
ScreenCast (1.16 MB, video/x-matroska)
2020-08-10 01:16 UTC, sawakaze
Details

Note You need to log in before you can comment on or make changes to this bug.
Description sawakaze 2020-08-10 01:15:50 UTC
Description:
after following step, create blank envelope.
but i notice some page properties between sidebar and page style dialog 
detail is screen cast

Steps to Reproduce:
1. open writer
2. Insert > Envelope...
-> launch Envelope window
3. press Format tab
4. select Format to "C6 Envelope"
5. press New Document
-> create new Envelope document
6. confirm page format on sidebar
7. open page style dialog by toggle button
8. confirm Page Format on Page tab
 

Actual Results:
differ between sidebar and Page style dialog

[sidebar]
Size  : User
width : 16.20cm
height: 11.40cm
orientation : Portrait

[Page Style]
Size  : C6 Envelope
width : 11.40cm
height: 16.20cm
orientation : Portrait


Expected Results:
As actual view.

perhaps, I seem

Size  : C6 Envelope
width : 16.20cm
height: 11.40cm
orientation : Landscape
 


Reproducible: Always


User Profile Reset: Yes



Additional Info:
I confirm 

Version: 7.1.0.0.alpha0+
Build ID: <buildversion>
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3
Locale: ja-JP (ja_JP.UTF-8); UI: en-US
TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2020-08-06_17:35:14
Calc: threaded

I don't confirm other size.
Comment 1 sawakaze 2020-08-10 01:16:44 UTC
Created attachment 164081 [details]
ScreenCast
Comment 2 Dieter 2020-11-09 07:14:15 UTC
I confirm it with

Version: 7.0.3.1 (x64)
Build ID: d7547858d014d4cf69878db179d326fc3483e082
CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: en-GB
Calc: threaded

Additional information:
With the following steps:
1. Open a new document
2. Format => Page Style => Format C6 => O.K.

you recieve the same (wrong?) result in Page Style dialog and page tab of the sidebar.

So for me expected result is
width : 16.20cm
height: 11.40cm
orientation : Portrait
Comment 3 Caolán McNamara 2021-01-22 10:04:55 UTC
I suspect this got broken with

https://cgit.freedesktop.org/libreoffice/core/commit/?id=ff4896a2af1df6138e9246fe1588dfe8c3748f1a

commit ff4896a2af1df6138e9246fe1588dfe8c3748f1a
Date:   Fri Jun 29 11:36:03 2018 -0300

    Sets paper sizes listbox in print dialog
    
    Change-Id: Iaeb50f6e854b90c1062d2ed6e3e053a6c26ea520

where PaperInfo::doSloppyFit was modified to accept rotated dimensions of a paper size as being the paper size, e.g. rotated A4 dimensions reported as an A4 page. There's no explanation given for the change in the commit.
Comment 4 Dieter 2021-01-22 10:08:45 UTC
(In reply to Caolán McNamara from comment #3)
> I suspect this got broken with
> 
> https://cgit.freedesktop.org/libreoffice/core/commit/
> ?id=ff4896a2af1df6138e9246fe1588dfe8c3748f1a
> 
> commit ff4896a2af1df6138e9246fe1588dfe8c3748f1a
> There's no explanation given for the change in the commit.

cc: Daniel Silva
Daniel, can you take a look at this?
Comment 5 Caolán McNamara 2021-01-22 10:46:51 UTC
https://gerrit.libreoffice.org/c/core/+/109751 to make the sidebar agree with format, page after insert, envelope, insert. But I believe its the wrong result. I'll have a follow up to address that.
Comment 6 Caolán McNamara 2021-01-22 11:09:23 UTC
https://gerrit.libreoffice.org/c/core/+/109784 for the rotated page issue. I went for keeping the change of ff4896a2af1df6138e9246fe1588dfe8c3748f1a for the uses of the affected function in that commit, but revert it to its traditional mechanism for the other calls, i.e. including the page dialog and sidebar
Comment 7 Commit Notification 2021-01-22 14:27:40 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/41372210fbbc497eb6353c998fca0b5502b331d9

tdf#135590 MapUnit::Map100thMM fallback is inappropiate for writer

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2021-01-22 17:16:40 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/651e9e7278fffa79248fb173432de0af4a622b5d

tdf#135590 rotated paper sizes reported as portrait size they are not

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Caolán McNamara 2021-01-22 17:17:21 UTC
I think that works well, backports to 7-1 and 7-0 in gerrit
Comment 10 Commit Notification 2021-01-22 19:40:59 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/9355d020e0b6bec6c6e08bd5155ed1428df5f674

tdf#135590 rotated paper sizes reported as portrait size they are not

It will be available in 7.1.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 11 Commit Notification 2021-01-22 20:03:33 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/cf175d313b7cb3084f99f01e6213cdeeee124d92

tdf#135590 MapUnit::Map100thMM fallback is inappropiate for writer

It will be available in 7.1.1.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 12 Commit Notification 2021-01-23 13:55:56 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/656a59e95f82c4206d5889d252f5c48027343b17

tdf#135590: sw: Add UItest

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 13 Xisco Faulí 2021-01-25 09:18:06 UTC
Verified in

Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: 0426748927919dbfd4cf5c0bb904e21a90d6c9d7
CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

@Caolán, thanks for fixing this issue!!