Description: Tables are stacked onto each other after undo of page wrap change Steps to Reproduce: 1. Open attachment 126770 [details] (bug 101464) 2. Scroll to page 3 3. Select the frame "Conformation 4. Right Click -> Change Wrap to page wrap (new name parallel wrap) 5. CTRL+Z Actual Results: Multiple tables stacked onto each other (page 2/3) Expected Results: Not so Reproducible: Always User Profile Reset: No Additional Info: Found in 7.1 and in Version: 6.4.0.0.beta1+ (x64) Build ID: 20be5cd0bdc57d812bf34a2debfe48caa51de881 CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: GL; VCL: win; Locale: nl-NL (nl_NL); UI-Language: en-US Calc: CL not in Version: 6.3.0.0.beta1+ (x86) Build ID: 5cfac16dbd4af456a7fb6d52c8953c69a72ba2ba CPU threads: 4; OS: Windows 6.3; UI render: default; VCL: win; Locale: nl-NL (nl_NL); UI-Language: en-US Calc: CL
Created attachment 164156 [details] Bibisect log Bisected to author Vasily Melenchuk <vasily.melenchuk@cib.de> 2019-08-15 12:08:06 +0300 committer Thorsten Behrens <Thorsten.Behrens@CIB.de> 2019-08-19 11:15:22 +0200 commit 09228fabe88f3457105cf26d83c003719a793114 (patch) tree 7a3c75f27de075dba58932fe328c7bac1961719c parent 92d1b0d10ec04f17d116bc54aada652f1c2cac4a (diff) sw undo/redo: avoid usage of pointers as a style references Style can be created on previous undo steps and so after undo/redo pointer can became invalid. Style name as a reference looks like a good alternative to pointers. https://cgit.freedesktop.org/libreoffice/core/commit/?id=09228fabe88f3457105cf26d83c003719a793114
Closing as a duplicate of bug 133490 *** This bug has been marked as a duplicate of bug 133490 ***
Still present Version: 7.1.0.0.alpha0+ (x64) Build ID: e8b8e7be0b2ad693224cd94062a55610eb69df7e CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win Locale: nl-NL (nl_NL); UI: en-US Calc: CL Adding CC: to Vasily Melenchuk
Vasily Melenchuk committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/07a695ec1988ee8b02256cab2e07a1b429ead24b tdf#135623: modified generation of unique fly name It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Hi Vasily, I do confirm your patch fixes the issue. Tested in a local build. Backporting it to previous branches and creating a unittest for it
Vasily Melenchuk committed a patch related to this issue. It has been pushed to "libreoffice-7-0": https://git.libreoffice.org/core/commit/c514e9cfca2901f325644a65ee1b87455a56e7f0 tdf#135623: modified generation of unique fly name It will be available in 7.0.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Xisco Fauli committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/485a8a8f21f951d19586b694c233eb4a2dd7b57a tdf#135623: sw_uiwriter: Add unittest It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Vasily Melenchuk committed a patch related to this issue. It has been pushed to "libreoffice-6-4": https://git.libreoffice.org/core/commit/e752f7d984a82eb720c2cb63be44ea1935d39502 tdf#135623: modified generation of unique fly name It will be available in 6.4.7. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Resolved from my POV. There are some problems with shape after redo, but this looks like a problem with shape positioning and not a regression.
(In reply to Vasily Melenchuk (CIB) from comment #9) > Resolved from my POV. > There are some problems with shape after redo, but this looks like a problem > with shape positioning and not a regression. Not sure what you mean but at least for me, the original problem is no longer reproducible in Version: 7.1.0.0.alpha0+ Build ID: 6f1e02c96b887750f974c187a82ecd6236e6a435 CPU threads: 4; OS: Linux 5.7; UI render: default; VCL: gtk3 Locale: en-US (en_US.UTF-8); UI: en-US Calc: threaded if another issue is found, please, create a new ticket.
Xisco Fauli committed a patch related to this issue. It has been pushed to "libreoffice-7-0": https://git.libreoffice.org/core/commit/04334ade62d6f8f3001684338d35b93edb5e3588 tdf#135623: sw_uiwriter: Add unittest It will be available in 7.0.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.