Bug 135769 - Accessibility Unnamed Button (for screenreaders)in hyphenation
Summary: Accessibility Unnamed Button (for screenreaders)in hyphenation
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
6.4.5.2 release
Hardware: x86-64 (AMD64) Windows (All)
: medium normal
Assignee: Michael Weghorn
URL:
Whiteboard: target:7.6.0
Keywords: accessibility
Depends on:
Blocks: a11y-Windows
  Show dependency treegraph
 
Reported: 2020-08-14 17:32 UTC by Karl-Heinz Arkenau
Modified: 2023-03-23 19:55 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Sample doc used (11.67 KB, application/vnd.oasis.opendocument.text)
2023-03-22 21:37 UTC, Michael Weghorn
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Karl-Heinz Arkenau 2020-08-14 17:32:47 UTC
Description:
In the dialog für hyphenation is a button, which is not namede, so it is unuseable for people working with screenreaders.

Steps to Reproduce:
1.Open writer
2.Write a few words (more than a line)
3.Open the hyphenation dialog
4. Use "tab" and move through the dialog.
5. The first button next to the word, which is supposed to be seperated is unnamed.

Actual Results:
Screenreader says ony "Button".

Expected Results:
Screenreader announcing the function of the button.


Reproducible: Always


User Profile Reset: Yes


OpenGL enabled: Yes

Additional Info:
Using screenreader NVDA 2020.2
Comment 1 juergenkohler23 2020-09-03 07:23:08 UTC
I reproduced this bug with LibreOffice 7.0 and NVDA 2020.2 using Windows 10.
Comment 2 Matthias Doellert 2020-09-07 14:04:10 UTC
The bug could be reproduced.  Windows 10, Libre Office 7.0.0.3 (x64), NVDA 2020.2 and 2019.2.1
If there is more than one possibility of hyphenation within a word, the shift arrows are not labeled.
Comment 3 juergenkohler23 2020-09-10 07:18:22 UTC
Addition to my exact operating system information:

Windows
Edition	Windows 		10 Home
Version				1909
Operating system build		18363.1016

LibreOffice
Version:	7.0.0.3 (x64)
Build ID: 8061b3e9204bef6b321a21033174034a5e2ea88e
CPU-Threads: 	4; BS: Windows 10.0 Build 18363; UI-Render: Skia/Vulkan; VCL: win
Locale: 	de-DE (de_DE); UI: de-DE
Calc: 		threaded
Comment 4 juergenkohler23 2021-05-17 09:43:03 UTC
In the hyphenation dialogue, the hyphenation suggestions are not read out by NVDA, so that an independent selection is not possible if several suggestions exist. Therefore the bug still exists.


Windows
Edition Windows 10 Home
Version	20H2
Installed on ‎05.‎02.‎2021
Operating system build	19042.985

LibreOffice
Version: 7.1.3.2 (x64) / LibreOffice Community
Build ID: 47f78053abe362b9384784d31a6e56f8511eb1c1
CPU threads: 4; OS: Windows 10.0 Build 19042; UI render: Skia/Raster; VCL: win
Locale: de-DE (de_DE); UI: de-DE
Calc: threaded
Comment 5 Michael Weghorn 2023-03-16 11:51:22 UTC
(In reply to Matthias Doellert from comment #2)
> The bug could be reproduced.  Windows 10, Libre Office 7.0.0.3 (x64), NVDA
> 2020.2 and 2019.2.1
> If there is more than one possibility of hyphenation within a word, the
> shift arrows are not labeled.

Does anybody have a suggestion on what label to use for them? I can think of simply "Previous" and "Next", but maybe there are better and more self-explanatory suggestions.

And should these labels be visible on screen in the buttons or just set as accessible names, which is what e.g. screen readers will use if present?

If they should be on the buttons, the can be set in the .ui file (cui/uiconfig/ui/hyphenate.ui), otherwise accessible names can be set explicitly in the C++ code in `SvxHyphenWordDialog::SvxHyphenWordDialog` (cui/source/dialogs/hyphen.cxx), with sth like

        m_xLeftBtn->set_accessible_name("My accessible name");

(but using translatable strings of course).


Note that there's also  bug 136025 for the word/hyphenation not being announced properly, so this ticket is only about the "arrow" buttons.
Comment 6 Heiko Tietze 2023-03-17 10:11:27 UTC
Help says: 
"Left / Right Arrow
Set the position of the hyphen. This option is only available if more than one hyphenation suggestion is displayed."

We could use this Left/Right for both the accessibility names and tooltips, which are missing too.
Comment 7 Michael Weghorn 2023-03-22 21:37:06 UTC
Created attachment 186144 [details]
Sample doc used

(In reply to Heiko Tietze from comment #6)
> Help says: 
> "Left / Right Arrow
> Set the position of the hyphen. This option is only available if more than
> one hyphenation suggestion is displayed."
> 
> We could use this Left/Right for both the accessibility names and tooltips,
> which are missing too.

Thanks. https://gerrit.libreoffice.org/c/core/+/149355 implements setting "Left" and "Right" for a11y name and tooltip.
Comment 8 Commit Notification 2023-03-23 19:55:29 UTC
Michael Weghorn committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/d7f78d469870717cfc356ce12413031b9d86079b

tdf#135769 a11y: Set a11y name and tooltip for buttons in hyphenation dialog

It will be available in 7.6.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.