Bug 135946 - [Calc][FILEOPEN/FILESAVE] French (latin-1 / ISO-8859-1) accents aren't detected anymore (5.4.5.1 detects them | master does not)
Summary: [Calc][FILEOPEN/FILESAVE] French (latin-1 / ISO-8859-1) accents aren't detect...
Status: RESOLVED INSUFFICIENTDATA
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.1.0.0.alpha0+
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: XLS
  Show dependency treegraph
 
Reported: 2020-08-20 11:37 UTC by Pierre Marty
Modified: 2021-05-17 03:44 UTC (History)
1 user (show)

See Also:
Crash report or crash signature:


Attachments
Broken file (6.00 KB, application/vnd.ms-excel)
2020-08-20 11:39 UTC, Pierre Marty
Details
Re-exported file (8.50 KB, application/vnd.ms-excel)
2020-08-20 11:47 UTC, Pierre Marty
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pierre Marty 2020-08-20 11:37:49 UTC
Description:
I got a file, created with excel-2003, that is supposedly encoded in latin-1 / ISO-8859-1 as the 1st line expressed it:
<?xml version="1.0" encoding="ISO-8859-1"?>
<?mso-application progid="Excel.Sheet"?>

file command confirmed it:
DOC.xls: XML 1.0 document, ISO-8859 text



Steps to Reproduce:
Here is the point, when the file is opened with LO-5.4.5.1 the accents are correctly displayed but with the version compiled from master the accents are replaced by '?'.

Actual Results:
Workaround:

If I open that file in LO-5.4.5.1 and re-export it (e.g.: .xls) the accents are now correctly displayed even when opened with LO-7.1.0.0-alpha+


Expected Results:
Is that coming from the file or is there a regression in the text encoding detection of LO?


Reproducible: Always


User Profile Reset: Yes



Additional Info:
Experienced in:
Version: 7.1.0.0.alpha0+
Build ID: eebe5ea1a815dfdb7c29a950d904002dc601f92c
CPU threads: 8; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-US (en_US.UTF-8); UI: en-US
Calc: threaded

Not in:
Version: 5.4.5.1 (x64)
Build ID: 79c9829dd5d8054ec39a82dc51cd9eff340dbee8
CPU threads: 2; OS: Windows 6.19; UI render: default; 
Locale: fr-FR (fr_FR); Calc: group
Comment 1 Pierre Marty 2020-08-20 11:39:52 UTC
Created attachment 164491 [details]
Broken file
Comment 2 Pierre Marty 2020-08-20 11:47:19 UTC
Created attachment 164492 [details]
Re-exported file
Comment 3 Julien Nabet 2020-08-20 12:00:17 UTC
On pc Debian x86-64 with master sources updated today, I could reproduce this.
Comment 4 Jean-Sebastien Bevilacqua 2020-10-15 08:41:08 UTC
Hello,

I tested it on the following versions on Windows:

5.0.0.1 -> KO
5.3.7.2 -> KO
5.4.0.1 -> KO
5.4.5.1 -> KO
5.4.7.2 -> KO

It's not working with the Broken file.
In my case, on Windows, it's not working with the 5.4 version.

Sincerely,
Jean-Sébastien
Comment 5 Jean-Sebastien Bevilacqua 2020-10-15 14:35:49 UTC
I manage to reproduce the issue with another file.

I did a bisection and I found this commit:
 152c79ee2be2374334202dc738a8f011e47845c7
Comment 6 Aron Budea 2020-10-17 06:53:19 UTC
(In reply to Pierre Marty from comment #0)
> Description:
> I got a file, created with excel-2003, that is supposedly encoded in latin-1
> / ISO-8859-1 as the 1st line expressed it:
> <?xml version="1.0" encoding="ISO-8859-1"?>
> <?mso-application progid="Excel.Sheet"?>
> 
> file command confirmed it:
> DOC.xls: XML 1.0 document, ISO-8859 text
I see question marks with the "Broken file" even in Excel 2013. Plus in Calc my experience is the same as Jean-Sebastien's in comment 4.

It's a binary Excel file, not XML, isn't it? And the file content contains "Calc", which makes me suspicious that at some point of time it was saved in Calc, and is not the Excel original. Please clarify, and attach a reliable reproducer.
Comment 7 QA Administrators 2021-04-16 03:56:42 UTC Comment hidden (obsolete)
Comment 8 QA Administrators 2021-05-17 03:44:14 UTC
Dear Pierre Marty,

Please read this message in its entirety before proceeding.

Your bug report is being closed as INSUFFICIENTDATA due to inactivity and
a lack of information which is needed in order to accurately
reproduce and confirm the problem. We encourage you to retest
your bug against the latest release. If the issue is still
present in the latest stable release, we need the following
information (please ignore any that you've already provided):

a) Provide details of your system including your operating
   system and the latest version of LibreOffice that you have
   confirmed the bug to be present

b) Provide easy to reproduce steps – the simpler the better

c) Provide any test case(s) which will help us confirm the problem

d) Provide screenshots of the problem if you think it might help

e) Read all comments and provide any requested information

Once all of this is done, please set the bug back to UNCONFIRMED
and we will attempt to reproduce the issue. Please do not:

a) respond via email 

b) update the version field in the bug or any of the other details
   on the top section of our bug tracker

Warm Regards,
QA Team

MassPing-NeedInfo-FollowUp