Steps to reproduce: 1. Open Writer. 2. View > Toolbars > Logo. 3. Move the Logo toolbar to a new row, so all its items are visible. 4. Click inside the edit field at the end of the toolbar. 5. Press F1 (as advertised in its tooltip - "... press Enter for command execution or F1 for help".) (6. Agree to read the help online, if you don't have the offline help.) Expected result: The LibreLogo help page is opened, as in 6.4. Actual result: "Welcome to the LibreOffice Writer Help" or "Help Page Not Found" (depending on whether it's a gtk3 or gen). bibisected this to: commit 0ea8aab3ed9defd45de4b64d7bfbbd05b3053e0a Author: Caolán McNamara <caolanm@redhat.com> Date: Wed Apr 22 14:17:20 2020 +0100 weld EditControl as used by the LibreLogo toolbar Change-Id: Ice60d1f5146a58cab5bab44a12a2bdcf4dbd77ec Adding Cc: to Caolán McNamara
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/c2f03b1f5d2579b33140cd910115fffff76c4f9e tdf#135965 let F1 in gtk widgets embedded in a GtkSalFrame call help It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/2ded9c20f56aa23ac50c894bab6e001fc3cc0d5d Resolves: tdf#135965 blank helpids for EditControl children It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
fixed in master, backport to 7-0 in gerrit
Thanks, problem is solved for gen. But for gtk3 I get now 3 "read help online" prompts, which lead to 3 tabs opened in the browser, with only one being correct. And if I check "Do not show this dialog again", then next time it will open 5 tabs, with 2 of them being the correct one.
works fine in --with-help, so probably hides that there are multiple calls to it in that mode which is apparent in --without-help
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/916fe7fa8f12d32e5303420f4f1b28d2a8ec8ff1 Resolves: tdf#135965 distinguish between press and release It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/d27a41606bc1d860b1d7b07d9f3e004a52947ac6 Related: tdf#135965 return true to show event was handled It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Caolán McNamara committed a patch related to this issue. It has been pushed to "master": https://git.libreoffice.org/core/commit/15988fe00c4f49ae32ab2d5cf3c16495ab6e1d59 Related: tdf#135965 don't install accel group on adapter It will be available in 7.1.0. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
that should fully work now, with backport of additional piece rolled into 7-0 proposed patch in gerrit
Caolán McNamara committed a patch related to this issue. It has been pushed to "libreoffice-7-0": https://git.libreoffice.org/core/commit/c4ad7eae4800fe7aa2d8f362d4effa160d5c476f tdf#135965 let F1 in gtk widgets embedded in a GtkSalFrame call help It will be available in 7.0.2. The patch should be included in the daily builds available at https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More information about daily builds can be found at: https://wiki.documentfoundation.org/Testing_Daily_Builds Affected users are encouraged to test the fix and report feedback.
Verified, thanks again!