Description: following steps, I can't delete row on sheet. detail is screencast. Steps to Reproduce: 1. open calc 2. Tools - Protect Sheet -> launch Protect Sheet dialog 3. check "Delete rows" to ON 4. click OK 5. open Menu - Sheet - Delete Rows Actual Results: Menu - Sheet - Delete Rows is gray out user can't delete rows on sheet Expected Results: Menu - Sheet - Delete Rows is not gray out user can delete rows on sheet Reproducible: Always User Profile Reset: No Additional Info: I confirm Version: 7.1.0.0.alpha0+ Build ID: <buildversion> CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3 Locale: ja-JP (ja_JP.UTF-8); UI: en-US TinderBox: Linux-rpm_deb-x86_64@86-TDF, Branch:master, Time: 2020-08-19_02:56:36 Calc: threaded
Created attachment 164545 [details] ScreenCast
https://opengrok.libreoffice.org/xref/core/officecfg/registry/data/org/openoffice/Office/UI/CalcCommands.xcu?r=7b480207#1054 https://opengrok.libreoffice.org/xref/core/sc/sdi/cellsh.sdi?r=02cac3ee#123 https://opengrok.libreoffice.org/xref/core/sc/source/ui/view/cellsh.cxx?r=e67657d5#123 there is no SID_DEL_ROWS in switch statement. therefore bEditable is important. https://opengrok.libreoffice.org/xref/core/sc/source/ui/view/cellsh.cxx?r=e67657d5#313 https://opengrok.libreoffice.org/xref/core/sc/source/ui/view/cellsh.cxx?r=e67657d5#316 https://opengrok.libreoffice.org/xref/core/sc/source/ui/view/cellsh.cxx?r=e67657d5#106 https://opengrok.libreoffice.org/xref/core/sc/source/core/data/table2.cxx?r=75f398b2#2428 while the menu items like FID_INS_ROWS_BEFORE relies on IsEditActionAllowed https://opengrok.libreoffice.org/xref/core/sc/source/ui/view/cellsh.cxx?r=e67657d5#241
(In reply to himajin100000 from comment #2) > https://opengrok.libreoffice.org/xref/core/officecfg/registry/data/org/ > openoffice/Office/UI/CalcCommands.xcu?r=7b480207#1054 > > https://opengrok.libreoffice.org/xref/core/sc/sdi/cellsh.sdi?r=02cac3ee#123 > > https://opengrok.libreoffice.org/xref/core/sc/source/ui/view/cellsh. > cxx?r=e67657d5#123 > > there is no SID_DEL_ROWS in switch statement. > > therefore bEditable is important. > > https://opengrok.libreoffice.org/xref/core/sc/source/ui/view/cellsh. > cxx?r=e67657d5#313 > > https://opengrok.libreoffice.org/xref/core/sc/source/ui/view/cellsh. > cxx?r=e67657d5#316 > > https://opengrok.libreoffice.org/xref/core/sc/source/ui/view/cellsh. > cxx?r=e67657d5#106 > > https://opengrok.libreoffice.org/xref/core/sc/source/core/data/table2. > cxx?r=75f398b2#2428 > > while the menu items like FID_INS_ROWS_BEFORE relies on IsEditActionAllowed > > https://opengrok.libreoffice.org/xref/core/sc/source/ui/view/cellsh. > cxx?r=e67657d5#241 So can you fix it?
https://gerrit.libreoffice.org/c/core/+/102115