Bug 136155 - "Sort" Dialogue Box Too Large for Long Sort Keys
Summary: "Sort" Dialogue Box Too Large for Long Sort Keys
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
6.4.5.2 release
Hardware: All Linux (All)
: medium minor
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.1.0.2 target:7.0.5 target:7.2.0
Keywords:
Depends on:
Blocks:
 
Reported: 2020-08-26 17:57 UTC by Michael DeBellevue
Modified: 2021-01-15 13:38 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments
Minimal working example. Execute "sort" on "B2" to reproduce. (10.19 KB, application/vnd.oasis.opendocument.spreadsheet)
2020-08-26 18:00 UTC, Michael DeBellevue
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Michael DeBellevue 2020-08-26 17:57:52 UTC
Description:
When the sort menu is opened, libreoffice calc will attempt to use column headers to fill "sort key" dialogue box menu options.  These menu options do not permit wrapping or truncating text.  Hence, if the column headers are too large, then the "sort" dialogue box will be made too large to fit the user's screen.  The user is not able to resize this box, rendering sorting impossible unless the user shortens the column header.

To be fair, excessively long column headers are probably bad practice.  I noticed this behavior when manipulating a sheet created by a google form, which had the survey questions for column headers, and hence the column headers were rather long.  So it was something that I encountered in what I would consider to be a "normal use" activity.

I observed this problem on the latest stable release 6.4.6 at the time of this writing, I attempted to resolve this issue by doing a clean install of the latest version (7.0.0 at the time of this writing), and this did not resolve the bug.  Hence, I do not believe that this is related to my user configuration, nor that it is specific to any version of Libreoffice.

Steps to Reproduce:
1. Create a spreadsheet such that the "sort" option autofills the sort key with a cell entry.  I don't understand how the sort option decides when to do this, but I accomplished this by creating a rectangular table of numbers with text entries on the top row.
2. Make one of the column headers be a very long single line.
3. Select the column in question, so that "sort" will use that column's header as its initial guess for the sort key.
4. Hit "sort" or select it from the "data" menu.

Actual Results:
Sort dialogue box has width set to the width of the column header, irrespective of user monitor size.

Expected Results:
Window should be capped at the monitor size, or should be resizable to allow the user to still see the entire dialogue box.  Long cell entries for sort keys should wrap


Reproducible: Always


User Profile Reset: No


OpenGL enabled: Yes

Additional Info:
[Information automatically included from LibreOffice]
Locale: en-US
Module: SpreadsheetDocument
[Information guessed from browser]
OS: Linux (All)
OS is 64bit: yes
Comment 1 Michael DeBellevue 2020-08-26 18:00:31 UTC
Created attachment 164726 [details]
Minimal working example.  Execute "sort" on "B2" to reproduce.
Comment 2 raal 2021-01-10 22:53:13 UTC
I can confirm with Version: 7.2.0.0.alpha0+
Build ID: 6bb6eb1692d7dd432103d0e7278534390084caf6
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: gtk3
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded

Works in "gen" Version: 7.2.0.0.alpha0+
Build ID: 6bb6eb1692d7dd432103d0e7278534390084caf6
CPU threads: 4; OS: Linux 4.15; UI render: default; VCL: x11
Locale: cs-CZ (cs_CZ.UTF-8); UI: en-US
Calc: threaded

Adding CC to Caolán
Comment 3 Commit Notification 2021-01-14 15:37:51 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-1":

https://git.libreoffice.org/core/commit/1052c9c8bb763866ba6b2cb9b86063f22d6fb9ee

tdf#136155 let the other elements in the dialog determine the final width

It will be available in 7.1.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2021-01-15 12:55:07 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/b8cf344577437338e05c0d84dff78927817558c1

tdf#136155 let the other elements in the dialog determine the final width

It will be available in 7.0.5.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Commit Notification 2021-01-15 12:56:24 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/3bb8ed02c2832b066d42507567dfb0d3136d5939

tdf#136155 let the other elements in the dialog determine the final width

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.