Bug 136225 - Chinese script has wrong rotation in a specific PPTX
Summary: Chinese script has wrong rotation in a specific PPTX
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Impress (show other bugs)
Version:
(earliest affected)
3.6.0.4 release
Hardware: All All
: medium normal
Assignee: Not Assigned
URL:
Whiteboard: target:7.5.0
Keywords: bibisected, bisected, filter:pptx, regression
: 136226 (view as bug list)
Depends on:
Blocks: CJK PPTX
  Show dependency treegraph
 
Reported: 2020-08-28 12:35 UTC by Mike Kaganski
Modified: 2023-08-21 13:37 UTC (History)
4 users (show)

See Also:
Crash report or crash signature:


Attachments
Sample PPTX fixed by regressing commit (28.78 KB, application/vnd.openxmlformats-officedocument.presentationml.presentation)
2021-03-07 00:41 UTC, Aron Budea
Details
How it should look like (72.00 KB, image/jpeg)
2023-08-21 10:06 UTC, Mike Kaganski
Details
How it looks like in LO (64.28 KB, image/jpeg)
2023-08-21 10:49 UTC, Mike Kaganski
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Mike Kaganski 2020-08-28 12:35:36 UTC
Open attachment 164800 [details]. The characters in it are rotated wrong. LibreOffice shows it like https://ask.libreoffice.org/upfiles/15986067617456284.png, while the correct display should be https://ask.libreoffice.org/upfiles/15986067902939979.png.

Tested with Version: 7.1.0.0.alpha0+ (x64)
Build ID: 490cab0539660aa8e1b51f0555b890f69940c04d
CPU threads: 12; OS: Windows 10.0 Build 19041; UI render: Skia/Raster; VCL: win
Locale: en-US (ru_RU); UI: en-US
Calc: CL

Ref: https://ask.libreoffice.org/en/question/262775/
Comment 1 Mike Kaganski 2020-08-28 12:56:45 UTC Comment hidden (obsolete)
Comment 2 Mike Kaganski 2020-08-28 13:04:59 UTC Comment hidden (obsolete)
Comment 3 Mike Kaganski 2020-08-28 13:08:41 UTC
Already bad in Version Version 3.6.0.4 (Build ID: 932b512)

Good in LibreOffice 3.5.0rc3 
Build ID: 7e68ba2-a744ebf-1f241b7-c506db1-7d53735
Comment 4 Mike Kaganski 2020-08-28 13:10:45 UTC
*** Bug 136226 has been marked as a duplicate of this bug. ***
Comment 5 Roman Kuznetsov 2020-09-13 18:44:38 UTC
confirm in

Version: 7.1.0.0.alpha0+ (x64)
Build ID: 3ad21220992e348ccfc59ce5ffb67ee9dd0e4b88
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Vulkan; VCL: win
Locale: ru-RU (ru_RU); UI: en-US
Calc: CL
Comment 6 Aron Budea 2021-03-01 08:57:12 UTC
This could be bibisected to the following range using repo bibisect-43all:
https://cgit.freedesktop.org/libreoffice/core/log/?qt=range&q=f1c162967f032fcc5e4859f67c5b614c5dd19642..4eedf5dc54ab19af39d7033462421082d1abb86d

The following commit stands out:
https://cgit.freedesktop.org/libreoffice/core/commit/?id=8167b8f3d9ca506a30bd8454d934d713033cb8b4
author		Muthu Subramanian <sumuthu@suse.com>	2012-02-14 19:49:31 +0530
committer	Muthu Subramanian <sumuthu@suse.com>	2012-02-14 19:50:40 +0530

n744510: Improved 'vert' text imports.
Comment 7 Aron Budea 2021-03-07 00:41:45 UTC
Created attachment 170279 [details]
Sample PPTX fixed by regressing commit

(In reply to Aron Budea from comment #6)
> The following commit stands out:
> https://cgit.freedesktop.org/libreoffice/core/commit/
> ?id=8167b8f3d9ca506a30bd8454d934d713033cb8b4
Confirmed by reverting. Attaching minimal PPTX this commit fixed, the text is supposed to be rotated 90° counter-clockwise, while it used to be rotated 90° clockwise.
Comment 8 QA Administrators 2023-03-08 03:26:14 UTC Comment hidden (obsolete)
Comment 9 Julien Nabet 2023-08-21 10:02:58 UTC
I wanted to give a try but links to the png files are now 404.
Could someone give it a try and if it's still wrong attach a png showing what's expected?
Comment 10 Mike Kaganski 2023-08-21 10:06:19 UTC
Created attachment 189062 [details]
How it should look like

(In reply to Julien Nabet from comment #9)

Yes, the links were to the old Ask site; but the "Ref" link to the question itself still works.
Comment 11 Mike Kaganski 2023-08-21 10:49:26 UTC
Created attachment 189067 [details]
How it looks like in LO
Comment 12 Julien Nabet 2023-08-21 13:00:43 UTC
(In reply to Mike Kaganski from comment #10)
> Created attachment 189062 [details]
> How it should look like
> 
> (In reply to Julien Nabet from comment #9)
> 
> Yes, the links were to the old Ask site; but the "Ref" link to the question
> itself still works.

Thank you for the quick feedback.
On pc Debian x86-64 with master sources updated today or wit LO Debian package 7.5.5.2, even with gen rendering, I don't reproduce this :-(
Comment 13 Julien Nabet 2023-08-21 13:11:57 UTC
I also made a test on Win10 with LO 7.5.5.2, I don't reproduce this too.
Did I miss something?
Comment 14 Mike Kaganski 2023-08-21 13:15:51 UTC
(In reply to Julien Nabet from comment #13)

Likely not - I also do not repro it anymore :-) I just didn't check it, only restored the screenshots from that Ask site :-)
Comment 15 Julien Nabet 2023-08-21 13:17:17 UTC
(In reply to Mike Kaganski from comment #14)
> (In reply to Julien Nabet from comment #13)
> 
> Likely not - I also do not repro it anymore :-) I just didn't check it, only
> restored the screenshots from that Ask site :-)

No pb, thank you! :-)
Comment 16 Aron Budea 2023-08-21 13:37:10 UTC
This got fixed by the following commit, thanks to Regina for the fix!

https://cgit.freedesktop.org/libreoffice/core/commit/?id=7e23cbdbb6ec0247a29ed8a8f744c01e10963ea0
author		Regina Henschel <rb.henschel@t-online.de>	2022-06-25 00:07:43 +0200
committer	Miklos Vajna <vmiklos@collabora.com>	2022-07-20 08:16:03 +0200

tdf#149551 separate TextRotateAngle from TextPreRotateAngle