Bug 136362 - Image toolbar in Calc contains an unnecessary blank area and a corresponding menu option with no text
Summary: Image toolbar in Calc contains an unnecessary blank area and a corresponding ...
Status: NEW
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.0.0.2 rc
Hardware: All All
: medium minor
Assignee: Not Assigned
URL:
Whiteboard:
Keywords: difficultyBeginner, easyHack, skillDesign, topicDesign
Depends on:
Blocks: Calc-Toolbars
  Show dependency treegraph
 
Reported: 2020-09-01 10:36 UTC by Steve Fanning
Modified: 2021-05-11 03:49 UTC (History)
5 users (show)

See Also:
Crash report or crash signature:


Attachments
Screenshot showing blank menu entry (10.17 KB, image/png)
2020-09-01 12:57 UTC, Steve Fanning
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Steve Fanning 2020-09-01 10:36:28 UTC
Description:
After a clean install of LibreOffice 7.0.0.2, the Image toolbar is not visible in Calc. When it is made visible, there is a blank area at the right of the toolbar which appears to be unnecessary but probably is not a problem. However, if you right-click somewhere on the toolbar and open the Visible Buttons menu, you will find a menu option that controls the display of this blank area (on / off). Unfortunately, a typical user is likely to be very confused by this menu option because it contains no text at all.

Why is this blank space needed, why is there an option to turn its display on / off, and why does that option contain no text?

I would recommend that this issue be reviewed by the LibreOffice Design and User Experience team.


Steps to Reproduce:
1. Select View > Toolbars > Image. Calc displays the Image toolbar at the right of the Formatting toolbar.
2. Right-click somewhere in the toolbar and de-select Lock Toolbar Position in the context menu.
3. Hover the mouse over the left end of the toolbar until the cursor shape changes shape and then drag the Image toolbar to a new position. The toolbar is now a floating toolbar, surrounded by a frame.
4. You can view the unnecessary white space at the right end of the toolbar, below the close (X) icon.
5. Click the down arrow at the right end of the toolbar’s frame and click on the Visible Buttons option.
6. View the options in the Visible Buttons menu. Towards the bottom, between the Color and Line options, there is an option with no text on it. What is the user supposed to do with this?


Actual Results:
See steps to reproduce above

Expected Results:
Would not expect to see a menu option that contains no text at all.


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.0.0.2 (x64)
Build ID: c01aa64b6c3d89ebe5fe69c28c7adb24eb85249c
CPU threads: 6; OS: Windows 10.0 Build 18363; UI render: Skia/Vulkan; VCL: win
Locale: en-GB (en_GB); UI: en-US
Calc: threaded
Comment 1 Steve Fanning 2020-09-01 12:57:28 UTC
Created attachment 164962 [details]
Screenshot showing blank menu entry

Attached screenshot of lower part of Visible Buttons menu for Calc's Image toolbar, with blank menu entry highlighted.
Comment 2 Buovjaga 2021-05-07 15:43:30 UTC
Confirmed

Arch Linux 64-bit
Version: 7.2.0.0.alpha0+ / LibreOffice Community
Build ID: 13aaeb5d148c1ea5163eecaa176fac4a67689277
CPU threads: 8; OS: Linux 5.12; UI render: default; VCL: gtk3
Locale: fi-FI (fi_FI.UTF-8); UI: en-US
Calc: threaded
Built on 7 May 2021
Comment 3 Buovjaga 2021-05-09 12:13:59 UTC
Code pointer: sc/uiconfig/scalc/toolbar/graphicobjectbar.xml

The line is

<toolbar:toolbaritem xlink:href=".uno:GraphicDialog"/>

Added in

https://git.libreoffice.org/core/commit/e48fc4d011f43d5d2260e4db435fa925037cbcd8
tdf#120856 sync shape, graphic, frame and ole contect toolbar
Comment 4 V Stuart Foote 2021-05-09 14:59:16 UTC
(In reply to Buovjaga from comment #3)
> Code pointer: sc/uiconfig/scalc/toolbar/graphicobjectbar.xml
> 
> The line is
> 
> <toolbar:toolbaritem xlink:href=".uno:GraphicDialog"/>
> 
> Added in
> 
> https://git.libreoffice.org/core/commit/
> e48fc4d011f43d5d2260e4db435fa925037cbcd8
> tdf#120856 sync shape, graphic, frame and ole contect toolbar

Yes, but isn't the .uno:GraphicDialog widget (commonly <F4> shortcut)  undefined in any sense for Calc other than being in the scalc/toolbar/graphicobjectbar.xml and incorrectly in a couple of the Notebook bar .UI configs? Should probably just be removed.
Comment 5 Heiko Tietze 2021-05-10 10:08:29 UTC
The command uno:GraphicDialog is linked to FN_FORMAT_GRAFIC_DLGwhich has its execution function at sw/source/uibase/shells/grfsh.cxx. There is no image properties dialog other than in Writer and labels are consequently only defined for Writer in officecfg/registry/data/org/openoffice/Office/UI/WriterCommands.xcu

In a nutshell: remove this command from other modules, code pointer in comment 3. Also check the Notebookbars.