Bug 136364 - Multiple non-contiguous ranges (range list/concatenation/union) broken on import from Excel and in UI
Summary: Multiple non-contiguous ranges (range list/concatenation/union) broken on imp...
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
6.2 all versions
Hardware: All All
: medium normal
Assignee: Eike Rathke
URL:
Whiteboard: target:7.1.0 target:7.0.2 target:6.4.7
Keywords: regression
Depends on:
Blocks:
 
Reported: 2020-09-01 11:31 UTC by Anna Longari
Modified: 2020-09-29 15:11 UTC (History)
2 users (show)

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Anna Longari 2020-09-01 11:31:10 UTC
I open an excel file with a formula like this RANK(A2,(A2:A4,A6:A10,A14:A20,A30:A40)) libreoffice calc translate only 2 commas in tilde and I have RANK(A2,(A2:A4~A6:A10,A14:A20~A30:A40)) and the system get error. Why? Can I resolve the problem setting better libreoffice? I use libreoffice 6.4 on ubuntu 18.04
Comment 1 Anna Longari 2020-09-01 11:35:34 UTC
The problem is present also if you try to define a rank on multiple cells (using CTRL click) directly in Libreoffice
Comment 2 Eike Rathke 2020-09-01 19:08:58 UTC
Fwiw, I thought there's already a bug for that but didn't find it..

Both UI and Excel import filter don't handle a single argument of a range list of more than two ranges correctly (note the list in extra parentheses, this is something different than simply multiple range arguments), for example

=SUM((B2:B3,C4:C5,D6:D7))

should be converted to

=SUM((B2:B3~C4:C5~D6:D7))

but instead gives

=SUM((B2:B3~C4:C5,D6:D7))

resulting in Err:509 

Same for single cell list concatenation
=SUM((B2,C4,D6))
gives
=SUM((B2~C4,D6))
instead of
=SUM((B2~C4~D6))
Comment 3 Eike Rathke 2020-09-01 19:22:58 UTC
Apparently a regression, a comment on https://ask.libreoffice.org/en/question/263490/problem-with-not-contiguous-ranges/ says it worked until at least 6.1.3.2
Comment 4 Eike Rathke 2020-09-01 19:38:47 UTC
6.1.6 works, 6.2.0 does not.
Comment 5 Commit Notification 2020-09-08 23:15:30 UTC
Eike Rathke committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/e00e2be30436b636d93f8852bb6af44972638a7c

Resolves: tdf#136364 treat svSep type with ocUnion as range type

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 6 Eike Rathke 2020-09-08 23:48:36 UTC
Pending review
https://gerrit.libreoffice.org/c/core/+/102295 for 7-0
https://gerrit.libreoffice.org/c/core/+/102279 for 6-4
Comment 7 Commit Notification 2020-09-09 11:23:33 UTC
Eike Rathke committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/cf4da6ecb2bbae8c9e034c11bd4d745603ecc386

Resolves: tdf#136364 treat svSep type with ocUnion as range type

It will be available in 7.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2020-09-09 11:24:46 UTC
Eike Rathke committed a patch related to this issue.
It has been pushed to "libreoffice-6-4":

https://git.libreoffice.org/core/commit/047351c2f9997dcd345c00c1bc1f0d72c8d62ed9

Resolves: tdf#136364 treat svSep type with ocUnion as range type

It will be available in 6.4.7.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 9 Commit Notification 2020-09-09 19:19:27 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/4a6fedc2e21d7036ae784ed90e78e3eb2fe1b3d5

tdf#136364: sc_subsequent_filters_test: Add unittest

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Xisco Faulí 2020-09-29 15:11:16 UTC
unittest added, setting to VERIFIED