Description: Testing 4.2.8 (62) on iOS revealed, that it's not possible anymore to open the sidebare in the Impress "component". This used to work in previous releases. I can do the "bibisec" if needed using the testflight versions. Steps to Reproduce: 1. Open a presentation file using the iOS app 2. Tap on the sidebare icon in the menu list Actual Results: Nothing happens. Expected Results: The sidebare should appear on the right hand side of the screen. Reproducible: Always User Profile Reset: No Additional Info: 4.2.8 (62) on iOS 13.7
Hmm, yes, can reproduce. After the app process starts, it is possible to open the sidebars in the first document one opens, but when one closes that and opens another one (or the same one again), then the sidebars buttons don't work. I first guess is that some of the JavaScript checks the view id and doesn't show the sidebars if it is greater than zero (and view ids are never re-used, they increase monotonically), or something like that.
This is weird. Usually I can reproduce, then suddenly the sidebars do open again no matter how many documents I have opened and closed earlier. Random bugs are the most fun.
And with a fresh build run from Xcode, I can't reproduce at all. Even if, as far as I see, there shouldn't be any sidebar-related changes between build 62 or 63 and the fresh one. But I need to double-check more carefully.
Have been trying to reproduce this like crazy in systematic testing, where I perform a minimal set of actions, identical on each try (so that the debug output is of manageable size and understandable), but no. But then if I just do stuff in a non-systematic way, I do see it occasionally. But of course in such cases the debug output is not really usable.
Nicolas, of the four buttons in the toolbar that bring up different sidebars, is there some of them that works especially badly for you, or does none of them work at all?
Nicolas, have you tried tapping the buttons twice? Hasn't it always been so that some of the sidebar buttons need to be tapped twice (the first time after opening a document)? (And sure, that is a bug, yes.)
Interesting.. I now also fail to be able to reproduce the issue. But when I created this issue, I could no open any of the four sidebar dialogs (transitions, animations, templates and sidebar itself) in the impress part. I'll try to figure out if there is a way to make it failing reproducible.
I think I found a way to make it ~reproducible. When tapping the "x" (top right corner) to close the file it takes some seconds until the "shutdown" is done. When clicking on the show/hide sidebar button during this "shutdown" a couple of times it will result in the said effect. Open the same (or a different) file after the "shutdown" was finished and you are not able to open the (four) sidebar dialogs anymore. I think I accidentally triggered this because: a.) the "x" button is ~small and chances are (on the screen I have) one also taps the sidebar button involuntary b.) the "shutdown" takes a couple of seconds so I may taped the "x" button twice because I was impatient I thinks it's not a major bug, but if it's easy fixable it would probably not hurt.
Created attachment 165367 [details] Video demonstrating the issue I only tapped once during "shut down" and afterwards the sidebar couldn't be opened.
Yep, that indeed is a reliable way to reproduce, so far. Thanks.
Not sure what has changed late last week or over the weekend, but now the situation feels worse. I don't even need to do any trick like tapping on the X and then quickly before the document has fully gone away, but not too quickly, click one of the sidebar buttons. But sigh, I don't yet have an exact reproduction scenario. It just feels like the bug shows up easier than last week.
... and now made even worse by https://gerrit.libreoffice.org/c/core/+/102347 .
The commit mentioned above was reverted, though. This change might help a bit for this bug: https://gerrit.libreoffice.org/c/online/+/102872 , even if that is not its primary purpose. (It is intended to fix the issue that one had to tap the "modifypage" button in the toolbar of presentation documents (in the iOS app on iPad) twice to get the corresponding sidebar to show up.
Suggested fix (workaround) in https://gerrit.libreoffice.org/c/online/+/103377
When built from the master branch of online (against the cp-6.4 branch of core), the document goes away very quickly after tapping the X button, there is not time for the user to accidentally tap anything else, so the above workaround seems to be necessary only for the co-4-2 branch of online.
This is fixed now. I tested with the iOS app version 4.2.10 (70). Thanks a lot to the Collabora team and especially Tor for taking care of this! I believe this issue can be closed now.
Thanks for testing, Nicolas. In the end it turned out to be easiest to just prevent the issue from happening in the JS....