Bug 136559 - Calc freezes when click "All" in auto-filter dialog
Summary: Calc freezes when click "All" in auto-filter dialog
Status: VERIFIED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Calc (show other bugs)
Version:
(earliest affected)
7.1.0.0.alpha0+
Hardware: All Linux (All)
: medium normal
Assignee: Caolán McNamara
URL:
Whiteboard: target:7.1.0 target:7.0.2
Keywords:
Depends on:
Blocks: GTK3 AutoFilter
  Show dependency treegraph
 
Reported: 2020-09-07 17:20 UTC by Kevin Suo
Modified: 2020-09-30 14:35 UTC (History)
0 users

See Also:
Crash report or crash signature:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Suo 2020-09-07 17:20:50 UTC
Steps to Reproduce:
1. Open Attachment 165127 [details] in bug 136455.
2. Click the auto filter drop down in column A, then click "All" checkbox.

--> Calc freezes.

Reproduce on master when I was testing bug 136455.

This may be a regression. See the following bibisect log. This is not a successful bibisecting - in the skipped builds the freeze appear when I click on the auto filter dropdown, rather than the "All" checkbox.

$ git bisect log
# bad: [d8434f1d14c0c2531b7d9bae3b4761d93bba6bac] 2020-09-07 05:38:15 +0200 7cd3527b8e5bccd99eb171a8d35c554b774a050f
# good: [87c314f049c4333cfac651d5315b758f022c900b] 2020-05-27 13:56:28 +0200 574c57090642347980d2395e1e183cc7b5c171ad
git bisect start 'd8434f1d14c0c2531b7d9bae3b4761d93bba6bac' 'HEAD'
# bad: [2ffb6d7c3544b496e7dff99286d5a2d694690d51] 2020-07-20 20:26:13 +0200 84c412cb8392d306ab87fc06855677612f9938a6
git bisect bad 2ffb6d7c3544b496e7dff99286d5a2d694690d51
# bad: [2278fbbc03817676cda5d2261dbcc6198df5b9c7] 2020-06-27 06:04:13 +0200 4842d8f51fe5b6d8b3e8dca559b7fac550f14fbe
git bisect bad 2278fbbc03817676cda5d2261dbcc6198df5b9c7
# good: [c2878877fdad27d51a82f1af8fa5ad3cde700982] 2020-06-11 08:42:04 +0200 9457326e17505c9a17f40b2f932b21a4436eeae1
git bisect good c2878877fdad27d51a82f1af8fa5ad3cde700982
# bad: [2580c7d53ce04a20f52627f934de0ea1c4935d7e] 2020-06-19 09:06:54 +0200 94eb4f9b19b13f3548a232ec0a1f4b50bcb55d94
git bisect bad 2580c7d53ce04a20f52627f934de0ea1c4935d7e
# skip: [acfb2d5f17763ef6b449e82092e10bd2505ebfd7] 2020-06-15 19:33:16 +0200 e542b622aeb70230365971cab4838dbe0b6e0a93
git bisect skip acfb2d5f17763ef6b449e82092e10bd2505ebfd7
# skip: [166790787b243a224bfd0107e9e96b3b86496074] 2020-06-15 22:05:15 +0200 24cdfe062c8540b4285c9e24556fcb2ece01a7a4
git bisect skip 166790787b243a224bfd0107e9e96b3b86496074
# skip: [06c0801e3b7254d75160ebac3b85b2936319b374] 2020-06-16 15:55:38 +0200 058c21ac4a552ee6f6ca2f67c0d134a819228d53
git bisect skip 06c0801e3b7254d75160ebac3b85b2936319b374
# bad: [d0acefcf67697a7a0551d44f8c1a0ce61542b8a2] 2020-06-18 11:10:06 +0200 241d8e47e708e1912e036f1026f1c43ee1bf84a1
git bisect bad d0acefcf67697a7a0551d44f8c1a0ce61542b8a2
# skip: [b9280dd401480737de1bb3bb34f4f927fd0e5d88] 2020-06-15 15:29:57 +0200 eff3a0e80bb027bf2d5809639a469cbee110089d
git bisect skip b9280dd401480737de1bb3bb34f4f927fd0e5d88
# skip: [ae923e26df0a1f35e532d0b4af5dbd35a797757f] 2020-06-15 16:56:18 +0200 596a909059606c47d87985ae2d32e7d40cdaab24
git bisect skip ae923e26df0a1f35e532d0b4af5dbd35a797757f
# bad: [b3632f7ae8975c91aa8585cfebc48ab779ffd6ee] 2020-06-17 10:20:37 +0200 188632be71502a2e16d9b688761c7e4870ce35c6
git bisect bad b3632f7ae8975c91aa8585cfebc48ab779ffd6ee
# skip: [6f46188fe76cb2968226cdaa893071a4170ebf80] 2020-06-15 09:15:47 +0200 8ce99faaf6714748b0d9912fb7d60f19e1b7d399
git bisect skip 6f46188fe76cb2968226cdaa893071a4170ebf80
# good: [eb670f9d21d07cd0a1a4da89b985eaf67d229b07] 2020-06-12 20:02:40 +0200 fc0cc8fd1ae92eed355e8569fd5ba2fa7cf0cc40
git bisect good eb670f9d21d07cd0a1a4da89b985eaf67d229b07
# skip: [3ce5556172c1fb94f311807227349b2717de51ac] 2020-06-15 15:57:48 +0200 786d0b9abf76b2f84d333e18c902a374ab3b3090
git bisect skip 3ce5556172c1fb94f311807227349b2717de51ac
# skip: [6a70c3aaa45eb7d3a0e101b16d720955adc87fda] 2020-06-16 01:50:33 +0200 33a720ab802491f15b247e09755cd36205b6f435
git bisect skip 6a70c3aaa45eb7d3a0e101b16d720955adc87fda
# skip: [80b4893aba9a4a281ddccc6737d52e8e56ffba7a] 2020-06-16 22:34:23 +0200 f51ea6c297d17299c93e0560a9b4f90ebc2446d4
git bisect skip 80b4893aba9a4a281ddccc6737d52e8e56ffba7a
# skip: [1d471e0c2df84640d71e7c6455684b1d747c6107] 2020-06-15 11:26:38 +0200 05d914f01f6b908a2eb02bb9dbbdf662879e2cdd
git bisect skip 1d471e0c2df84640d71e7c6455684b1d747c6107
# skip: [9b6020d5ae344c50a8e3c9a5fdd1782340aaeeb5] 2020-06-13 15:02:02 +0200 ed18da532f56f7fba076fc83f12507b6361b1e00
git bisect skip 9b6020d5ae344c50a8e3c9a5fdd1782340aaeeb5
# skip: [6db3b029504bf10bce58b1e5a4483c672a016410] 2020-06-15 11:56:03 +0200 4ce1ff56bb63f0e9a10a129f31e604c20007d5d1
git bisect skip 6db3b029504bf10bce58b1e5a4483c672a016410
# skip: [07c199f3344ee8141a466a4ef79ac1bdb6c132fd] 2020-06-16 18:53:01 +0200 c43e62f26f8d51c2ad97f6c93877ce9d3ae9639e
git bisect skip 07c199f3344ee8141a466a4ef79ac1bdb6c132fd
# skip: [a42fcbe5fa95a78bf11aa9bd950622e44f29596c] 2020-06-15 12:14:38 +0200 d570062ff9899e78553bfbe412bdf88ff62a5396
git bisect skip a42fcbe5fa95a78bf11aa9bd950622e44f29596c
# skip: [930877d438cc6e9e6d980b70b7e2e93ce937d6a6] 2020-06-13 21:50:09 +0200 fc617677dedc2ee6f52149bac71195420bc351f3
git bisect skip 930877d438cc6e9e6d980b70b7e2e93ce937d6a6
# skip: [2458ef8150bcdf1b7bd88f2b6a3742c83e22e32c] 2020-06-15 09:48:46 +0200 37d5cccceb9f02d60de326f5b1fc5098dc004739
git bisect skip 2458ef8150bcdf1b7bd88f2b6a3742c83e22e32c
# skip: [6ee990ccd82d564d9aa41fee53e9c8111a57eda6] 2020-06-16 13:41:57 +0200 559765ca62f5e581dd5040bdf24e504cf38b0397
git bisect skip 6ee990ccd82d564d9aa41fee53e9c8111a57eda6
# skip: [ce1618f459f66decf9e4d6dd89fc2ec9d8ecfdd0] 2020-06-15 13:30:58 +0200 43bdac0ebd65dfc32a0b8cf2c42fde88ad585e3f
git bisect skip ce1618f459f66decf9e4d6dd89fc2ec9d8ecfdd0
# skip: [1d93bf882c76c52a03b6581b9a14def6364e61a6] 2020-06-14 01:51:21 +0200 d4207fa7cd5986d137dc8a67cbc40a043834dfc0
git bisect skip 1d93bf882c76c52a03b6581b9a14def6364e61a6
# skip: [ca9f257d95eb1127d0bf95cbd669439006101a20] 2020-06-16 09:36:05 +0200 baa55eca0b653d4f661c08f5b6593caa3b186e89
git bisect skip ca9f257d95eb1127d0bf95cbd669439006101a20
Comment 1 Kevin Suo 2020-09-07 17:21:33 UTC
This may be a gtk3 only bug. My system is Fedora 32 x64.
Comment 2 Roman Kuznetsov 2020-09-17 19:45:28 UTC
no repro in

Version: 7.1.0.0.alpha0+ (x64)
Build ID: 8c18cd6823ddf4ef5ba67801a84cee26c9b5a9a6
CPU threads: 4; OS: Windows 6.1 Service Pack 1 Build 7601; UI render: Skia/Vulkan; VCL: win
Locale: ru-RU (ru_RU); UI: ru-RU
Calc: CL
Comment 3 Commit Notification 2020-09-18 11:49:58 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/897bd0517d835ba00458279311e5d8ff11079dd7

Related: tdf#136559 set multiple columns in model at the same time

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 4 Commit Notification 2020-09-19 11:18:38 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/798ee4543a91f16340f9962b36bccd1446ccdb7f

tdf#136559 use freeze+all_foreach for performance

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 5 Caolán McNamara 2020-09-19 11:42:07 UTC
In the case we don't need a Tree, but only need a List we can get a real benefit from using a GtkListStore
Comment 6 Commit Notification 2020-09-20 16:52:20 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/fcf2f4ac837982e1fae49ddd75383ceab4e2bda7

tdf#136559 We can get a performance boost from using a ListStore

It will be available in 7.1.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 7 Caolán McNamara 2020-09-20 16:55:54 UTC
ListStore worked very well for this case
Comment 8 Kevin Suo 2020-09-23 01:59:53 UTC
Verified fixed on master. I am not sure whether this affects 7.0 also?
Comment 9 Commit Notification 2020-09-23 09:19:43 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-0":

https://git.libreoffice.org/core/commit/4475895d1b1da285bfe5bd73e383f1356d5e01b2

Related: tdf#136559 set multiple columns in model at the same time

It will be available in 7.0.3.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 10 Commit Notification 2020-09-30 14:34:42 UTC
Caolán McNamara committed a patch related to this issue.
It has been pushed to "libreoffice-7-0-2":

https://git.libreoffice.org/core/commit/7f34bbc45eac8212da46b10406c0a2627fb21cc7

Related: tdf#136559 set multiple columns in model at the same time

It will be available in 7.0.2.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.