Bug 136578 - Not able to delete an specific page break
Summary: Not able to delete an specific page break
Status: RESOLVED FIXED
Alias: None
Product: LibreOffice
Classification: Unclassified
Component: Writer (show other bugs)
Version:
(earliest affected)
unspecified
Hardware: All All
: medium normal
Assignee: Justin L
URL:
Whiteboard: target:7.2.0
Keywords: preBibisect
Depends on:
Blocks:
 
Reported: 2020-09-08 17:52 UTC by Telesto
Modified: 2020-12-23 18:42 UTC (History)
3 users (show)

See Also:
Crash report or crash signature:


Attachments
Example file (8.26 KB, application/vnd.oasis.opendocument.text)
2020-09-08 17:52 UTC, Telesto
Details
editPageBreaks.odt: various testing scenarios. (12.66 KB, application/vnd.oasis.opendocument.text)
2020-12-21 09:48 UTC, Justin L
Details
This file crashes deleting the pagebreak (11.49 KB, application/vnd.oasis.opendocument.text)
2020-12-21 16:33 UTC, Xisco Faulí
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Telesto 2020-09-08 17:52:23 UTC
Description:
Not able to delete an specific page break

Steps to Reproduce:
1. open the attached file
2. Hoovever over the page break line
3. Delete page break

Actual Results:
Nothing

Expected Results:
Deletion


Reproducible: Always


User Profile Reset: No



Additional Info:
Version: 7.1.0.0.alpha0+ (x64)
Build ID: e8b8e7be0b2ad693224cd94062a55610eb69df7e
CPU threads: 4; OS: Windows 6.3 Build 9600; UI render: Skia/Raster; VCL: win
Locale: nl-NL (nl_NL); UI: en-US
Calc: CL
Comment 1 Telesto 2020-09-08 17:52:42 UTC
Created attachment 165283 [details]
Example file
Comment 2 BogdanB 2020-09-09 05:46:35 UTC
I confirm it can NOT be deleted using the right click, but it can be deleted pressing Delete after "xx".

Version: 7.0.1.2
Build ID: 7cbcfc562f6eb6708b5ff7d7397325de9e764452
CPU threads: 4; OS: Linux 5.4; UI render: default; VCL: gtk3
Locale: en-US (ro_RO.UTF-8); UI: en-US
Calc: threaded
Comment 3 Justin L 2020-12-18 18:41:56 UTC
This is a legitimate bug report. Normally breaks are "before", but in this case the break is "after" the xx paragraph. So the blue line isn't smart enough to know which paragraph it should be looking at.

I thought I looked at this earlier, but spot checking back a few versions never shows it working. Also wasn't working in LO 3.5.

I note that both a break-after and a break-before are possible. When removing from this blue bar, I suppose it ought to remove BOTH if both are specified.

However, for EDITING, some smarts need to be built in - so that it picks the paragraph that contains the break.  If both contain the break, first come, first served I guess.
Comment 4 Justin L 2020-12-21 09:45:59 UTC
Proposed patches:
-http://gerrit.libreoffice.org/c/core/+/108071 NFC flatten PageBreakWin and minor cleanup
-http://gerrit.libreoffice.org/c/core/+/108072 tdf#136578 sw BreakDashedLine: edit/delete PageAfter
Comment 5 Justin L 2020-12-21 09:48:56 UTC
Created attachment 168372 [details]
editPageBreaks.odt: various testing scenarios.
Comment 6 Xisco Faulí 2020-12-21 16:33:38 UTC
Created attachment 168386 [details]
This file crashes deleting the pagebreak

Hi Justin,
Thanks for the patches. While trying to find a way to test it, I found the document attached crashes deleting the pagebreak with your patches
Comment 7 Commit Notification 2020-12-22 15:56:42 UTC
Justin Luth committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/6156a419a2d3f09d91afd00f84c84ba717442f43

tdf#136578 sw BreakDashedLine: edit/delete PageAfter

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.
Comment 8 Commit Notification 2020-12-23 18:42:58 UTC
Xisco Fauli committed a patch related to this issue.
It has been pushed to "master":

https://git.libreoffice.org/core/commit/d42c73d0bc064633a51db8c1d5fa9e2f60cba5e8

tdf#136578: uitest: add wrapper for PageBreakWin

It will be available in 7.2.0.

The patch should be included in the daily builds available at
https://dev-builds.libreoffice.org/daily/ in the next 24-48 hours. More
information about daily builds can be found at:
https://wiki.documentfoundation.org/Testing_Daily_Builds

Affected users are encouraged to test the fix and report feedback.